[GitHub] [superset] codyml commented on pull request #21154: [WIP] fix(explore): Prevent unnecessary series limit subquery

[GitBox <gi...@apache.org>]

codyml commented on PR #21154:
URL: https://github.com/apache/superset/pull/21154#issuecomment-1224664202

   > @codyml thanks for working on this - this is indeed an important fix. One of the reasons for that check is because legacy timeseries charts don't populate `series_columns`, and just assume `columns` or `groupby` is equal to `series_columns` (see #16660 for more context on this change). At the time we chose to ensure that the current functionality is unchanged, thereby adding that check. So I think removing it may cause a regression in some old charts. Let me see if I can propose an alternative solution that fixes the issue with `GENERIC_CHART_AXES` without introducing regression risk into old charts (give me a day or two).
   
   
   @villebro Thanks for the info, that's the kind of thing I was worried about.  One idea I had was to extend the query object to include the `x_axis` field that the frontend sends in `form_data`, and use that to conditionally exclude the `x_axis` column in that part of the code, which hopefully would leave legacy charts that don't support generic x-axis unaffected.  Do you think that would work?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org