You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by necouchman <gi...@git.apache.org> on 2018/02/23 16:36:51 UTC
[GitHub] guacamole-server pull request #155: GUACAMOLE-446: Allow redirected drive na...
GitHub user necouchman opened a pull request:
https://github.com/apache/guacamole-server/pull/155
GUACAMOLE-446: Allow redirected drive name to be configured
Allows for the name of the redirected drive to be configured when pushing a filesystem through via RDP.
Note that this change not only allows for the name to be configured, but also *removes UTF-16 encoding* of the drive name as it appears that Windows does not expect the filesystem name to be UTF-16 encoded.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/necouchman/guacamole-server GUACAMOLE-446
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/guacamole-server/pull/155.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #155
----
commit 5cc4defe848caa294fa8a3761f155acf41758876
Author: Nick Couchman <vn...@...>
Date: 2018-02-23T13:30:27Z
GUACAMOLE-446: Implement support for setting the drive name in RDP.
commit e1c727668ee35e345078339996a5ca51c8af7cc0
Author: Nick Couchman <vn...@...>
Date: 2018-02-23T16:07:13Z
GUACAMOLE-446: Don't convert filesystem share name to UTF-16.
----
---
[GitHub] guacamole-server pull request #155: GUACAMOLE-446: Allow redirected drive na...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/155#discussion_r175278157
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.h ---
@@ -42,7 +42,7 @@
* Registers a new filesystem device within the RDPDR plugin. This must be done
* before RDPDR connection finishes.
*/
-void guac_rdpdr_register_fs(guac_rdpdrPlugin* rdpdr);
+void guac_rdpdr_register_fs(guac_rdpdrPlugin* rdpdr, char* drive_name);
--- End diff --
The documentation for this function should be brought up-to-date now that it's being updated. Other than that, I think these changes are pretty much good to go.
---
[GitHub] guacamole-server pull request #155: GUACAMOLE-446: Allow redirected drive na...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/guacamole-server/pull/155
---
[GitHub] guacamole-server pull request #155: GUACAMOLE-446: Allow redirected drive na...
Posted by necouchman <gi...@git.apache.org>.
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/155#discussion_r176919439
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.h ---
@@ -42,7 +42,7 @@
* Registers a new filesystem device within the RDPDR plugin. This must be done
* before RDPDR connection finishes.
*/
-void guac_rdpdr_register_fs(guac_rdpdrPlugin* rdpdr);
+void guac_rdpdr_register_fs(guac_rdpdrPlugin* rdpdr, char* drive_name);
--- End diff --
Updated.
---