You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pritisarap12 <gi...@git.apache.org> on 2015/07/15 08:59:50 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8636: Verify failure of creati...
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/592
CLOUDSTACK-8636: Verify failure of creation of Custom disk offering with disksize parameter
Custom disk creation should not take disksize parameter while creating the disk offering
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pritisarap12/cloudstack CLOUDSTACK-8636-Verify-failure-of-creation-of-Custom-disk-offering-with-disksize-parameter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/592.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #592
----
commit b3c01f8bc3f46b65cb996373cd962392d4588a92
Author: Priti Sarap <pr...@clogeny.com>
Date: 2015-07-15T06:56:45Z
CLOUDSTACK-8636: Verify failure of creation of Custom disk offering with disksize parameter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8636: Verify failure of creati...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/592#issuecomment-121602397
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8636: Verify failure of creati...
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/592#discussion_r34650908
--- Diff: test/integration/testpaths/testpath_custom_disk_offering.py ---
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" Test case for Create Custom DiskOffering with size Test Path
+"""
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (createDiskOffering)
+from marvin.lib.utils import (cleanup_resources)
+from marvin.lib.common import (get_domain,
+ get_zone
+ )
+
+
+class TestCustomDiskOfferingWithSize(cloudstackTestCase):
+
+ @classmethod
+ def setUpClass(cls):
+ testClient = super(
+ TestCustomDiskOfferingWithSize,
+ cls).getClsTestClient()
+ cls.apiclient = testClient.getApiClient()
+ cls.testdata = testClient.getParsedTestDataConfig()
+ cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+ # Get Zone, Domain and templates
+ cls.domain = get_domain(cls.apiclient)
+ cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+ cls._cleanup = []
+
+ cls.tearDownClass()
+
+ return
+
+ @classmethod
+ def tearDownClass(cls):
+ try:
+ cleanup_resources(cls.apiclient, cls._cleanup)
+ except Exception as e:
+ raise Exception("Warning: Exception during cleanup : %s" % e)
+
+ def setUp(self):
+ self.apiclient = self.testClient.getApiClient()
+ self.dbclient = self.testClient.getDbConnection()
+ self.cleanup = []
+
+ def tearDown(self):
+ try:
+ cleanup_resources(self.apiclient, self.cleanup)
+ except Exception as e:
+ raise Exception("Warning: Exception during cleanup : %s" % e)
+ return
+
+ @attr(tags=["basic", "advanced"], required_hardware="false")
+ def test_create_custom_disk_offering_with_size(self):
+ """ Create custom disk offerign with size
+ 1. Create custom disk offering with size.
+ 2. Should not allow to create custom disk offering
+ with size mentioned.(Exception should be raised)
+ """
+
+ with self.assertRaises(Exception):
--- End diff --
Due to product bug, if custom disk offering is created with size we need to delete it as part of cleanup. Can you please handle this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8636: Verify failure of creati...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/592#issuecomment-121602562
squashed/merged your commits; in future please try to squash them as you iterate with your reviews
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8636: Verify failure of creati...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/592
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8636: Verify failure
of creati...
Posted by Sanjeev N <sa...@apache.org>.
LGTM
On Wed, Jul 15, 2015 at 2:04 PM, pritisarap12 <gi...@git.apache.org> wrote:
> Github user pritisarap12 commented on a diff in the pull request:
>
> https://github.com/apache/cloudstack/pull/592#discussion_r34656988
>
> --- Diff: test/integration/testpaths/testpath_custom_disk_offering.py
> ---
> @@ -0,0 +1,84 @@
> +# Licensed to the Apache Software Foundation (ASF) under one
> +# or more contributor license agreements. See the NOTICE file
> +# distributed with this work for additional information
> +# regarding copyright ownership. The ASF licenses this file
> +# to you under the Apache License, Version 2.0 (the
> +# "License"); you may not use this file except in compliance
> +# with the License. You may obtain a copy of the License at
> +#
> +# http://www.apache.org/licenses/LICENSE-2.0
> +#
> +# Unless required by applicable law or agreed to in writing,
> +# software distributed under the License is distributed on an
> +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> +# KIND, either express or implied. See the License for the
> +# specific language governing permissions and limitations
> +# under the License.
> +""" Test case for Create Custom DiskOffering with size Test Path
> +"""
> +
> +from nose.plugins.attrib import attr
> +from marvin.cloudstackTestCase import cloudstackTestCase
> +from marvin.cloudstackAPI import (createDiskOffering)
> +from marvin.lib.utils import (cleanup_resources)
> +from marvin.lib.common import (get_domain,
> + get_zone
> + )
> +
> +
> +class TestCustomDiskOfferingWithSize(cloudstackTestCase):
> +
> + @classmethod
> + def setUpClass(cls):
> + testClient = super(
> + TestCustomDiskOfferingWithSize,
> + cls).getClsTestClient()
> + cls.apiclient = testClient.getApiClient()
> + cls.testdata = testClient.getParsedTestDataConfig()
> + cls.hypervisor = cls.testClient.getHypervisorInfo()
> +
> + # Get Zone, Domain and templates
> + cls.domain = get_domain(cls.apiclient)
> + cls.zone = get_zone(cls.apiclient,
> testClient.getZoneForTests())
> + cls._cleanup = []
> +
> + cls.tearDownClass()
> +
> + return
> +
> + @classmethod
> + def tearDownClass(cls):
> + try:
> + cleanup_resources(cls.apiclient, cls._cleanup)
> + except Exception as e:
> + raise Exception("Warning: Exception during cleanup : %s"
> % e)
> +
> + def setUp(self):
> + self.apiclient = self.testClient.getApiClient()
> + self.dbclient = self.testClient.getDbConnection()
> + self.cleanup = []
> +
> + def tearDown(self):
> + try:
> + cleanup_resources(self.apiclient, self.cleanup)
> + except Exception as e:
> + raise Exception("Warning: Exception during cleanup : %s"
> % e)
> + return
> +
> + @attr(tags=["basic", "advanced"], required_hardware="false")
> + def test_create_custom_disk_offering_with_size(self):
> + """ Create custom disk offerign with size
> + 1. Create custom disk offering with size.
> + 2. Should not allow to create custom disk offering
> + with size mentioned.(Exception should be raised)
> + """
> +
> + with self.assertRaises(Exception):
> --- End diff --
>
> Updated the testcase as per review changes.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] cloudstack pull request: CLOUDSTACK-8636: Verify failure of creati...
Posted by pritisarap12 <gi...@git.apache.org>.
Github user pritisarap12 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/592#discussion_r34656988
--- Diff: test/integration/testpaths/testpath_custom_disk_offering.py ---
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" Test case for Create Custom DiskOffering with size Test Path
+"""
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (createDiskOffering)
+from marvin.lib.utils import (cleanup_resources)
+from marvin.lib.common import (get_domain,
+ get_zone
+ )
+
+
+class TestCustomDiskOfferingWithSize(cloudstackTestCase):
+
+ @classmethod
+ def setUpClass(cls):
+ testClient = super(
+ TestCustomDiskOfferingWithSize,
+ cls).getClsTestClient()
+ cls.apiclient = testClient.getApiClient()
+ cls.testdata = testClient.getParsedTestDataConfig()
+ cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+ # Get Zone, Domain and templates
+ cls.domain = get_domain(cls.apiclient)
+ cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+ cls._cleanup = []
+
+ cls.tearDownClass()
+
+ return
+
+ @classmethod
+ def tearDownClass(cls):
+ try:
+ cleanup_resources(cls.apiclient, cls._cleanup)
+ except Exception as e:
+ raise Exception("Warning: Exception during cleanup : %s" % e)
+
+ def setUp(self):
+ self.apiclient = self.testClient.getApiClient()
+ self.dbclient = self.testClient.getDbConnection()
+ self.cleanup = []
+
+ def tearDown(self):
+ try:
+ cleanup_resources(self.apiclient, self.cleanup)
+ except Exception as e:
+ raise Exception("Warning: Exception during cleanup : %s" % e)
+ return
+
+ @attr(tags=["basic", "advanced"], required_hardware="false")
+ def test_create_custom_disk_offering_with_size(self):
+ """ Create custom disk offerign with size
+ 1. Create custom disk offering with size.
+ 2. Should not allow to create custom disk offering
+ with size mentioned.(Exception should be raised)
+ """
+
+ with self.assertRaises(Exception):
--- End diff --
Updated the testcase as per review changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8636: Verify failure of creati...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/592#issuecomment-121511374
This description looks better, @pritisarap12 . I think you meant something like that for your previous PR.
I will wait for the build/travis and vote on them.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---