[GitHub] [hbase] joshelser commented on issue #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when…

[GitBox <gi...@apache.org>]

joshelser commented on issue #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when…
URL: https://github.com/apache/hbase/pull/740#issuecomment-553981589
 
 
   Chatted with wellington a little bit to give some more context (I was worried I would be too vague, but here goes anyways).
   
   My concern stems from having multiple paths in which we call `HFileArchive.archiveStoreFiles` which have both the storefile FS and the wal FS passed in. As such, my concern is that the logic in this patch currently may still fall short:
   
   1. We have a separate FS for WALs
   2. We have HFileArchiver.archiveStoreFiles is called with the rootdir's FS (via HRegion)
   3. We fail in the same manner
   
   I don't have a specific codepath which I think will hit this problem (yet), but it worries me that we're leaving this gap. For example, HStore will call this method for the normal StoreFile archival path. I think it would make me more comfortable if we at least have a separate entry point to archive things on the WAL FS, even if it's just giving us a different method name to call and clear expectations on what FS (and the scheme which should be valid). I think keeping the same underlying implementation is fine (better to not copy that code).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services