You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/28 05:40:00 UTC
[GitHub] [cloudstack] sureshanaparti opened a new pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
sureshanaparti opened a new pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162
### Description
The following DB parameters are already updated as part of inclusivity changes (Refer: commit fe4a5b6e938e2f677d5d78cb5e6a12dce60a4a00 [1]). The new options 'secondsBeforeRetrySource', 'queriesBeforeRetrySource' works with mysql connector 8.0 [2][3] and supported for MySQL Server 5.6, 5.7 and 8.0.
- db.cloud.slaves => db.cloud.replicas
- db.cloud.secondsBeforeRetryMaster => db.cloud.secondsBeforeRetrySource
- db.cloud.queriesBeforeRetryMaster => db.cloud.queriesBeforeRetrySource
- db.usage.slaves => db.usage.replicas
- db.usage.secondsBeforeRetryMaster =>db.usage.secondsBeforeRetrySource
- db.usage.queriesBeforeRetryMaster => db.usage.queriesBeforeRetrySource
This PR replaces these DB properties having master and slave(s), with source and replica(s) respectively on upgrade (for inclusiveness).
[1] https://github.com/apache/cloudstack/pull/4922/commits/fe4a5b6e938e2f677d5d78cb5e6a12dce60a4a00
[2] https://dev.mysql.com/doc/connector-j/8.0/en/connector-j-config-failover.html
[3] https://dev.mysql.com/doc/connector-j/8.0/en/connector-j-reference-configuration-properties.html
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-869373877
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache edited a comment on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870369079
@sureshanaparti
to avoid potential issue, would it better to strictly search string in sed/grep commands, for example use "grep -w" and/or add "^","$" or space ?, or use the full string in search, like '^db.cloud.slaves=' ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870494904
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870525467
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-869401470
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-869807693
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-869785071
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-871191592
<b>Trillian test result (tid-1155)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 71070 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5162-t1155-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 82 look OK, 6 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_deploy_and_upgrade_kubernetes_cluster | `Error` | 4159.14 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 107.31 | test_kubernetes_clusters.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 523.96 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 523.97 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 490.19 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 490.61 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 490.62 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870363011
> LGTM in the draft - the changes in the db.properties file can be automated via upgrade handling of rpms. @sureshanaparti can you also check for debian packaging?
updated @rhtyd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870438448
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-869785777
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870369079
@sureshanaparti
to avoid potential issue, would it better to strictly search string in sed/grep commands, for example use "grep -w" and/or add "^","$" or space ?, or use the full string in search, like 'db.cloud.slaves=' ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-871342098
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti removed a comment on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
sureshanaparti removed a comment on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870486508
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-869373730
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870437728
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870254207
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870486874
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti merged pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-871911434
> Trillian test result (tid-1176)
> Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
> Total time taken: 42990 seconds
> Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5162-t1176-kvm-centos7.zip
> Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
> Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
> Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
> Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
> Smoke tests completed. 86 look OK, 2 have error(s)
> Only failed tests results shown below:
>
> Test Result Time (s) Test File
> test_05_ping_in_cpvm_success `Failure` 14.32 test_diagnostics.py
> test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers `Failure` 472.14 test_vpc_redundant.py
> test_05_rvpc_multi_tiers `Failure` 516.21 test_vpc_redundant.py
these failures are not related to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870381687
> @sureshanaparti
> to avoid potential issue, would it better to strictly search string in sed/grep commands, for example use "grep -w" and/or add "^","$" or space ?, or use the full string in search, like '^db.cloud.slaves=' ?
@weizhouapache there are few params with master / slaves (mentioned in the description), and all these have to be replaced (for inclusiveness). I tested it, and no issues there. These terms have to be avoided in any property defined later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870486508
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-871342244
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870524859
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870495283
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-869785777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870486874
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-871822692
<b>Trillian test result (tid-1176)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42990 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5162-t1176-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 86 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_ping_in_cpvm_success | `Failure` | 14.32 | test_diagnostics.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 472.14 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 516.21 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870397693
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870486874
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti removed a comment on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
sureshanaparti removed a comment on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870486508
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870361821
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870446078
> > LGTM in this particular case, but I do agree with @weizhouapache - more safety is never a bad idea.
>
> @vladimirpetrov Updated changes as per @weizhouapache suggestion.
@sureshanaparti great! code lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870362264
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-869785071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870418573
> > @sureshanaparti
> > to avoid potential issue, would it better to strictly search string in sed/grep commands, for example use "grep -w" and/or add "^","$" or space ?, or use the full string in search, like '^db.cloud.slaves=' ?
>
> @weizhouapache there are few params with master / slaves (mentioned in the description), and all these have to be replaced (for inclusiveness). I tested it, and no issues there. These terms have to be avoided in any property defined later.
@sureshanaparti in 99.99% cases it should work without any issue.
But, for example, if db user or db password contains "Master" or "slaves", will there be issues after uprgade ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870483509
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian :heavy_multiplication_x: suse. SL-JID 415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-871911639
merging this based on lgtms, manual and smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache edited a comment on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870369079
@sureshanaparti
to avoid potential issue, would it better to strictly search string in sed/grep commands, for example use "grep -w" and/or add "^","$" or space ?, or use the full string in search, like '^db.cloud.slaves=' ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870437194
> LGTM in this particular case, but I do agree with @weizhouapache - more safety is never a bad idea.
@vladimirpetrov Updated changes as per @weizhouapache suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870522726
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian :heavy_multiplication_x: suse. SL-JID 418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5162: On Upgrade, Replace the DB properties having master and slave(s), with source and replica(s) respectively for inclusiveness
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5162:
URL: https://github.com/apache/cloudstack/pull/5162#issuecomment-870369079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org