You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/04 07:50:04 UTC
[GitHub] [airflow] potiuk opened a new pull request, #24819: Remove upper-binding for SQLAlchemy
potiuk opened a new pull request, #24819:
URL: https://github.com/apache/airflow/pull/24819
There was a problem with custom classes for SQLAlchemy that
prevented it to work on MySQL. This PR removes the SQLAlchemy
upper binding.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24819: Remove upper-binding for SQLAlchemy
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24819:
URL: https://github.com/apache/airflow/pull/24819#issuecomment-1174234844
All Green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #24819: Remove upper-binding for SQLAlchemy
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24819:
URL: https://github.com/apache/airflow/pull/24819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24819: Remove upper-binding for SQLAlchemy
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24819:
URL: https://github.com/apache/airflow/pull/24819#issuecomment-1173473376
Let's see if the problem has been fixed in the meantime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24819: Remove upper-binding for SQLAlchemy
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24819:
URL: https://github.com/apache/airflow/pull/24819#issuecomment-1173880718
Hey @ephraimbuddy @dstandish - I got the tests for MSSQL workiig for latest SQLalachemy but I am not sure if the solution to the failing tetst were good.
There were a number tests added recently to those db migration scripts (good!) and apparently when I migrated to latest sqlalchemy the previous problem mentioned in #21272 is solved but this one tests comparing the schema with the ORM information failled. I am not sure if I fixed it correctly, the root cause of this is likely this one:
https://github.com/apache/airflow/blob/main/airflow/migrations/versions/0093_2_2_0_taskinstance_keyed_to_dagrun.py#L278
I believe the CASCADE modification was the problem. Both "diffs" that I ignored had "CASCADE" ondelete, where we are definitely setting NO_ACTION for MsSQL due to the https://docs.microsoft.com/en-us/sql/relational-databases/errors-events/mssqlserver-1785-database-engine-error?view=sql-server-ver15
So I guess for some reason our "diff" script expects CASCADE but gets NO_ACTION,
I just ignored the offending differences - similarly to others tests, but maybe this is an indication of some other problem we have (or maybe our diff is not robust enough to account for differences between the dialects?)
Any insight and comments (and maybe approval if I did it correctly) is appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org