You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by ec...@apache.org on 2008/01/29 22:02:58 UTC
svn commit: r616518 - in
/geronimo/server/trunk/plugins/monitoring/agent-jmx/src/main/java/org/apache/geronimo/monitoring:
MasterRemoteControlJMX.java snapshot/SnapshotThread.java
Author: ecraig
Date: Tue Jan 29 13:02:55 2008
New Revision: 616518
URL: http://svn.apache.org/viewvc?rev=616518&view=rev
Log:
GERONIMO-3790
monitoring agent should provide jmx support
Patch by Viet Nguyen to provide isSnapshotRunning method to agent-jmx
Modified:
geronimo/server/trunk/plugins/monitoring/agent-jmx/src/main/java/org/apache/geronimo/monitoring/MasterRemoteControlJMX.java
geronimo/server/trunk/plugins/monitoring/agent-jmx/src/main/java/org/apache/geronimo/monitoring/snapshot/SnapshotThread.java
Modified: geronimo/server/trunk/plugins/monitoring/agent-jmx/src/main/java/org/apache/geronimo/monitoring/MasterRemoteControlJMX.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/monitoring/agent-jmx/src/main/java/org/apache/geronimo/monitoring/MasterRemoteControlJMX.java?rev=616518&r1=616517&r2=616518&view=diff
==============================================================================
--- geronimo/server/trunk/plugins/monitoring/agent-jmx/src/main/java/org/apache/geronimo/monitoring/MasterRemoteControlJMX.java (original)
+++ geronimo/server/trunk/plugins/monitoring/agent-jmx/src/main/java/org/apache/geronimo/monitoring/MasterRemoteControlJMX.java Tue Jan 29 13:02:55 2008
@@ -474,7 +474,7 @@
*/
public boolean isSnapshotRunning() {
// TODO: check if the snapshot thread is running
- return false;
+ return snapshotThread.isSnapshotRunning();
}
public static final GBeanInfo GBEAN_INFO;
Modified: geronimo/server/trunk/plugins/monitoring/agent-jmx/src/main/java/org/apache/geronimo/monitoring/snapshot/SnapshotThread.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/monitoring/agent-jmx/src/main/java/org/apache/geronimo/monitoring/snapshot/SnapshotThread.java?rev=616518&r1=616517&r2=616518&view=diff
==============================================================================
--- geronimo/server/trunk/plugins/monitoring/agent-jmx/src/main/java/org/apache/geronimo/monitoring/snapshot/SnapshotThread.java (original)
+++ geronimo/server/trunk/plugins/monitoring/agent-jmx/src/main/java/org/apache/geronimo/monitoring/snapshot/SnapshotThread.java Tue Jan 29 13:02:55 2008
@@ -51,6 +51,10 @@
public long getSnapshotDuration() {
return SNAPSHOT_DURATION;
}
+
+ public boolean isSnapshotRunning() {
+ return SNAPSHOT_DURATION == Long.MAX_VALUE;
+ }
/**
* Adds the mbean name to list in memory. To update the snapshot-config.xml