You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/02/08 13:00:30 UTC

[GitHub] [servicecomb-java-chassis] david6969xin opened a new pull request #2688: [SCB-2367] optimize microservice.yaml load log

david6969xin opened a new pull request #2688:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2688


   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] david6969xin commented on a change in pull request #2688: [SCB-2367] optimize microservice.yaml load log

Posted by GitBox <gi...@apache.org>.
david6969xin commented on a change in pull request #2688:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2688#discussion_r790389926



##########
File path: foundations/foundation-config/src/main/java/org/apache/servicecomb/config/archaius/sources/MicroserviceConfigLoader.java
##########
@@ -69,8 +70,8 @@ public void loadAndSort() {
       }
 
       sort();
-    } catch (IOException e) {
-      throw new ServiceCombException("Failed to load microservice config", e);
+    } catch (Exception e) {
+      throw new ServiceCombException("Failed to load microservice configFile " + configFileFromClasspath + " and " + e.getMessage());

Review comment:
       done

##########
File path: foundations/foundation-config/src/main/java/org/apache/servicecomb/config/YAMLUtil.java
##########
@@ -96,14 +96,18 @@ private YAMLUtil() {
 
     for (Map.Entry<String, Object> entry : propertieMap.entrySet()) {
       if (entry.getValue() instanceof Map) {
-        result.putAll(retrieveItems(prefix + entry.getKey(), (Map<String, Object>) entry.getValue()));
+          result.putAll(retrieveItems(prefix + entry.getKey(), (Map<String, Object>) entry.getValue()));

Review comment:
       ok




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2688: [SCB-2367] optimize microservice.yaml load log

Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #2688:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2688


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2688: [SCB-2367] optimize microservice.yaml load log

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2688:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2688#discussion_r801241982



##########
File path: foundations/foundation-config/src/main/java/org/apache/servicecomb/config/YAMLUtil.java
##########
@@ -55,15 +55,34 @@ private YAMLUtil() {
   public static Map<String, Object> yaml2Properties(InputStream input) {
     Map<String, Object> configurations = new LinkedHashMap<>();
     SAFE_PARSER.loadAll(input).forEach(data -> {
-      if (data instanceof Map) {
+      if (data instanceof Map && isValidMap((Map<Object, Object>) data)) {
         configurations.putAll(retrieveItems("", (Map<String, Object>) data));
       } else {
-        LOGGER.warn("input cannot be convert to map");
+        throw new IllegalArgumentException("input cannot be convert to map");
       }
     });
     return configurations;
   }
 
+  @SuppressWarnings("unchecked")
+  private static boolean isValidMap(Map<Object, Object> data) {
+    boolean flag = false;
+    for (Map.Entry<Object, Object> entry : data.entrySet()) {
+      Object key = entry.getKey();
+      Object value = entry.getValue();
+      if (key instanceof String) {
+        if (value instanceof Map) {
+          return isValidMap((Map<Object, Object>) value);
+        } else {
+          flag = true;
+        }
+      } else {
+        flag = false;
+      }
+    }
+    return flag;
+  }
+

Review comment:
       ```
     private static boolean isValidMap(Map<Object, Object> data) {
       for (Map.Entry<Object, Object> entry : data.entrySet()) {
         Object key = entry.getKey();
         Object value = entry.getValue();
         if (key instanceof String) {
           if (value instanceof Map) {
             return isValidMap((Map<Object, Object>) value);
           } 
           continue;        
         }
         return false;
       }
      return true;
     }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2688: [SCB-2367] optimize microservice.yaml load log

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2688:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2688#issuecomment-1007157225


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2688](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4c44c10) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/c1cb7381c7b46ca5be7dda1eba5eef226558133f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1cb738) will **increase** coverage by `0.00%`.
   > The diff coverage is `71.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #2688   +/-   ##
   =========================================
     Coverage     77.76%   77.76%           
     Complexity     1430     1430           
   =========================================
     Files          1598     1598           
     Lines         42774    42777    +3     
     Branches       3610     3611    +1     
   =========================================
   + Hits          33262    33266    +4     
   + Misses         7998     7997    -1     
     Partials       1514     1514           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...fig/archaius/sources/MicroserviceConfigLoader.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb25maWcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2NvbmZpZy9hcmNoYWl1cy9zb3VyY2VzL01pY3Jvc2VydmljZUNvbmZpZ0xvYWRlci5qYXZh) | `75.86% <50.00%> (+0.86%)` | :arrow_up: |
   | [...n/java/org/apache/servicecomb/config/YAMLUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb25maWcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2NvbmZpZy9ZQU1MVXRpbC5qYXZh) | `82.85% <100.00%> (+1.03%)` | :arrow_up: |
   | [...thentication/consumer/RSAConsumerTokenManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvYXV0aGVudGljYXRpb24vY29uc3VtZXIvUlNBQ29uc3VtZXJUb2tlbk1hbmFnZXIuamF2YQ==) | `70.96% <0.00%> (-6.46%)` | :arrow_down: |
   | [...ecomb/foundation/common/utils/SPIServiceUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL3V0aWxzL1NQSVNlcnZpY2VVdGlscy5qYXZh) | `89.65% <0.00%> (-1.73%)` | :arrow_down: |
   | [...he/servicecomb/foundation/common/net/NetUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9OZXRVdGlscy5qYXZh) | `64.56% <0.00%> (+1.57%)` | :arrow_up: |
   | [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `100.00% <0.00%> (+3.50%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1cb738...4c44c10](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2688: [SCB-2367] optimize microservice.yaml load log

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2688:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2688#issuecomment-1007157225


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2688](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4223b1) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/c1cb7381c7b46ca5be7dda1eba5eef226558133f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1cb738) will **decrease** coverage by `0.52%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2688      +/-   ##
   ============================================
   - Coverage     77.76%   77.23%   -0.53%     
   + Complexity     1430     1413      -17     
   ============================================
     Files          1598     1608      +10     
     Lines         42774    42980     +206     
     Branches       3610     3644      +34     
   ============================================
   - Hits          33262    33195      -67     
   - Misses         7998     8262     +264     
   - Partials       1514     1523       +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...fig/archaius/sources/MicroserviceConfigLoader.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb25maWcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2NvbmZpZy9hcmNoYWl1cy9zb3VyY2VzL01pY3Jvc2VydmljZUNvbmZpZ0xvYWRlci5qYXZh) | `75.86% <50.00%> (+0.86%)` | :arrow_up: |
   | [...n/java/org/apache/servicecomb/config/YAMLUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb25maWcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2NvbmZpZy9ZQU1MVXRpbC5qYXZh) | `83.33% <100.00%> (+1.51%)` | :arrow_up: |
   | [...enter/client/model/QueryConfigurationsRequest.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9jb25maWctY2VudGVyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2NlbnRlci9jbGllbnQvbW9kZWwvUXVlcnlDb25maWd1cmF0aW9uc1JlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rvicecomb/config/center/client/AddressManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9jb25maWctY2VudGVyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2NlbnRlci9jbGllbnQvQWRkcmVzc01hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (-68.75%)` | :arrow_down: |
   | [...ecomb/http/client/common/HttpTransportFactory.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9odHRwLWNsaWVudC1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2h0dHAvY2xpZW50L2NvbW1vbi9IdHRwVHJhbnNwb3J0RmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-65.39%)` | :arrow_down: |
   | [...comb/config/center/client/ConfigCenterManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9jb25maWctY2VudGVyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2NlbnRlci9jbGllbnQvQ29uZmlnQ2VudGVyTWFuYWdlci5qYXZh) | `0.00% <0.00%> (-65.39%)` | :arrow_down: |
   | [...che/servicecomb/http/client/task/AbstractTask.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9odHRwLWNsaWVudC1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2h0dHAvY2xpZW50L3Rhc2svQWJzdHJhY3RUYXNrLmphdmE=) | `0.00% <0.00%> (-59.58%)` | :arrow_down: |
   | [...ig/center/client/exception/OperationException.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9jb25maWctY2VudGVyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2NlbnRlci9jbGllbnQvZXhjZXB0aW9uL09wZXJhdGlvbkV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [...ecomb/config/center/client/ConfigCenterClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9jb25maWctY2VudGVyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2NlbnRlci9jbGllbnQvQ29uZmlnQ2VudGVyQ2xpZW50LmphdmE=) | `0.00% <0.00%> (-44.24%)` | :arrow_down: |
   | [...vicecomb/http/client/common/HttpConfiguration.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9odHRwLWNsaWVudC1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2h0dHAvY2xpZW50L2NvbW1vbi9IdHRwQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (-40.00%)` | :arrow_down: |
   | ... and [56 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1cb738...a4223b1](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2688: [SCB-2367] optimize microservice.yaml load log

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2688:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2688#issuecomment-1007157225


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2688](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4c44c10) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/c1cb7381c7b46ca5be7dda1eba5eef226558133f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1cb738) will **increase** coverage by `0.00%`.
   > The diff coverage is `71.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #2688   +/-   ##
   =========================================
     Coverage     77.76%   77.76%           
     Complexity     1430     1430           
   =========================================
     Files          1598     1598           
     Lines         42774    42777    +3     
     Branches       3610     3611    +1     
   =========================================
   + Hits          33262    33266    +4     
   + Misses         7998     7997    -1     
     Partials       1514     1514           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...fig/archaius/sources/MicroserviceConfigLoader.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb25maWcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2NvbmZpZy9hcmNoYWl1cy9zb3VyY2VzL01pY3Jvc2VydmljZUNvbmZpZ0xvYWRlci5qYXZh) | `75.86% <50.00%> (+0.86%)` | :arrow_up: |
   | [...n/java/org/apache/servicecomb/config/YAMLUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb25maWcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2NvbmZpZy9ZQU1MVXRpbC5qYXZh) | `82.85% <100.00%> (+1.03%)` | :arrow_up: |
   | [...thentication/consumer/RSAConsumerTokenManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvYXV0aGVudGljYXRpb24vY29uc3VtZXIvUlNBQ29uc3VtZXJUb2tlbk1hbmFnZXIuamF2YQ==) | `70.96% <0.00%> (-6.46%)` | :arrow_down: |
   | [...ecomb/foundation/common/utils/SPIServiceUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL3V0aWxzL1NQSVNlcnZpY2VVdGlscy5qYXZh) | `89.65% <0.00%> (-1.73%)` | :arrow_down: |
   | [...he/servicecomb/foundation/common/net/NetUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9OZXRVdGlscy5qYXZh) | `64.56% <0.00%> (+1.57%)` | :arrow_up: |
   | [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `100.00% <0.00%> (+3.50%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1cb738...4c44c10](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #2688: [#2657] optimize microservice.yaml load log

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2688:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2688#issuecomment-1007157225


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2688](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5104898) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/c1cb7381c7b46ca5be7dda1eba5eef226558133f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1cb738) will **increase** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #2688   +/-   ##
   =========================================
     Coverage     77.76%   77.76%           
     Complexity     1430     1430           
   =========================================
     Files          1598     1598           
     Lines         42774    42776    +2     
     Branches       3610     3611    +1     
   =========================================
   + Hits          33262    33265    +3     
   + Misses         7998     7997    -1     
     Partials       1514     1514           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/servicecomb/config/YAMLUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb25maWcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2NvbmZpZy9ZQU1MVXRpbC5qYXZh) | `82.85% <100.00%> (+1.03%)` | :arrow_up: |
   | [...thentication/consumer/RSAConsumerTokenManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvYXV0aGVudGljYXRpb24vY29uc3VtZXIvUlNBQ29uc3VtZXJUb2tlbk1hbmFnZXIuamF2YQ==) | `70.96% <0.00%> (-6.46%)` | :arrow_down: |
   | [...comb/core/definition/MicroserviceVersionsMeta.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9kZWZpbml0aW9uL01pY3Jvc2VydmljZVZlcnNpb25zTWV0YS5qYXZh) | `94.73% <0.00%> (-5.27%)` | :arrow_down: |
   | [...he/servicecomb/foundation/common/net/NetUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9OZXRVdGlscy5qYXZh) | `64.56% <0.00%> (+1.57%)` | :arrow_up: |
   | [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `100.00% <0.00%> (+3.50%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1cb738...5104898](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 closed pull request #2688: [SCB-2367] optimize microservice.yaml load log

Posted by GitBox <gi...@apache.org>.
liubao68 closed pull request #2688:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2688


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2688: [SCB-2367] optimize microservice.yaml load log

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2688:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2688#discussion_r789271830



##########
File path: foundations/foundation-config/src/main/java/org/apache/servicecomb/config/archaius/sources/MicroserviceConfigLoader.java
##########
@@ -69,8 +70,8 @@ public void loadAndSort() {
       }
 
       sort();
-    } catch (IOException e) {
-      throw new ServiceCombException("Failed to load microservice config", e);
+    } catch (Exception e) {
+      throw new ServiceCombException("Failed to load microservice configFile " + configFileFromClasspath + " and " + e.getMessage());

Review comment:
       throw new ServiceCombException("Failed to load microservice configFile " + configFileFromClasspath, e);




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2688: [SCB-2367] optimize microservice.yaml load log

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2688:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2688#discussion_r789272169



##########
File path: foundations/foundation-config/src/main/java/org/apache/servicecomb/config/YAMLUtil.java
##########
@@ -96,14 +96,18 @@ private YAMLUtil() {
 
     for (Map.Entry<String, Object> entry : propertieMap.entrySet()) {
       if (entry.getValue() instanceof Map) {
-        result.putAll(retrieveItems(prefix + entry.getKey(), (Map<String, Object>) entry.getValue()));
+          result.putAll(retrieveItems(prefix + entry.getKey(), (Map<String, Object>) entry.getValue()));

Review comment:
       format code




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #2688: [SCB-2367] optimize microservice.yaml load log

Posted by GitBox <gi...@apache.org>.
liubao68 commented on pull request #2688:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2688#issuecomment-1032581956


   retrigger ci


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] david6969xin commented on a change in pull request #2688: [SCB-2367] optimize microservice.yaml load log

Posted by GitBox <gi...@apache.org>.
david6969xin commented on a change in pull request #2688:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2688#discussion_r790389995



##########
File path: foundations/foundation-config/src/main/java/org/apache/servicecomb/config/YAMLUtil.java
##########
@@ -96,14 +96,18 @@ private YAMLUtil() {
 
     for (Map.Entry<String, Object> entry : propertieMap.entrySet()) {
       if (entry.getValue() instanceof Map) {
-        result.putAll(retrieveItems(prefix + entry.getKey(), (Map<String, Object>) entry.getValue()));
+          result.putAll(retrieveItems(prefix + entry.getKey(), (Map<String, Object>) entry.getValue()));
       } else {
-        String key = prefix + entry.getKey();
-        if (key.startsWith(CONFIG_CSE_PREFIX)) {
-          String servicecombKey = CONFIG_SERVICECOMB_PREFIX + key.substring(key.indexOf(".") + 1);
-          result.put(servicecombKey, entry.getValue());
+        if (entry.getKey() instanceof String){
+          String key = prefix + entry.getKey();
+          if (key.startsWith(CONFIG_CSE_PREFIX)) {
+            String servicecombKey = CONFIG_SERVICECOMB_PREFIX + key.substring(key.indexOf(".") + 1);
+            result.put(servicecombKey, entry.getValue());
+          }
+          result.put(key, entry.getValue());
+        }else {
+          throw new IllegalArgumentException("value config error");

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2688: [SCB-2367] optimize microservice.yaml load log

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2688:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2688#issuecomment-1007157225


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2688](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (95ffe50) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/c1cb7381c7b46ca5be7dda1eba5eef226558133f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1cb738) will **increase** coverage by `0.01%`.
   > The diff coverage is `84.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2688      +/-   ##
   ============================================
   + Coverage     77.76%   77.77%   +0.01%     
     Complexity     1430     1430              
   ============================================
     Files          1598     1598              
     Lines         42774    42784      +10     
     Branches       3610     3612       +2     
   ============================================
   + Hits          33262    33276      +14     
   + Misses         7998     7996       -2     
   + Partials       1514     1512       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...fig/archaius/sources/MicroserviceConfigLoader.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb25maWcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2NvbmZpZy9hcmNoYWl1cy9zb3VyY2VzL01pY3Jvc2VydmljZUNvbmZpZ0xvYWRlci5qYXZh) | `75.86% <50.00%> (+0.86%)` | :arrow_up: |
   | [...n/java/org/apache/servicecomb/config/YAMLUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb25maWcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2NvbmZpZy9ZQU1MVXRpbC5qYXZh) | `83.33% <100.00%> (+1.51%)` | :arrow_up: |
   | [.../servicecomb/demo/pojo/client/TestFlowControl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLXBvam8vcG9qby1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RlbW8vcG9qby9jbGllbnQvVGVzdEZsb3dDb250cm9sLmphdmE=) | `92.30% <0.00%> (ø)` | |
   | [...servicecomb/qps/ConsumerQpsFlowControlHandler.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1mbG93Y29udHJvbC1xcHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3Fwcy9Db25zdW1lclFwc0Zsb3dDb250cm9sSGFuZGxlci5qYXZh) | `75.00% <0.00%> (ø)` | |
   | [...servicecomb/qps/ProviderQpsFlowControlHandler.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1mbG93Y29udHJvbC1xcHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3Fwcy9Qcm92aWRlclFwc0Zsb3dDb250cm9sSGFuZGxlci5qYXZh) | `87.50% <0.00%> (ø)` | |
   | [.../servicecomb/qps/strategy/LeakyBucketStrategy.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1mbG93Y29udHJvbC1xcHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3Fwcy9zdHJhdGVneS9MZWFreUJ1Y2tldFN0cmF0ZWd5LmphdmE=) | `85.71% <0.00%> (+1.50%)` | :arrow_up: |
   | [...he/servicecomb/foundation/common/net/NetUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9OZXRVdGlscy5qYXZh) | `64.56% <0.00%> (+1.57%)` | :arrow_up: |
   | [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `100.00% <0.00%> (+3.50%)` | :arrow_up: |
   | [.../servicecomb/qps/strategy/FixedWindowStrategy.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1mbG93Y29udHJvbC1xcHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3Fwcy9zdHJhdGVneS9GaXhlZFdpbmRvd1N0cmF0ZWd5LmphdmE=) | `75.00% <0.00%> (+8.33%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c1cb738...95ffe50](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2688?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2688: [SCB-2367] optimize microservice.yaml load log

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2688:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2688#discussion_r789273022



##########
File path: foundations/foundation-config/src/main/java/org/apache/servicecomb/config/YAMLUtil.java
##########
@@ -96,14 +96,18 @@ private YAMLUtil() {
 
     for (Map.Entry<String, Object> entry : propertieMap.entrySet()) {
       if (entry.getValue() instanceof Map) {
-        result.putAll(retrieveItems(prefix + entry.getKey(), (Map<String, Object>) entry.getValue()));
+          result.putAll(retrieveItems(prefix + entry.getKey(), (Map<String, Object>) entry.getValue()));
       } else {
-        String key = prefix + entry.getKey();
-        if (key.startsWith(CONFIG_CSE_PREFIX)) {
-          String servicecombKey = CONFIG_SERVICECOMB_PREFIX + key.substring(key.indexOf(".") + 1);
-          result.put(servicecombKey, entry.getValue());
+        if (entry.getKey() instanceof String){
+          String key = prefix + entry.getKey();
+          if (key.startsWith(CONFIG_CSE_PREFIX)) {
+            String servicecombKey = CONFIG_SERVICECOMB_PREFIX + key.substring(key.indexOf(".") + 1);
+            result.put(servicecombKey, entry.getValue());
+          }
+          result.put(key, entry.getValue());
+        }else {
+          throw new IllegalArgumentException("value config error");

Review comment:
       throw new IllegalArgumentException("Find invalid configuration item. Prefix is " + prefix);




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org