You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/31 11:34:43 UTC
[GitHub] [arrow-ballista] alamb commented on a diff in pull request #48: Update to apache/arrow-datafusion#2578
alamb commented on code in PR #48:
URL: https://github.com/apache/arrow-ballista/pull/48#discussion_r885525548
##########
ballista/rust/core/src/serde/logical_plan/mod.rs:
##########
@@ -1415,7 +1416,11 @@ mod roundtrip_tests {
let schema = test_schema();
let ctx = SessionContext::new();
let options = CsvReadOptions::new().schema(&schema);
- let df = ctx.read_csv(table_name, options).await?;
+
+ let uri = format!("file:///{}.csv", table_name);
+ ctx.register_csv(table_name, &uri, options).await?;
Review Comment:
CC @andygrove
##########
ballista/rust/core/Cargo.toml:
##########
@@ -39,8 +39,8 @@ arrow-flight = { version = "14.0.0" }
async-trait = "0.1.41"
chrono = { version = "0.4", default-features = false }
clap = { version = "3", features = ["derive", "cargo"] }
-datafusion = { git = "https://github.com/apache/arrow-datafusion", rev = "b6fb0dd52c2abd0f8e134aa46cc1571cc6a0971b" }
-datafusion-proto = { git = "https://github.com/apache/arrow-datafusion", rev = "b6fb0dd52c2abd0f8e134aa46cc1571cc6a0971b" }
+datafusion = { git = "https://github.com/apache/arrow-datafusion", rev = "fdb8fecf0ab475ba07dc0d15f7b53e25ccf30ee7" }
Review Comment:
@andygrove / @thinkharderdev -- what would you think about writing some script that automatically updates this pin rather than requiring datafusion developers manually make PRs?
We basically upgrade the DataFusion pin manually for IOx and while it takes times it seems to work for us -- for example https://github.com/influxdata/influxdb_iox/pull/4619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org