You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@roller.apache.org by Glen Mazza <gl...@gmail.com> on 2014/06/09 12:37:28 UTC
[VOTE] Release Roller 5.0.4
OK, apparently voting is done on DEV and not the private list (not that
the latter emailing system appeared to be accepting my emails
anyway...) Vote is below and I'm resetting the 72 hour clock to zero.
Thanks,
Glen
-------- Original Message --------
On 6/7/2014 11:44 PM, Glen Mazza wrote:
> Hi Team,
>
> This is a vote to release Roller 5.0.4, it upgrades its Struts library
> to 2.3.16.3 to fix some important issues with it; also, some of the
> LDAP configuration was fixed based on comments from a user.
>
> Binaries are here: http://people.apache.org/~gmazza/roller/
>
> I tested the Tomcat version, it looks good.
>
> Here's my +1. Voting will be for 72 hours.
>
> Regards,
> Glen
>
Re: [VOTE] Release Roller 5.0.4 - rc2
Posted by Glen Mazza <gl...@gmail.com>.
I'm surprised about this too, but don't want to research it further as
we don't even use OpenJPA in trunk anymore. I just did the standard
build tomcat script and also tried separately via mvn clean install. I
didn't change the OpenJPA libraries. I'm done with 5.0.x for now, it's
all yours if you wish to look into it yourself. But this is the risk I
mentioned earlier that goes with trying to get rid of deprecated methods
in old builds, you fix this (Struts), then something else old breaks
(OpenJPA), and then you try to fix that, and another old library goes,
and before long you're spending four months backporting 5.1 into 5.0.x
instead of spending one month releasing 5.1.
Glen
On 06/27/2014 02:19 PM, Greg Huber wrote:
> I doubt the struts filter change has anything to do with JPA enhance
> exceptions. These look like the enhancer has not compiled the classes. Is
> this version running the old version of JPA?
>
>
> On 27 June 2014 17:01, Glen Mazza <gl...@gmail.com> wrote:
>
>> Hi Greg, I tried the changes below to web.xml but Roller 5.0.5-SNAPSHOT
>> wouldn't work soon after startup (after the tables were created) -- OpenJPA
>> complaints popped up immediately on the screen and in roller.log:
>>
>> FATAL 2014-06-27 11:28:36,226 JPAPropertiesManagerImpl:initialize -
>> Failed to initialize runtime configuration properties.Please check that the
>> database has been upgraded!
>> <openjpa-2.0.1-r422266:989424 nonfatal user error> org.apache.openjpa.persistence.ArgumentException:
>> This configuration disallows runtime optimization, but the following listed
>> types were not enhanced at build time or at class load time with a
>> javaagent: "
>> org.apache.roller.weblogger.pojos.TaskLock
>> org.apache.roller.weblogger.pojos.OAuthConsumerRecord
>> org.apache.roller.weblogger.pojos.WeblogReferrer
>> org.apache.roller.weblogger.pojos.MediaFile
>> org.apache.roller.weblogger.pojos.WeblogBookmarkFolder
>> ....
>> org.apache.roller.weblogger.pojos.WeblogHitCount".
>> at org.apache.openjpa.enhance.ManagedClassSubclasser.
>> prepareUnenhancedClasses(ManagedClassSubclasser.java:116)
>> at org.apache.openjpa.kernel.AbstractBrokerFactory.
>> loadPersistentTypes(AbstractBrokerFactory.java:317)
>> at org.apache.openjpa.kernel.AbstractBrokerFactory.initializeBroker(
>> AbstractBrokerFactory.java:241)
>> at org.apache.openjpa.kernel.AbstractBrokerFactory.newBroker(
>> AbstractBrokerFactory.java:215)
>> at org.apache.openjpa.kernel.DelegatingBrokerFactory.newBroker(
>> DelegatingBrokerFactory.java:156)
>> at org.apache.openjpa.persistence.EntityManagerFactoryImpl.
>> createEntityManager(EntityManagerFactoryImpl.java:227)
>> at org.apache.openjpa.persistence.EntityManagerFactoryImpl.
>> createEntityManager(EntityManagerFactoryImpl.java:154)
>> at org.apache.openjpa.persistence.EntityManagerFactoryImpl.
>> createEntityManager(EntityManagerFactoryImpl.java:60)
>> at org.apache.roller.weblogger.business.jpa.JPAPersistenceStrategy.
>> getThreadLocalEntityManager(JPAPersistenceStrategy.java:238)
>> at org.apache.roller.weblogger.business.jpa.JPAPersistenceStrategy.
>> getEntityManager(JPAPersistenceStrategy.java:225)
>> at org.apache.roller.weblogger.business.jpa.JPAPersistenceStrategy.
>> getNamedQuery(JPAPersistenceStrategy.java:258)
>>
>> I'm letting 5.0.x go (I didn't commit those changes), although you're of
>> course welcome to research the matter further if you wish.
>>
>> Regards,
>> Glen
>>
>> On 06/24/2014 03:01 AM, Greg Huber wrote:
>>
>>> Depreciated here would mean not supported, hence the warning messages, on
>>> this version of struts.
>>>
>>>
>>> On 23 June 2014 13:51, Glen Mazza <gl...@gmail.com> wrote:
>>>
>>> Deprecation is OK, I'll see if I can take care of that if we have a
>>>> future
>>>> 5.0.5, I'm also a bit concerned about making a change that might break
>>>> parts of 5.0.x, and hence would need massive coding to fix (lots of
>>>> libraries in 5.0.x are old). I want to be coding and releasing 5.1, and
>>>> 5.0.x keeps me from that.
>>>>
>>>> Glen
>>>>
>>>> On 06/23/2014 03:32 AM, Greg Huber wrote:
>>>>
>>>> +1
>>>>> Struts upgrade works ok.
>>>>>
>>>>>
>>>>> ####
>>>>>
>>>>> Might be worth having a check on the templates on
>>>>> /resources/template/roller/*.ftl. (copy from trunk)
>>>>>
>>>>> ####
>>>>>
>>>>> There are some warnings on the web.xml entries for struts:
>>>>>
>>>>> FilterDispatcher <<< is deprecated! Please use the new filters!
>>>>>
>>>>>> ie change from:
>>>>>> <filter>
>>>>> <filter-name>struts2</filter-name>
>>>>>
>>>>> <filter-class>org.apache.struts2.dispatcher.FilterDispatcher</filter-
>>>>> class>
>>>>> </filter>
>>>>>
>>>>> to:
>>>>>
>>>>> <filter>
>>>>> <filter-name>struts2</filter-name>
>>>>>
>>>>> <filter-class>org.apache.struts2.dispatcher.ng.filter.
>>>>> StrutsPrepareAndExecuteFilter</filter-class>
>>>>> </filter>
>>>>>
>>>>> ActionContextCleanUp <<< is deprecated! Please use the new filters!
>>>>>
>>>>>> remove:
>>>>>> <filter>
>>>>> <filter-name>struts2-cleanup</filter-name>
>>>>>
>>>>> <filter-class>org.apache.struts2.dispatcher.
>>>>> ActionContextCleanUp</filter-
>>>>> class>
>>>>> </filter>
>>>>>
>>>>>
>>>>>
>>>>> On 22 June 2014 04:12, Glen Mazza <gl...@gmail.com> wrote:
>>>>>
>>>>> OK, team, second attempt, fixing the problems Greg noted from the last
>>>>>
>>>>>> vote. I tested the Tomcat version again and it seemed to work all
>>>>>> well,
>>>>>> validation also working this time.
>>>>>>
>>>>>> Here is my +1. Vote for another 72 hours.
>>>>>>
>>>>>> Binaries: people.apache.org/~gmazza/roller/rc2
>>>>>>
>>>>>> SVN tag: https://svn.apache.org/repos/asf/roller/tags/roller_5.0.4-
>>>>>> rc2/
>>>>>>
>>>>>> Regards,
>>>>>> Glen
>>>>>>
>>>>>>
>>>>>> -------- Original Message --------
>>>>>>
>>>>>> On 6/7/2014 11:44 PM, Glen Mazza wrote:
>>>>>>> Hi Team,
>>>>>>>
>>>>>>>> This is a vote to release Roller 5.0.4, it upgrades its Struts
>>>>>>>> library
>>>>>>>> to 2.3.16.3 to fix some important issues with it; also, some of the
>>>>>>>> LDAP configuration was fixed based on comments from a user.
>>>>>>>>
>>>>>>>> Binaries are here: http://people.apache.org/~gmazza/roller/
>>>>>>>>
>>>>>>>> I tested the Tomcat version, it looks good.
>>>>>>>>
>>>>>>>> Here's my +1. Voting will be for 72 hours.
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>> Glen
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
Re: [VOTE] Release Roller 5.0.4 - rc2
Posted by Greg Huber <gr...@gmail.com>.
I doubt the struts filter change has anything to do with JPA enhance
exceptions. These look like the enhancer has not compiled the classes. Is
this version running the old version of JPA?
On 27 June 2014 17:01, Glen Mazza <gl...@gmail.com> wrote:
> Hi Greg, I tried the changes below to web.xml but Roller 5.0.5-SNAPSHOT
> wouldn't work soon after startup (after the tables were created) -- OpenJPA
> complaints popped up immediately on the screen and in roller.log:
>
> FATAL 2014-06-27 11:28:36,226 JPAPropertiesManagerImpl:initialize -
> Failed to initialize runtime configuration properties.Please check that the
> database has been upgraded!
> <openjpa-2.0.1-r422266:989424 nonfatal user error> org.apache.openjpa.persistence.ArgumentException:
> This configuration disallows runtime optimization, but the following listed
> types were not enhanced at build time or at class load time with a
> javaagent: "
> org.apache.roller.weblogger.pojos.TaskLock
> org.apache.roller.weblogger.pojos.OAuthConsumerRecord
> org.apache.roller.weblogger.pojos.WeblogReferrer
> org.apache.roller.weblogger.pojos.MediaFile
> org.apache.roller.weblogger.pojos.WeblogBookmarkFolder
> ....
> org.apache.roller.weblogger.pojos.WeblogHitCount".
> at org.apache.openjpa.enhance.ManagedClassSubclasser.
> prepareUnenhancedClasses(ManagedClassSubclasser.java:116)
> at org.apache.openjpa.kernel.AbstractBrokerFactory.
> loadPersistentTypes(AbstractBrokerFactory.java:317)
> at org.apache.openjpa.kernel.AbstractBrokerFactory.initializeBroker(
> AbstractBrokerFactory.java:241)
> at org.apache.openjpa.kernel.AbstractBrokerFactory.newBroker(
> AbstractBrokerFactory.java:215)
> at org.apache.openjpa.kernel.DelegatingBrokerFactory.newBroker(
> DelegatingBrokerFactory.java:156)
> at org.apache.openjpa.persistence.EntityManagerFactoryImpl.
> createEntityManager(EntityManagerFactoryImpl.java:227)
> at org.apache.openjpa.persistence.EntityManagerFactoryImpl.
> createEntityManager(EntityManagerFactoryImpl.java:154)
> at org.apache.openjpa.persistence.EntityManagerFactoryImpl.
> createEntityManager(EntityManagerFactoryImpl.java:60)
> at org.apache.roller.weblogger.business.jpa.JPAPersistenceStrategy.
> getThreadLocalEntityManager(JPAPersistenceStrategy.java:238)
> at org.apache.roller.weblogger.business.jpa.JPAPersistenceStrategy.
> getEntityManager(JPAPersistenceStrategy.java:225)
> at org.apache.roller.weblogger.business.jpa.JPAPersistenceStrategy.
> getNamedQuery(JPAPersistenceStrategy.java:258)
>
> I'm letting 5.0.x go (I didn't commit those changes), although you're of
> course welcome to research the matter further if you wish.
>
> Regards,
> Glen
>
> On 06/24/2014 03:01 AM, Greg Huber wrote:
>
>> Depreciated here would mean not supported, hence the warning messages, on
>> this version of struts.
>>
>>
>> On 23 June 2014 13:51, Glen Mazza <gl...@gmail.com> wrote:
>>
>> Deprecation is OK, I'll see if I can take care of that if we have a
>>> future
>>> 5.0.5, I'm also a bit concerned about making a change that might break
>>> parts of 5.0.x, and hence would need massive coding to fix (lots of
>>> libraries in 5.0.x are old). I want to be coding and releasing 5.1, and
>>> 5.0.x keeps me from that.
>>>
>>> Glen
>>>
>>> On 06/23/2014 03:32 AM, Greg Huber wrote:
>>>
>>> +1
>>>> Struts upgrade works ok.
>>>>
>>>>
>>>> ####
>>>>
>>>> Might be worth having a check on the templates on
>>>> /resources/template/roller/*.ftl. (copy from trunk)
>>>>
>>>> ####
>>>>
>>>> There are some warnings on the web.xml entries for struts:
>>>>
>>>> FilterDispatcher <<< is deprecated! Please use the new filters!
>>>>
>>>>> ie change from:
>>>>>>
>>>>> <filter>
>>>> <filter-name>struts2</filter-name>
>>>>
>>>> <filter-class>org.apache.struts2.dispatcher.FilterDispatcher</filter-
>>>> class>
>>>> </filter>
>>>>
>>>> to:
>>>>
>>>> <filter>
>>>> <filter-name>struts2</filter-name>
>>>>
>>>> <filter-class>org.apache.struts2.dispatcher.ng.filter.
>>>> StrutsPrepareAndExecuteFilter</filter-class>
>>>> </filter>
>>>>
>>>> ActionContextCleanUp <<< is deprecated! Please use the new filters!
>>>>
>>>>> remove:
>>>>>>
>>>>> <filter>
>>>> <filter-name>struts2-cleanup</filter-name>
>>>>
>>>> <filter-class>org.apache.struts2.dispatcher.
>>>> ActionContextCleanUp</filter-
>>>> class>
>>>> </filter>
>>>>
>>>>
>>>>
>>>> On 22 June 2014 04:12, Glen Mazza <gl...@gmail.com> wrote:
>>>>
>>>> OK, team, second attempt, fixing the problems Greg noted from the last
>>>>
>>>>> vote. I tested the Tomcat version again and it seemed to work all
>>>>> well,
>>>>> validation also working this time.
>>>>>
>>>>> Here is my +1. Vote for another 72 hours.
>>>>>
>>>>> Binaries: people.apache.org/~gmazza/roller/rc2
>>>>>
>>>>> SVN tag: https://svn.apache.org/repos/asf/roller/tags/roller_5.0.4-
>>>>> rc2/
>>>>>
>>>>> Regards,
>>>>> Glen
>>>>>
>>>>>
>>>>> -------- Original Message --------
>>>>>
>>>>> On 6/7/2014 11:44 PM, Glen Mazza wrote:
>>>>>>
>>>>>> Hi Team,
>>>>>>
>>>>>>> This is a vote to release Roller 5.0.4, it upgrades its Struts
>>>>>>> library
>>>>>>> to 2.3.16.3 to fix some important issues with it; also, some of the
>>>>>>> LDAP configuration was fixed based on comments from a user.
>>>>>>>
>>>>>>> Binaries are here: http://people.apache.org/~gmazza/roller/
>>>>>>>
>>>>>>> I tested the Tomcat version, it looks good.
>>>>>>>
>>>>>>> Here's my +1. Voting will be for 72 hours.
>>>>>>>
>>>>>>> Regards,
>>>>>>> Glen
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>
Re: [VOTE] Release Roller 5.0.4 - rc2
Posted by Glen Mazza <gl...@gmail.com>.
Hi Greg, I tried the changes below to web.xml but Roller 5.0.5-SNAPSHOT
wouldn't work soon after startup (after the tables were created) --
OpenJPA complaints popped up immediately on the screen and in roller.log:
FATAL 2014-06-27 11:28:36,226 JPAPropertiesManagerImpl:initialize -
Failed to initialize runtime configuration properties.Please check that
the database has been upgraded!
<openjpa-2.0.1-r422266:989424 nonfatal user error>
org.apache.openjpa.persistence.ArgumentException: This configuration
disallows runtime optimization, but the following listed types were not
enhanced at build time or at class load time with a javaagent: "
org.apache.roller.weblogger.pojos.TaskLock
org.apache.roller.weblogger.pojos.OAuthConsumerRecord
org.apache.roller.weblogger.pojos.WeblogReferrer
org.apache.roller.weblogger.pojos.MediaFile
org.apache.roller.weblogger.pojos.WeblogBookmarkFolder
....
org.apache.roller.weblogger.pojos.WeblogHitCount".
at
org.apache.openjpa.enhance.ManagedClassSubclasser.prepareUnenhancedClasses(ManagedClassSubclasser.java:116)
at
org.apache.openjpa.kernel.AbstractBrokerFactory.loadPersistentTypes(AbstractBrokerFactory.java:317)
at
org.apache.openjpa.kernel.AbstractBrokerFactory.initializeBroker(AbstractBrokerFactory.java:241)
at
org.apache.openjpa.kernel.AbstractBrokerFactory.newBroker(AbstractBrokerFactory.java:215)
at
org.apache.openjpa.kernel.DelegatingBrokerFactory.newBroker(DelegatingBrokerFactory.java:156)
at
org.apache.openjpa.persistence.EntityManagerFactoryImpl.createEntityManager(EntityManagerFactoryImpl.java:227)
at
org.apache.openjpa.persistence.EntityManagerFactoryImpl.createEntityManager(EntityManagerFactoryImpl.java:154)
at
org.apache.openjpa.persistence.EntityManagerFactoryImpl.createEntityManager(EntityManagerFactoryImpl.java:60)
at
org.apache.roller.weblogger.business.jpa.JPAPersistenceStrategy.getThreadLocalEntityManager(JPAPersistenceStrategy.java:238)
at
org.apache.roller.weblogger.business.jpa.JPAPersistenceStrategy.getEntityManager(JPAPersistenceStrategy.java:225)
at
org.apache.roller.weblogger.business.jpa.JPAPersistenceStrategy.getNamedQuery(JPAPersistenceStrategy.java:258)
I'm letting 5.0.x go (I didn't commit those changes), although you're of
course welcome to research the matter further if you wish.
Regards,
Glen
On 06/24/2014 03:01 AM, Greg Huber wrote:
> Depreciated here would mean not supported, hence the warning messages, on
> this version of struts.
>
>
> On 23 June 2014 13:51, Glen Mazza <gl...@gmail.com> wrote:
>
>> Deprecation is OK, I'll see if I can take care of that if we have a future
>> 5.0.5, I'm also a bit concerned about making a change that might break
>> parts of 5.0.x, and hence would need massive coding to fix (lots of
>> libraries in 5.0.x are old). I want to be coding and releasing 5.1, and
>> 5.0.x keeps me from that.
>>
>> Glen
>>
>> On 06/23/2014 03:32 AM, Greg Huber wrote:
>>
>>> +1
>>> Struts upgrade works ok.
>>>
>>>
>>> ####
>>>
>>> Might be worth having a check on the templates on
>>> /resources/template/roller/*.ftl. (copy from trunk)
>>>
>>> ####
>>>
>>> There are some warnings on the web.xml entries for struts:
>>>
>>> FilterDispatcher <<< is deprecated! Please use the new filters!
>>>>> ie change from:
>>> <filter>
>>> <filter-name>struts2</filter-name>
>>>
>>> <filter-class>org.apache.struts2.dispatcher.FilterDispatcher</filter-
>>> class>
>>> </filter>
>>>
>>> to:
>>>
>>> <filter>
>>> <filter-name>struts2</filter-name>
>>>
>>> <filter-class>org.apache.struts2.dispatcher.ng.filter.
>>> StrutsPrepareAndExecuteFilter</filter-class>
>>> </filter>
>>>
>>> ActionContextCleanUp <<< is deprecated! Please use the new filters!
>>>>> remove:
>>> <filter>
>>> <filter-name>struts2-cleanup</filter-name>
>>>
>>> <filter-class>org.apache.struts2.dispatcher.ActionContextCleanUp</filter-
>>> class>
>>> </filter>
>>>
>>>
>>>
>>> On 22 June 2014 04:12, Glen Mazza <gl...@gmail.com> wrote:
>>>
>>> OK, team, second attempt, fixing the problems Greg noted from the last
>>>> vote. I tested the Tomcat version again and it seemed to work all well,
>>>> validation also working this time.
>>>>
>>>> Here is my +1. Vote for another 72 hours.
>>>>
>>>> Binaries: people.apache.org/~gmazza/roller/rc2
>>>>
>>>> SVN tag: https://svn.apache.org/repos/asf/roller/tags/roller_5.0.4-rc2/
>>>>
>>>> Regards,
>>>> Glen
>>>>
>>>>
>>>> -------- Original Message --------
>>>>
>>>>> On 6/7/2014 11:44 PM, Glen Mazza wrote:
>>>>>
>>>>> Hi Team,
>>>>>> This is a vote to release Roller 5.0.4, it upgrades its Struts library
>>>>>> to 2.3.16.3 to fix some important issues with it; also, some of the
>>>>>> LDAP configuration was fixed based on comments from a user.
>>>>>>
>>>>>> Binaries are here: http://people.apache.org/~gmazza/roller/
>>>>>>
>>>>>> I tested the Tomcat version, it looks good.
>>>>>>
>>>>>> Here's my +1. Voting will be for 72 hours.
>>>>>>
>>>>>> Regards,
>>>>>> Glen
>>>>>>
>>>>>>
>>>>>>
Re: [VOTE] Release Roller 5.0.4 - rc2
Posted by Greg Huber <gr...@gmail.com>.
Depreciated here would mean not supported, hence the warning messages, on
this version of struts.
On 23 June 2014 13:51, Glen Mazza <gl...@gmail.com> wrote:
> Deprecation is OK, I'll see if I can take care of that if we have a future
> 5.0.5, I'm also a bit concerned about making a change that might break
> parts of 5.0.x, and hence would need massive coding to fix (lots of
> libraries in 5.0.x are old). I want to be coding and releasing 5.1, and
> 5.0.x keeps me from that.
>
> Glen
>
> On 06/23/2014 03:32 AM, Greg Huber wrote:
>
>> +1
>> Struts upgrade works ok.
>>
>>
>> ####
>>
>> Might be worth having a check on the templates on
>> /resources/template/roller/*.ftl. (copy from trunk)
>>
>> ####
>>
>> There are some warnings on the web.xml entries for struts:
>>
>> FilterDispatcher <<< is deprecated! Please use the new filters!
>>>>>
>>>> ie change from:
>>
>> <filter>
>> <filter-name>struts2</filter-name>
>>
>> <filter-class>org.apache.struts2.dispatcher.FilterDispatcher</filter-
>> class>
>> </filter>
>>
>> to:
>>
>> <filter>
>> <filter-name>struts2</filter-name>
>>
>> <filter-class>org.apache.struts2.dispatcher.ng.filter.
>> StrutsPrepareAndExecuteFilter</filter-class>
>> </filter>
>>
>> ActionContextCleanUp <<< is deprecated! Please use the new filters!
>>>>>
>>>> remove:
>>
>> <filter>
>> <filter-name>struts2-cleanup</filter-name>
>>
>> <filter-class>org.apache.struts2.dispatcher.ActionContextCleanUp</filter-
>> class>
>> </filter>
>>
>>
>>
>> On 22 June 2014 04:12, Glen Mazza <gl...@gmail.com> wrote:
>>
>> OK, team, second attempt, fixing the problems Greg noted from the last
>>> vote. I tested the Tomcat version again and it seemed to work all well,
>>> validation also working this time.
>>>
>>> Here is my +1. Vote for another 72 hours.
>>>
>>> Binaries: people.apache.org/~gmazza/roller/rc2
>>>
>>> SVN tag: https://svn.apache.org/repos/asf/roller/tags/roller_5.0.4-rc2/
>>>
>>> Regards,
>>> Glen
>>>
>>>
>>> -------- Original Message --------
>>>
>>>> On 6/7/2014 11:44 PM, Glen Mazza wrote:
>>>>
>>>> Hi Team,
>>>>>
>>>>> This is a vote to release Roller 5.0.4, it upgrades its Struts library
>>>>> to 2.3.16.3 to fix some important issues with it; also, some of the
>>>>> LDAP configuration was fixed based on comments from a user.
>>>>>
>>>>> Binaries are here: http://people.apache.org/~gmazza/roller/
>>>>>
>>>>> I tested the Tomcat version, it looks good.
>>>>>
>>>>> Here's my +1. Voting will be for 72 hours.
>>>>>
>>>>> Regards,
>>>>> Glen
>>>>>
>>>>>
>>>>>
>
Re: [VOTE] Release Roller 5.0.4 - rc2
Posted by Glen Mazza <gl...@gmail.com>.
Deprecation is OK, I'll see if I can take care of that if we have a
future 5.0.5, I'm also a bit concerned about making a change that might
break parts of 5.0.x, and hence would need massive coding to fix (lots
of libraries in 5.0.x are old). I want to be coding and releasing 5.1,
and 5.0.x keeps me from that.
Glen
On 06/23/2014 03:32 AM, Greg Huber wrote:
> +1
> Struts upgrade works ok.
>
>
> ####
>
> Might be worth having a check on the templates on
> /resources/template/roller/*.ftl. (copy from trunk)
>
> ####
>
> There are some warnings on the web.xml entries for struts:
>
>>>> FilterDispatcher <<< is deprecated! Please use the new filters!
> ie change from:
>
> <filter>
> <filter-name>struts2</filter-name>
>
> <filter-class>org.apache.struts2.dispatcher.FilterDispatcher</filter-class>
> </filter>
>
> to:
>
> <filter>
> <filter-name>struts2</filter-name>
>
> <filter-class>org.apache.struts2.dispatcher.ng.filter.StrutsPrepareAndExecuteFilter</filter-class>
> </filter>
>
>>>> ActionContextCleanUp <<< is deprecated! Please use the new filters!
> remove:
>
> <filter>
> <filter-name>struts2-cleanup</filter-name>
>
> <filter-class>org.apache.struts2.dispatcher.ActionContextCleanUp</filter-class>
> </filter>
>
>
>
> On 22 June 2014 04:12, Glen Mazza <gl...@gmail.com> wrote:
>
>> OK, team, second attempt, fixing the problems Greg noted from the last
>> vote. I tested the Tomcat version again and it seemed to work all well,
>> validation also working this time.
>>
>> Here is my +1. Vote for another 72 hours.
>>
>> Binaries: people.apache.org/~gmazza/roller/rc2
>>
>> SVN tag: https://svn.apache.org/repos/asf/roller/tags/roller_5.0.4-rc2/
>>
>> Regards,
>> Glen
>>
>>
>> -------- Original Message --------
>>> On 6/7/2014 11:44 PM, Glen Mazza wrote:
>>>
>>>> Hi Team,
>>>>
>>>> This is a vote to release Roller 5.0.4, it upgrades its Struts library
>>>> to 2.3.16.3 to fix some important issues with it; also, some of the
>>>> LDAP configuration was fixed based on comments from a user.
>>>>
>>>> Binaries are here: http://people.apache.org/~gmazza/roller/
>>>>
>>>> I tested the Tomcat version, it looks good.
>>>>
>>>> Here's my +1. Voting will be for 72 hours.
>>>>
>>>> Regards,
>>>> Glen
>>>>
>>>>
Slight Delay w/5.0.4... (Re: [PASSED][VOTE] Release Roller 5.0.4
- rc2)
Posted by Glen Mazza <gl...@gmail.com>.
Sent an email to Dave this morning, some file folder permissions in the
Roller dist folder need changing before I can move the 5.0.4 stuff over.
Cheers,
Glen
On 06/25/2014 06:22 PM, Glen Mazza wrote:
> OK, 72 hours are up and we have three binding +1's: Dave, Greg, and
> myself, so we now have a 5.0.4. I'll promote the artifacts and update
> the website, blog, etc., either today or tomorrow.
>
> Greg had some earlier suggestions on changing some of the Struts
> web.xml filters in the 5.0.x branch, after I release and relabel that
> branch 5.0.5-SNAPSHOT, I'll briefly look into that as well.
>
> Regards,
> Glen
>
> On 6/23/2014 2:38 PM, Dave wrote:
>> Hi Glen,
>>
>> I was able to import the new KEYS file and verify the signature so I
>> am...
>>
>> +1 for release of 5.0.4
>>
>> Thanks for your work on this!
>>
>> - Dave
>>
>>
>>
>> On Mon, Jun 23, 2014 at 11:15 AM, Glen Mazza <gl...@gmail.com>
>> wrote:
>>
>>> Oops, OK, I just uploaded my key and tested with the below commands,
>>> the
>>> verification is working on my side. Dave, could you confirm, and if
>>> all
>>> OK, change your -1 vote? No rush, we have to wait another 48 hours
>>> before
>>> the vote closes anyway.
>>>
>>> In the meantime, I'll update our Wiki release page on how to upload
>>> keys
>>> to that MIT server.
>>>
>>> Thanks,
>>> Glen
>>>
>>>
>>>
>>> On 06/23/2014 07:57 AM, Dave wrote:
>>>
>>>> -1 because key(s) cannot be verified
>>>>
>>>> Verifying one of the new 5.0.4 signatures:
>>>>
>>>> $ gpg --verify roller-weblogger-5.0.4-for-tomcat.tar.gz.asc
>>>> gpg: Signature made Sat Jun 21 22:26:16 2014 EDT using RSA key ID
>>>> 1DC0E8AD
>>>> gpg: Can't check signature: public key not found
>>>>
>>>> Verifying one of the released 5.0.3 signatures:
>>>>
>>>> $ gpg --verify roller-weblogger-5.0.3-for-tomcat.tar.gz.asc
>>>> gpg: Signature made Sat Jan 4 14:41:37 2014 EST using DSA key ID
>>>> 17AA5B25
>>>> gpg: Good signature from "David Johnson <sn...@apache.org>"
>>>>
>>>> This may because you have not uploaded your key to a public key store,
>>>> e.g.
>>>> http://pgpkeys.mit.edu
>>>>
>>>> Thank,
>>>> - Dave
>>>>
>>>>
>>>>
>>>> On Mon, Jun 23, 2014 at 3:32 AM, Greg Huber <gr...@gmail.com>
>>>> wrote:
>>>>
>>>> +1
>>>>> Struts upgrade works ok.
>>>>>
>>>>>
>>>>> ####
>>>>>
>>>>> Might be worth having a check on the templates on
>>>>> /resources/template/roller/*.ftl. (copy from trunk)
>>>>>
>>>>> ####
>>>>>
>>>>> There are some warnings on the web.xml entries for struts:
>>>>>
>>>>> FilterDispatcher <<< is deprecated! Please use the new filters!
>>>>>>> ie change from:
>>>>> <filter>
>>>>> <filter-name>struts2</filter-name>
>>>>>
>>>>> <filter-class>org.apache.struts2.dispatcher.FilterDispatcher</filter-
>>>>> class>
>>>>> </filter>
>>>>>
>>>>> to:
>>>>>
>>>>> <filter>
>>>>> <filter-name>struts2</filter-name>
>>>>>
>>>>>
>>>>> <filter-class>org.apache.struts2.dispatcher.ng.filter.
>>>>> StrutsPrepareAndExecuteFilter</filter-class>
>>>>> </filter>
>>>>>
>>>>> ActionContextCleanUp <<< is deprecated! Please use the new filters!
>>>>>>> remove:
>>>>> <filter>
>>>>> <filter-name>struts2-cleanup</filter-name>
>>>>>
>>>>>
>>>>> <filter-class>org.apache.struts2.dispatcher.
>>>>> ActionContextCleanUp</filter-class>
>>>>> </filter>
>>>>>
>>>>>
>>>>>
>>>>> On 22 June 2014 04:12, Glen Mazza <gl...@gmail.com> wrote:
>>>>>
>>>>> OK, team, second attempt, fixing the problems Greg noted from
>>>>> the last
>>>>>> vote. I tested the Tomcat version again and it seemed to work
>>>>>> all well,
>>>>>> validation also working this time.
>>>>>>
>>>>>> Here is my +1. Vote for another 72 hours.
>>>>>>
>>>>>> Binaries: people.apache.org/~gmazza/roller/rc2
>>>>>>
>>>>>> SVN tag:
>>>>>> https://svn.apache.org/repos/asf/roller/tags/roller_5.0.4-rc2/
>>>>>>
>>>>>> Regards,
>>>>>> Glen
>>>>>>
>>>>>>
>>>>>> -------- Original Message --------
>>>>>>
>>>>>>> On 6/7/2014 11:44 PM, Glen Mazza wrote:
>>>>>>>
>>>>>>> Hi Team,
>>>>>>>> This is a vote to release Roller 5.0.4, it upgrades its Struts
>>>>>>>> library
>>>>>>>> to 2.3.16.3 to fix some important issues with it; also, some of
>>>>>>>> the
>>>>>>>> LDAP configuration was fixed based on comments from a user.
>>>>>>>>
>>>>>>>> Binaries are here: http://people.apache.org/~gmazza/roller/
>>>>>>>>
>>>>>>>> I tested the Tomcat version, it looks good.
>>>>>>>>
>>>>>>>> Here's my +1. Voting will be for 72 hours.
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>> Glen
>>>>>>>>
>>>>>>>>
>>>>>>>>
>
[PASSED][VOTE] Release Roller 5.0.4 - rc2
Posted by Glen Mazza <gl...@gmail.com>.
OK, 72 hours are up and we have three binding +1's: Dave, Greg, and
myself, so we now have a 5.0.4. I'll promote the artifacts and update
the website, blog, etc., either today or tomorrow.
Greg had some earlier suggestions on changing some of the Struts web.xml
filters in the 5.0.x branch, after I release and relabel that branch
5.0.5-SNAPSHOT, I'll briefly look into that as well.
Regards,
Glen
On 6/23/2014 2:38 PM, Dave wrote:
> Hi Glen,
>
> I was able to import the new KEYS file and verify the signature so I am...
>
> +1 for release of 5.0.4
>
> Thanks for your work on this!
>
> - Dave
>
>
>
> On Mon, Jun 23, 2014 at 11:15 AM, Glen Mazza <gl...@gmail.com> wrote:
>
>> Oops, OK, I just uploaded my key and tested with the below commands, the
>> verification is working on my side. Dave, could you confirm, and if all
>> OK, change your -1 vote? No rush, we have to wait another 48 hours before
>> the vote closes anyway.
>>
>> In the meantime, I'll update our Wiki release page on how to upload keys
>> to that MIT server.
>>
>> Thanks,
>> Glen
>>
>>
>>
>> On 06/23/2014 07:57 AM, Dave wrote:
>>
>>> -1 because key(s) cannot be verified
>>>
>>> Verifying one of the new 5.0.4 signatures:
>>>
>>> $ gpg --verify roller-weblogger-5.0.4-for-tomcat.tar.gz.asc
>>> gpg: Signature made Sat Jun 21 22:26:16 2014 EDT using RSA key ID
>>> 1DC0E8AD
>>> gpg: Can't check signature: public key not found
>>>
>>> Verifying one of the released 5.0.3 signatures:
>>>
>>> $ gpg --verify roller-weblogger-5.0.3-for-tomcat.tar.gz.asc
>>> gpg: Signature made Sat Jan 4 14:41:37 2014 EST using DSA key ID
>>> 17AA5B25
>>> gpg: Good signature from "David Johnson <sn...@apache.org>"
>>>
>>> This may because you have not uploaded your key to a public key store,
>>> e.g.
>>> http://pgpkeys.mit.edu
>>>
>>> Thank,
>>> - Dave
>>>
>>>
>>>
>>> On Mon, Jun 23, 2014 at 3:32 AM, Greg Huber <gr...@gmail.com> wrote:
>>>
>>> +1
>>>> Struts upgrade works ok.
>>>>
>>>>
>>>> ####
>>>>
>>>> Might be worth having a check on the templates on
>>>> /resources/template/roller/*.ftl. (copy from trunk)
>>>>
>>>> ####
>>>>
>>>> There are some warnings on the web.xml entries for struts:
>>>>
>>>> FilterDispatcher <<< is deprecated! Please use the new filters!
>>>>>> ie change from:
>>>> <filter>
>>>> <filter-name>struts2</filter-name>
>>>>
>>>> <filter-class>org.apache.struts2.dispatcher.FilterDispatcher</filter-
>>>> class>
>>>> </filter>
>>>>
>>>> to:
>>>>
>>>> <filter>
>>>> <filter-name>struts2</filter-name>
>>>>
>>>>
>>>> <filter-class>org.apache.struts2.dispatcher.ng.filter.
>>>> StrutsPrepareAndExecuteFilter</filter-class>
>>>> </filter>
>>>>
>>>> ActionContextCleanUp <<< is deprecated! Please use the new filters!
>>>>>> remove:
>>>> <filter>
>>>> <filter-name>struts2-cleanup</filter-name>
>>>>
>>>>
>>>> <filter-class>org.apache.struts2.dispatcher.
>>>> ActionContextCleanUp</filter-class>
>>>> </filter>
>>>>
>>>>
>>>>
>>>> On 22 June 2014 04:12, Glen Mazza <gl...@gmail.com> wrote:
>>>>
>>>> OK, team, second attempt, fixing the problems Greg noted from the last
>>>>> vote. I tested the Tomcat version again and it seemed to work all well,
>>>>> validation also working this time.
>>>>>
>>>>> Here is my +1. Vote for another 72 hours.
>>>>>
>>>>> Binaries: people.apache.org/~gmazza/roller/rc2
>>>>>
>>>>> SVN tag: https://svn.apache.org/repos/asf/roller/tags/roller_5.0.4-rc2/
>>>>>
>>>>> Regards,
>>>>> Glen
>>>>>
>>>>>
>>>>> -------- Original Message --------
>>>>>
>>>>>> On 6/7/2014 11:44 PM, Glen Mazza wrote:
>>>>>>
>>>>>> Hi Team,
>>>>>>> This is a vote to release Roller 5.0.4, it upgrades its Struts library
>>>>>>> to 2.3.16.3 to fix some important issues with it; also, some of the
>>>>>>> LDAP configuration was fixed based on comments from a user.
>>>>>>>
>>>>>>> Binaries are here: http://people.apache.org/~gmazza/roller/
>>>>>>>
>>>>>>> I tested the Tomcat version, it looks good.
>>>>>>>
>>>>>>> Here's my +1. Voting will be for 72 hours.
>>>>>>>
>>>>>>> Regards,
>>>>>>> Glen
>>>>>>>
>>>>>>>
>>>>>>>
Re: [VOTE] Release Roller 5.0.4 - rc2
Posted by Dave <sn...@gmail.com>.
Hi Glen,
I was able to import the new KEYS file and verify the signature so I am...
+1 for release of 5.0.4
Thanks for your work on this!
- Dave
On Mon, Jun 23, 2014 at 11:15 AM, Glen Mazza <gl...@gmail.com> wrote:
> Oops, OK, I just uploaded my key and tested with the below commands, the
> verification is working on my side. Dave, could you confirm, and if all
> OK, change your -1 vote? No rush, we have to wait another 48 hours before
> the vote closes anyway.
>
> In the meantime, I'll update our Wiki release page on how to upload keys
> to that MIT server.
>
> Thanks,
> Glen
>
>
>
> On 06/23/2014 07:57 AM, Dave wrote:
>
>> -1 because key(s) cannot be verified
>>
>> Verifying one of the new 5.0.4 signatures:
>>
>> $ gpg --verify roller-weblogger-5.0.4-for-tomcat.tar.gz.asc
>> gpg: Signature made Sat Jun 21 22:26:16 2014 EDT using RSA key ID
>> 1DC0E8AD
>> gpg: Can't check signature: public key not found
>>
>> Verifying one of the released 5.0.3 signatures:
>>
>> $ gpg --verify roller-weblogger-5.0.3-for-tomcat.tar.gz.asc
>> gpg: Signature made Sat Jan 4 14:41:37 2014 EST using DSA key ID
>> 17AA5B25
>> gpg: Good signature from "David Johnson <sn...@apache.org>"
>>
>> This may because you have not uploaded your key to a public key store,
>> e.g.
>> http://pgpkeys.mit.edu
>>
>> Thank,
>> - Dave
>>
>>
>>
>> On Mon, Jun 23, 2014 at 3:32 AM, Greg Huber <gr...@gmail.com> wrote:
>>
>> +1
>>> Struts upgrade works ok.
>>>
>>>
>>> ####
>>>
>>> Might be worth having a check on the templates on
>>> /resources/template/roller/*.ftl. (copy from trunk)
>>>
>>> ####
>>>
>>> There are some warnings on the web.xml entries for struts:
>>>
>>> FilterDispatcher <<< is deprecated! Please use the new filters!
>>>>>>
>>>>> ie change from:
>>>
>>> <filter>
>>> <filter-name>struts2</filter-name>
>>>
>>> <filter-class>org.apache.struts2.dispatcher.FilterDispatcher</filter-
>>> class>
>>> </filter>
>>>
>>> to:
>>>
>>> <filter>
>>> <filter-name>struts2</filter-name>
>>>
>>>
>>> <filter-class>org.apache.struts2.dispatcher.ng.filter.
>>> StrutsPrepareAndExecuteFilter</filter-class>
>>> </filter>
>>>
>>> ActionContextCleanUp <<< is deprecated! Please use the new filters!
>>>>>>
>>>>> remove:
>>>
>>> <filter>
>>> <filter-name>struts2-cleanup</filter-name>
>>>
>>>
>>> <filter-class>org.apache.struts2.dispatcher.
>>> ActionContextCleanUp</filter-class>
>>> </filter>
>>>
>>>
>>>
>>> On 22 June 2014 04:12, Glen Mazza <gl...@gmail.com> wrote:
>>>
>>> OK, team, second attempt, fixing the problems Greg noted from the last
>>>> vote. I tested the Tomcat version again and it seemed to work all well,
>>>> validation also working this time.
>>>>
>>>> Here is my +1. Vote for another 72 hours.
>>>>
>>>> Binaries: people.apache.org/~gmazza/roller/rc2
>>>>
>>>> SVN tag: https://svn.apache.org/repos/asf/roller/tags/roller_5.0.4-rc2/
>>>>
>>>> Regards,
>>>> Glen
>>>>
>>>>
>>>> -------- Original Message --------
>>>>
>>>>> On 6/7/2014 11:44 PM, Glen Mazza wrote:
>>>>>
>>>>> Hi Team,
>>>>>>
>>>>>> This is a vote to release Roller 5.0.4, it upgrades its Struts library
>>>>>> to 2.3.16.3 to fix some important issues with it; also, some of the
>>>>>> LDAP configuration was fixed based on comments from a user.
>>>>>>
>>>>>> Binaries are here: http://people.apache.org/~gmazza/roller/
>>>>>>
>>>>>> I tested the Tomcat version, it looks good.
>>>>>>
>>>>>> Here's my +1. Voting will be for 72 hours.
>>>>>>
>>>>>> Regards,
>>>>>> Glen
>>>>>>
>>>>>>
>>>>>>
>
Re: [VOTE] Release Roller 5.0.4 - rc2
Posted by Glen Mazza <gl...@gmail.com>.
Oops, OK, I just uploaded my key and tested with the below commands, the
verification is working on my side. Dave, could you confirm, and if all
OK, change your -1 vote? No rush, we have to wait another 48 hours
before the vote closes anyway.
In the meantime, I'll update our Wiki release page on how to upload keys
to that MIT server.
Thanks,
Glen
On 06/23/2014 07:57 AM, Dave wrote:
> -1 because key(s) cannot be verified
>
> Verifying one of the new 5.0.4 signatures:
>
> $ gpg --verify roller-weblogger-5.0.4-for-tomcat.tar.gz.asc
> gpg: Signature made Sat Jun 21 22:26:16 2014 EDT using RSA key ID
> 1DC0E8AD
> gpg: Can't check signature: public key not found
>
> Verifying one of the released 5.0.3 signatures:
>
> $ gpg --verify roller-weblogger-5.0.3-for-tomcat.tar.gz.asc
> gpg: Signature made Sat Jan 4 14:41:37 2014 EST using DSA key ID
> 17AA5B25
> gpg: Good signature from "David Johnson <sn...@apache.org>"
>
> This may because you have not uploaded your key to a public key store, e.g.
> http://pgpkeys.mit.edu
>
> Thank,
> - Dave
>
>
>
> On Mon, Jun 23, 2014 at 3:32 AM, Greg Huber <gr...@gmail.com> wrote:
>
>> +1
>> Struts upgrade works ok.
>>
>>
>> ####
>>
>> Might be worth having a check on the templates on
>> /resources/template/roller/*.ftl. (copy from trunk)
>>
>> ####
>>
>> There are some warnings on the web.xml entries for struts:
>>
>>>>> FilterDispatcher <<< is deprecated! Please use the new filters!
>> ie change from:
>>
>> <filter>
>> <filter-name>struts2</filter-name>
>>
>> <filter-class>org.apache.struts2.dispatcher.FilterDispatcher</filter-class>
>> </filter>
>>
>> to:
>>
>> <filter>
>> <filter-name>struts2</filter-name>
>>
>>
>> <filter-class>org.apache.struts2.dispatcher.ng.filter.StrutsPrepareAndExecuteFilter</filter-class>
>> </filter>
>>
>>>>> ActionContextCleanUp <<< is deprecated! Please use the new filters!
>> remove:
>>
>> <filter>
>> <filter-name>struts2-cleanup</filter-name>
>>
>>
>> <filter-class>org.apache.struts2.dispatcher.ActionContextCleanUp</filter-class>
>> </filter>
>>
>>
>>
>> On 22 June 2014 04:12, Glen Mazza <gl...@gmail.com> wrote:
>>
>>> OK, team, second attempt, fixing the problems Greg noted from the last
>>> vote. I tested the Tomcat version again and it seemed to work all well,
>>> validation also working this time.
>>>
>>> Here is my +1. Vote for another 72 hours.
>>>
>>> Binaries: people.apache.org/~gmazza/roller/rc2
>>>
>>> SVN tag: https://svn.apache.org/repos/asf/roller/tags/roller_5.0.4-rc2/
>>>
>>> Regards,
>>> Glen
>>>
>>>
>>> -------- Original Message --------
>>>> On 6/7/2014 11:44 PM, Glen Mazza wrote:
>>>>
>>>>> Hi Team,
>>>>>
>>>>> This is a vote to release Roller 5.0.4, it upgrades its Struts library
>>>>> to 2.3.16.3 to fix some important issues with it; also, some of the
>>>>> LDAP configuration was fixed based on comments from a user.
>>>>>
>>>>> Binaries are here: http://people.apache.org/~gmazza/roller/
>>>>>
>>>>> I tested the Tomcat version, it looks good.
>>>>>
>>>>> Here's my +1. Voting will be for 72 hours.
>>>>>
>>>>> Regards,
>>>>> Glen
>>>>>
>>>>>
Re: [VOTE] Release Roller 5.0.4 - rc2
Posted by Glen Mazza <gl...@gmail.com>.
Hi Anil, I guess I should add my key to this file:
http://svn.apache.org/viewvc/roller/KEYS?view=log , and then upload that
file to the location you give below. I'll get that done now.
Thanks,
Glen
On 06/23/2014 09:58 AM, Anil Gangolli wrote:
>
> Glen's key should be added to http://www.apache.org/dist/roller/KEYS
> and Dave should import from there. [People shouldn't be trusting a
> public key store without separately verifying the key fingerprint or a
> trust chain.] See also the instructions on
> http://roller.apache.org/downloads/downloads.html for what the
> downloading user is expected to do.
>
> --a.
>
> On 6/23/14, 4:57 AM, Dave wrote:
>> -1 because key(s) cannot be verified
>>
>> Verifying one of the new 5.0.4 signatures:
>>
>> $ gpg --verify roller-weblogger-5.0.4-for-tomcat.tar.gz.asc
>> gpg: Signature made Sat Jun 21 22:26:16 2014 EDT using RSA key ID
>> 1DC0E8AD
>> gpg: Can't check signature: public key not found
>>
>> Verifying one of the released 5.0.3 signatures:
>>
>> $ gpg --verify roller-weblogger-5.0.3-for-tomcat.tar.gz.asc
>> gpg: Signature made Sat Jan 4 14:41:37 2014 EST using DSA key ID
>> 17AA5B25
>> gpg: Good signature from "David Johnson <sn...@apache.org>"
>>
>> This may because you have not uploaded your key to a public key
>> store, e.g.
>> http://pgpkeys.mit.edu
>>
>> Thank,
>> - Dave
>>
>>
>>
>> On Mon, Jun 23, 2014 at 3:32 AM, Greg Huber <gr...@gmail.com> wrote:
>>
>>> +1
>>> Struts upgrade works ok.
>>>
>>>
>>> ####
>>>
>>> Might be worth having a check on the templates on
>>> /resources/template/roller/*.ftl. (copy from trunk)
>>>
>>> ####
>>>
>>> There are some warnings on the web.xml entries for struts:
>>>
>>>>>> FilterDispatcher <<< is deprecated! Please use the new filters!
>>> ie change from:
>>>
>>> <filter>
>>> <filter-name>struts2</filter-name>
>>>
>>> <filter-class>org.apache.struts2.dispatcher.FilterDispatcher</filter-class>
>>>
>>> </filter>
>>>
>>> to:
>>>
>>> <filter>
>>> <filter-name>struts2</filter-name>
>>>
>>>
>>> <filter-class>org.apache.struts2.dispatcher.ng.filter.StrutsPrepareAndExecuteFilter</filter-class>
>>>
>>> </filter>
>>>
>>>>>> ActionContextCleanUp <<< is deprecated! Please use the new filters!
>>> remove:
>>>
>>> <filter>
>>> <filter-name>struts2-cleanup</filter-name>
>>>
>>>
>>> <filter-class>org.apache.struts2.dispatcher.ActionContextCleanUp</filter-class>
>>>
>>> </filter>
>>>
>>>
>>>
>>> On 22 June 2014 04:12, Glen Mazza <gl...@gmail.com> wrote:
>>>
>>>> OK, team, second attempt, fixing the problems Greg noted from the last
>>>> vote. I tested the Tomcat version again and it seemed to work all
>>>> well,
>>>> validation also working this time.
>>>>
>>>> Here is my +1. Vote for another 72 hours.
>>>>
>>>> Binaries: people.apache.org/~gmazza/roller/rc2
>>>>
>>>> SVN tag:
>>>> https://svn.apache.org/repos/asf/roller/tags/roller_5.0.4-rc2/
>>>>
>>>> Regards,
>>>> Glen
>>>>
>>>>
>>>> -------- Original Message --------
>>>>> On 6/7/2014 11:44 PM, Glen Mazza wrote:
>>>>>
>>>>>> Hi Team,
>>>>>>
>>>>>> This is a vote to release Roller 5.0.4, it upgrades its Struts
>>>>>> library
>>>>>> to 2.3.16.3 to fix some important issues with it; also, some of the
>>>>>> LDAP configuration was fixed based on comments from a user.
>>>>>>
>>>>>> Binaries are here: http://people.apache.org/~gmazza/roller/
>>>>>>
>>>>>> I tested the Tomcat version, it looks good.
>>>>>>
>>>>>> Here's my +1. Voting will be for 72 hours.
>>>>>>
>>>>>> Regards,
>>>>>> Glen
>>>>>>
>>>>>>
>
Re: [VOTE] Release Roller 5.0.4 - rc2
Posted by Dave <sn...@gmail.com>.
-1 because key(s) cannot be verified
Verifying one of the new 5.0.4 signatures:
$ gpg --verify roller-weblogger-5.0.4-for-tomcat.tar.gz.asc
gpg: Signature made Sat Jun 21 22:26:16 2014 EDT using RSA key ID
1DC0E8AD
gpg: Can't check signature: public key not found
Verifying one of the released 5.0.3 signatures:
$ gpg --verify roller-weblogger-5.0.3-for-tomcat.tar.gz.asc
gpg: Signature made Sat Jan 4 14:41:37 2014 EST using DSA key ID
17AA5B25
gpg: Good signature from "David Johnson <sn...@apache.org>"
This may because you have not uploaded your key to a public key store, e.g.
http://pgpkeys.mit.edu
Thank,
- Dave
On Mon, Jun 23, 2014 at 3:32 AM, Greg Huber <gr...@gmail.com> wrote:
> +1
> Struts upgrade works ok.
>
>
> ####
>
> Might be worth having a check on the templates on
> /resources/template/roller/*.ftl. (copy from trunk)
>
> ####
>
> There are some warnings on the web.xml entries for struts:
>
> >>> FilterDispatcher <<< is deprecated! Please use the new filters!
>
> ie change from:
>
> <filter>
> <filter-name>struts2</filter-name>
>
> <filter-class>org.apache.struts2.dispatcher.FilterDispatcher</filter-class>
> </filter>
>
> to:
>
> <filter>
> <filter-name>struts2</filter-name>
>
>
> <filter-class>org.apache.struts2.dispatcher.ng.filter.StrutsPrepareAndExecuteFilter</filter-class>
> </filter>
>
> >>> ActionContextCleanUp <<< is deprecated! Please use the new filters!
>
> remove:
>
> <filter>
> <filter-name>struts2-cleanup</filter-name>
>
>
> <filter-class>org.apache.struts2.dispatcher.ActionContextCleanUp</filter-class>
> </filter>
>
>
>
> On 22 June 2014 04:12, Glen Mazza <gl...@gmail.com> wrote:
>
> > OK, team, second attempt, fixing the problems Greg noted from the last
> > vote. I tested the Tomcat version again and it seemed to work all well,
> > validation also working this time.
> >
> > Here is my +1. Vote for another 72 hours.
> >
> > Binaries: people.apache.org/~gmazza/roller/rc2
> >
> > SVN tag: https://svn.apache.org/repos/asf/roller/tags/roller_5.0.4-rc2/
> >
> > Regards,
> > Glen
> >
> >
> > -------- Original Message --------
> >>
> >> On 6/7/2014 11:44 PM, Glen Mazza wrote:
> >>
> >>> Hi Team,
> >>>
> >>> This is a vote to release Roller 5.0.4, it upgrades its Struts library
> >>> to 2.3.16.3 to fix some important issues with it; also, some of the
> >>> LDAP configuration was fixed based on comments from a user.
> >>>
> >>> Binaries are here: http://people.apache.org/~gmazza/roller/
> >>>
> >>> I tested the Tomcat version, it looks good.
> >>>
> >>> Here's my +1. Voting will be for 72 hours.
> >>>
> >>> Regards,
> >>> Glen
> >>>
> >>>
> >>
> >
>
Re: [VOTE] Release Roller 5.0.4 - rc2
Posted by Greg Huber <gr...@gmail.com>.
+1
Struts upgrade works ok.
####
Might be worth having a check on the templates on
/resources/template/roller/*.ftl. (copy from trunk)
####
There are some warnings on the web.xml entries for struts:
>>> FilterDispatcher <<< is deprecated! Please use the new filters!
ie change from:
<filter>
<filter-name>struts2</filter-name>
<filter-class>org.apache.struts2.dispatcher.FilterDispatcher</filter-class>
</filter>
to:
<filter>
<filter-name>struts2</filter-name>
<filter-class>org.apache.struts2.dispatcher.ng.filter.StrutsPrepareAndExecuteFilter</filter-class>
</filter>
>>> ActionContextCleanUp <<< is deprecated! Please use the new filters!
remove:
<filter>
<filter-name>struts2-cleanup</filter-name>
<filter-class>org.apache.struts2.dispatcher.ActionContextCleanUp</filter-class>
</filter>
On 22 June 2014 04:12, Glen Mazza <gl...@gmail.com> wrote:
> OK, team, second attempt, fixing the problems Greg noted from the last
> vote. I tested the Tomcat version again and it seemed to work all well,
> validation also working this time.
>
> Here is my +1. Vote for another 72 hours.
>
> Binaries: people.apache.org/~gmazza/roller/rc2
>
> SVN tag: https://svn.apache.org/repos/asf/roller/tags/roller_5.0.4-rc2/
>
> Regards,
> Glen
>
>
> -------- Original Message --------
>>
>> On 6/7/2014 11:44 PM, Glen Mazza wrote:
>>
>>> Hi Team,
>>>
>>> This is a vote to release Roller 5.0.4, it upgrades its Struts library
>>> to 2.3.16.3 to fix some important issues with it; also, some of the
>>> LDAP configuration was fixed based on comments from a user.
>>>
>>> Binaries are here: http://people.apache.org/~gmazza/roller/
>>>
>>> I tested the Tomcat version, it looks good.
>>>
>>> Here's my +1. Voting will be for 72 hours.
>>>
>>> Regards,
>>> Glen
>>>
>>>
>>
>
[VOTE] Release Roller 5.0.4 - rc2
Posted by Glen Mazza <gl...@gmail.com>.
OK, team, second attempt, fixing the problems Greg noted from the last
vote. I tested the Tomcat version again and it seemed to work all well,
validation also working this time.
Here is my +1. Vote for another 72 hours.
Binaries: people.apache.org/~gmazza/roller/rc2
SVN tag: https://svn.apache.org/repos/asf/roller/tags/roller_5.0.4-rc2/
Regards,
Glen
> -------- Original Message --------
>
> On 6/7/2014 11:44 PM, Glen Mazza wrote:
>> Hi Team,
>>
>> This is a vote to release Roller 5.0.4, it upgrades its Struts library
>> to 2.3.16.3 to fix some important issues with it; also, some of the
>> LDAP configuration was fixed based on comments from a user.
>>
>> Binaries are here: http://people.apache.org/~gmazza/roller/
>>
>> I tested the Tomcat version, it looks good.
>>
>> Here's my +1. Voting will be for 72 hours.
>>
>> Regards,
>> Glen
>>
>
Re: [WITHDRAWN][BOO HISS]Re: [VOTE] Release Roller 5.0.4
Posted by Glen Mazza <gl...@gmail.com>.
Thanks very much for all this info, I'll try to get to it soon, no later
than this weekend.
Glen
On 6/10/2014 3:12 AM, Greg Huber wrote:
> struts.xml :
>
> from:
> <interceptor-ref name="params">
> <param name="excludeParams">dojo\..*</param>
> </interceptor-ref>
>
> to:
> <interceptor-ref name="params">
> <param name="excludeParams">^action:.*,^method:.*</param>
> </interceptor-ref>
>
> As we have our own default struts xml, its best to copy the settings from
> the default xml supplied with the latest version of struts. The parameter
> interceptor was the reason for the security upgrade.
>
>
> On 10 June 2014 01:56, Glen Mazza <gl...@gmail.com> wrote:
>
>> OK, I'll get the validation files fixed, re-release and hold another vote.
>> Unless it's an immediate, clear fix I'll skip the deprecated warnings you
>> mention at the bottom, it's a given that 5.0.4 has old libraries but the
>> solution is to get 5.1 out rather than spend time trying to make 5.0.4 the
>> same as 5.1.
>>
>> BTW, between the ## signs below you mention struts.xml -- I'm unsure what
>> you're trying to say there--do I need to update the struts.xml as well?
>>
>> Thanks,
>> Glen
>>
>> On 6/9/2014 10:23 AM, Greg Huber wrote:
>>
>>> Glen,
>>>
>>> The validator does not work,
>>>
>>> ERROR 2014-06-09 13:55:47,277 CommonsLogger:error - Caught exception while
>>> loading file
>>> org/apache/roller/weblogger/ui/struts2/editor/EntryAdd-validation.xml
>>> http://www.opensymphony.com/xwork/xwork-validator-1.0.2.dtd - Class:
>>> sun.net.www.protocol.http.HttpURLConnection
>>>
>>> the dtd on the struts validation.xml files needs to be changed to match
>>> the
>>> one on the version of struts uses ie
>>>
>>> <!DOCTYPE validators PUBLIC
>>> "-//Apache Struts//XWork Validator 1.0.3//EN"
>>> "http://struts.apache.org/dtds/xwork-validator-1.0.3.dtd">
>>>
>>> ##
>>>
>>> struts.xml :
>>>
>>> <interceptor-ref name="params">
>>> <param name="excludeParams">dojo\..*</param>
>>> </interceptor-ref>
>>>
>>> <interceptor-ref name="params">
>>> <param
>>> name="excludeParams">^action:.*,^method:.*</param>
>>> </interceptor-ref>
>>>
>>> ####
>>>
>>> There are some other warnings also, but not that important,
>>>
>>> ActionContextCleanUp <<< is deprecated! Please use the new filters!
>>>>>> FilterDispatcher <<< is deprecated! Please use the new filters!
>>>>>>
>>> On 9 June 2014 11:37, Glen Mazza <gl...@gmail.com> wrote:
>>>
>>> OK, apparently voting is done on DEV and not the private list (not that
>>>> the latter emailing system appeared to be accepting my emails anyway...)
>>>> Vote is below and I'm resetting the 72 hour clock to zero.
>>>>
>>>> Thanks,
>>>> Glen
>>>>
>>>>
>>>> -------- Original Message --------
>>>>
>>>> On 6/7/2014 11:44 PM, Glen Mazza wrote:
>>>>
>>>> Hi Team,
>>>>> This is a vote to release Roller 5.0.4, it upgrades its Struts library
>>>>> to 2.3.16.3 to fix some important issues with it; also, some of the
>>>>> LDAP configuration was fixed based on comments from a user.
>>>>>
>>>>> Binaries are here: http://people.apache.org/~gmazza/roller/
>>>>>
>>>>> I tested the Tomcat version, it looks good.
>>>>>
>>>>> Here's my +1. Voting will be for 72 hours.
>>>>>
>>>>> Regards,
>>>>> Glen
>>>>>
>>>>>
>>>>>
Re: [WITHDRAWN][BOO HISS]Re: [VOTE] Release Roller 5.0.4
Posted by Greg Huber <gr...@gmail.com>.
struts.xml :
from:
<interceptor-ref name="params">
<param name="excludeParams">dojo\..*</param>
</interceptor-ref>
to:
<interceptor-ref name="params">
<param name="excludeParams">^action:.*,^method:.*</param>
</interceptor-ref>
As we have our own default struts xml, its best to copy the settings from
the default xml supplied with the latest version of struts. The parameter
interceptor was the reason for the security upgrade.
On 10 June 2014 01:56, Glen Mazza <gl...@gmail.com> wrote:
> OK, I'll get the validation files fixed, re-release and hold another vote.
> Unless it's an immediate, clear fix I'll skip the deprecated warnings you
> mention at the bottom, it's a given that 5.0.4 has old libraries but the
> solution is to get 5.1 out rather than spend time trying to make 5.0.4 the
> same as 5.1.
>
> BTW, between the ## signs below you mention struts.xml -- I'm unsure what
> you're trying to say there--do I need to update the struts.xml as well?
>
> Thanks,
> Glen
>
> On 6/9/2014 10:23 AM, Greg Huber wrote:
>
>> Glen,
>>
>> The validator does not work,
>>
>> ERROR 2014-06-09 13:55:47,277 CommonsLogger:error - Caught exception while
>> loading file
>> org/apache/roller/weblogger/ui/struts2/editor/EntryAdd-validation.xml
>> http://www.opensymphony.com/xwork/xwork-validator-1.0.2.dtd - Class:
>> sun.net.www.protocol.http.HttpURLConnection
>>
>> the dtd on the struts validation.xml files needs to be changed to match
>> the
>> one on the version of struts uses ie
>>
>> <!DOCTYPE validators PUBLIC
>> "-//Apache Struts//XWork Validator 1.0.3//EN"
>> "http://struts.apache.org/dtds/xwork-validator-1.0.3.dtd">
>>
>> ##
>>
>> struts.xml :
>>
>> <interceptor-ref name="params">
>> <param name="excludeParams">dojo\..*</param>
>> </interceptor-ref>
>>
>> <interceptor-ref name="params">
>> <param
>> name="excludeParams">^action:.*,^method:.*</param>
>> </interceptor-ref>
>>
>> ####
>>
>> There are some other warnings also, but not that important,
>>
>> ActionContextCleanUp <<< is deprecated! Please use the new filters!
>>>>> FilterDispatcher <<< is deprecated! Please use the new filters!
>>>>>
>>>>
>>
>> On 9 June 2014 11:37, Glen Mazza <gl...@gmail.com> wrote:
>>
>> OK, apparently voting is done on DEV and not the private list (not that
>>> the latter emailing system appeared to be accepting my emails anyway...)
>>> Vote is below and I'm resetting the 72 hour clock to zero.
>>>
>>> Thanks,
>>> Glen
>>>
>>>
>>> -------- Original Message --------
>>>
>>> On 6/7/2014 11:44 PM, Glen Mazza wrote:
>>>
>>> Hi Team,
>>>>
>>>> This is a vote to release Roller 5.0.4, it upgrades its Struts library
>>>> to 2.3.16.3 to fix some important issues with it; also, some of the
>>>> LDAP configuration was fixed based on comments from a user.
>>>>
>>>> Binaries are here: http://people.apache.org/~gmazza/roller/
>>>>
>>>> I tested the Tomcat version, it looks good.
>>>>
>>>> Here's my +1. Voting will be for 72 hours.
>>>>
>>>> Regards,
>>>> Glen
>>>>
>>>>
>>>>
>
[WITHDRAWN][BOO HISS]Re: [VOTE] Release Roller 5.0.4
Posted by Glen Mazza <gl...@gmail.com>.
OK, I'll get the validation files fixed, re-release and hold another
vote. Unless it's an immediate, clear fix I'll skip the deprecated
warnings you mention at the bottom, it's a given that 5.0.4 has old
libraries but the solution is to get 5.1 out rather than spend time
trying to make 5.0.4 the same as 5.1.
BTW, between the ## signs below you mention struts.xml -- I'm unsure
what you're trying to say there--do I need to update the struts.xml as well?
Thanks,
Glen
On 6/9/2014 10:23 AM, Greg Huber wrote:
> Glen,
>
> The validator does not work,
>
> ERROR 2014-06-09 13:55:47,277 CommonsLogger:error - Caught exception while
> loading file
> org/apache/roller/weblogger/ui/struts2/editor/EntryAdd-validation.xml
> http://www.opensymphony.com/xwork/xwork-validator-1.0.2.dtd - Class:
> sun.net.www.protocol.http.HttpURLConnection
>
> the dtd on the struts validation.xml files needs to be changed to match the
> one on the version of struts uses ie
>
> <!DOCTYPE validators PUBLIC
> "-//Apache Struts//XWork Validator 1.0.3//EN"
> "http://struts.apache.org/dtds/xwork-validator-1.0.3.dtd">
>
> ##
>
> struts.xml :
>
> <interceptor-ref name="params">
> <param name="excludeParams">dojo\..*</param>
> </interceptor-ref>
>
> <interceptor-ref name="params">
> <param
> name="excludeParams">^action:.*,^method:.*</param>
> </interceptor-ref>
>
> ####
>
> There are some other warnings also, but not that important,
>
>>>> ActionContextCleanUp <<< is deprecated! Please use the new filters!
>>>> FilterDispatcher <<< is deprecated! Please use the new filters!
>
>
> On 9 June 2014 11:37, Glen Mazza <gl...@gmail.com> wrote:
>
>> OK, apparently voting is done on DEV and not the private list (not that
>> the latter emailing system appeared to be accepting my emails anyway...)
>> Vote is below and I'm resetting the 72 hour clock to zero.
>>
>> Thanks,
>> Glen
>>
>>
>> -------- Original Message --------
>>
>> On 6/7/2014 11:44 PM, Glen Mazza wrote:
>>
>>> Hi Team,
>>>
>>> This is a vote to release Roller 5.0.4, it upgrades its Struts library
>>> to 2.3.16.3 to fix some important issues with it; also, some of the
>>> LDAP configuration was fixed based on comments from a user.
>>>
>>> Binaries are here: http://people.apache.org/~gmazza/roller/
>>>
>>> I tested the Tomcat version, it looks good.
>>>
>>> Here's my +1. Voting will be for 72 hours.
>>>
>>> Regards,
>>> Glen
>>>
>>>
Re: [VOTE] Release Roller 5.0.4
Posted by Greg Huber <gr...@gmail.com>.
Glen,
The validator does not work,
ERROR 2014-06-09 13:55:47,277 CommonsLogger:error - Caught exception while
loading file
org/apache/roller/weblogger/ui/struts2/editor/EntryAdd-validation.xml
http://www.opensymphony.com/xwork/xwork-validator-1.0.2.dtd - Class:
sun.net.www.protocol.http.HttpURLConnection
the dtd on the struts validation.xml files needs to be changed to match the
one on the version of struts uses ie
<!DOCTYPE validators PUBLIC
"-//Apache Struts//XWork Validator 1.0.3//EN"
"http://struts.apache.org/dtds/xwork-validator-1.0.3.dtd">
##
struts.xml :
<interceptor-ref name="params">
<param name="excludeParams">dojo\..*</param>
</interceptor-ref>
<interceptor-ref name="params">
<param
name="excludeParams">^action:.*,^method:.*</param>
</interceptor-ref>
####
There are some other warnings also, but not that important,
>>> ActionContextCleanUp <<< is deprecated! Please use the new filters!
>>> FilterDispatcher <<< is deprecated! Please use the new filters!
On 9 June 2014 11:37, Glen Mazza <gl...@gmail.com> wrote:
> OK, apparently voting is done on DEV and not the private list (not that
> the latter emailing system appeared to be accepting my emails anyway...)
> Vote is below and I'm resetting the 72 hour clock to zero.
>
> Thanks,
> Glen
>
>
> -------- Original Message --------
>
> On 6/7/2014 11:44 PM, Glen Mazza wrote:
>
>> Hi Team,
>>
>> This is a vote to release Roller 5.0.4, it upgrades its Struts library
>> to 2.3.16.3 to fix some important issues with it; also, some of the
>> LDAP configuration was fixed based on comments from a user.
>>
>> Binaries are here: http://people.apache.org/~gmazza/roller/
>>
>> I tested the Tomcat version, it looks good.
>>
>> Here's my +1. Voting will be for 72 hours.
>>
>> Regards,
>> Glen
>>
>>
>
Re: [VOTE] Release Roller 5.0.4
Posted by Dave <sn...@gmail.com>.
+1 for release of 5.0.4
On Mon, Jun 9, 2014 at 6:37 AM, Glen Mazza <gl...@gmail.com> wrote:
> OK, apparently voting is done on DEV and not the private list (not that
> the latter emailing system appeared to be accepting my emails anyway...)
> Vote is below and I'm resetting the 72 hour clock to zero.
>
>
> Thanks,
> Glen
>
>
> -------- Original Message --------
>
> On 6/7/2014 11:44 PM, Glen Mazza wrote:
>
>> Hi Team,
>>
>> This is a vote to release Roller 5.0.4, it upgrades its Struts library
>> to 2.3.16.3 to fix some important issues with it; also, some of the
>>
>> LDAP configuration was fixed based on comments from a user.
>>
>> Binaries are here: http://people.apache.org/~gmazza/roller/
>>
>> I tested the Tomcat version, it looks good.
>>
>> Here's my +1. Voting will be for 72 hours.
>>
>> Regards,
>> Glen
>>
>>
>