You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/30 12:05:39 UTC
[GitHub] [airflow] turbaszek opened a new pull request #8010: Add more
refactor steps for providers.google
turbaszek opened a new pull request #8010: Add more refactor steps for providers.google
URL: https://github.com/apache/airflow/pull/8010
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #8010: Add more refactor steps
for providers.google
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #8010: Add more refactor steps for providers.google
URL: https://github.com/apache/airflow/pull/8010
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8010: Add
more refactor steps for providers.google
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #8010: Add more refactor steps for providers.google
URL: https://github.com/apache/airflow/pull/8010#discussion_r400399871
##########
File path: backport_packages/setup_backport_packages.py
##########
@@ -243,10 +257,18 @@ def _remover(node: LN, capture: Capture, filename: Filename) -> None:
.modify(add_provide_context_to_python_operator)
)
+ # Remove new class
remove_class(qry, "GKEStartPodOperator")
qry.execute(write=True, silent=False, interactive=False)
+ # Add old import to GKE
+ gke_path = os.path.join(
+ dirname(__file__), "airflow", "providers", "google", "cloud", "operators", "kubernetes_engine.py"
+ )
+ with open(gke_path, "a") as f:
+ f.writelines(["", "from airflow.contrib.operators.gcp_container_operator import GKEPodOperator"])
Review comment:
Should we remove this file?
https://github.com/apache/airflow/blob/50ee275a4090063df6b91cd9162dae32f8cbc4e0/airflow/providers/google/cloud/example_dags/example_kubernetes_engine_setup.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] turbaszek commented on a change in pull request #8010:
Add more refactor steps for providers.google
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #8010: Add more refactor steps for providers.google
URL: https://github.com/apache/airflow/pull/8010#discussion_r400789401
##########
File path: backport_packages/setup_backport_packages.py
##########
@@ -243,10 +257,18 @@ def _remover(node: LN, capture: Capture, filename: Filename) -> None:
.modify(add_provide_context_to_python_operator)
)
+ # Remove new class
remove_class(qry, "GKEStartPodOperator")
qry.execute(write=True, silent=False, interactive=False)
+ # Add old import to GKE
+ gke_path = os.path.join(
+ dirname(__file__), "airflow", "providers", "google", "cloud", "operators", "kubernetes_engine.py"
+ )
+ with open(gke_path, "a") as f:
+ f.writelines(["", "from airflow.contrib.operators.gcp_container_operator import GKEPodOperator"])
Review comment:
Works out of the box 🎂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] turbaszek commented on a change in pull request #8010:
Add more refactor steps for providers.google
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #8010: Add more refactor steps for providers.google
URL: https://github.com/apache/airflow/pull/8010#discussion_r400705954
##########
File path: backport_packages/setup_backport_packages.py
##########
@@ -243,10 +257,18 @@ def _remover(node: LN, capture: Capture, filename: Filename) -> None:
.modify(add_provide_context_to_python_operator)
)
+ # Remove new class
remove_class(qry, "GKEStartPodOperator")
qry.execute(write=True, silent=False, interactive=False)
+ # Add old import to GKE
+ gke_path = os.path.join(
+ dirname(__file__), "airflow", "providers", "google", "cloud", "operators", "kubernetes_engine.py"
+ )
+ with open(gke_path, "a") as f:
+ f.writelines(["", "from airflow.contrib.operators.gcp_container_operator import GKEPodOperator"])
Review comment:
Probably yes, I will check if the test works...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services