You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@sling.apache.org by Christophe Jelger <je...@adobe.com> on 2017/01/17 10:35:17 UTC

Re: Sling Model and Request Parameters

Hi everyone,

There was a discussion back on Oct 11, 2016 about an extra injector+annotation to inject request parameters into Sling models.
I couldn’t find any JIRA issue about that, and I haven’t seen anything like that in the code so I don’t think this is currently in progress.

I just joined the mailing list and I started developing with AEM + Sling recently, but I have quite some experience with Spring and think this would be a useful annotation, especially to be able to handle form submits with sling models.

If there is still interest to have that annotation, I would be willing to take care of that: I already wrote the missing code and could already provide a diff or pull request.

Best regards,
Christophe

Re: Sling Model and Request Parameters

Posted by Christophe Jelger <je...@adobe.com>.
Hi,

I now created https://issues.apache.org/jira/browse/SLING-6478 and attached a diff with the new code.

Best regards
Christophe


On 19/01/17 09:43, "Christophe Jelger" <je...@adobe.com> wrote:

    Hi again,
    
    Thx for your answer: I understand why we don’t want to add that request parameter injector to the list of default injectors, but I haven’t yet found in the code where and how I should prevent that. Could anybody point me to the right piece of code I should check?
    
    Thanks,
    Christophe
    
    On 18/01/17 18:33, "Jason Bailey" <Ja...@sas.com> wrote:
    
        As mentioned in the original thread. I think you would just need to create a JIRA and add your patch to that.  As long as it was one of those non-default injectors I would appreciate it.
        
        
        Original thread:
        http://apache-sling.73963.n3.nabble.com/Sling-Model-and-Request-Parameters-tt4065648.html#a4065663
        
        -----Original Message-----
        From: Christophe Jelger [mailto:jelger@adobe.com] 
        Sent: Tuesday, January 17, 2017 5:35 AM
        To: users@sling.apache.org
        Subject: Re: Sling Model and Request Parameters
        
        Hi everyone,
        
        There was a discussion back on Oct 11, 2016 about an extra injector+annotation to inject request parameters into Sling models.
        I couldn’t find any JIRA issue about that, and I haven’t seen anything like that in the code so I don’t think this is currently in progress.
        
        I just joined the mailing list and I started developing with AEM + Sling recently, but I have quite some experience with Spring and think this would be a useful annotation, especially to be able to handle form submits with sling models.
        
        If there is still interest to have that annotation, I would be willing to take care of that: I already wrote the missing code and could already provide a diff or pull request.
        
        Best regards,
        Christophe

Re: Sling Model and Request Parameters

Posted by Christophe Jelger <je...@adobe.com>.
Hi again,

Thx for your answer: I understand why we don’t want to add that request parameter injector to the list of default injectors, but I haven’t yet found in the code where and how I should prevent that. Could anybody point me to the right piece of code I should check?

Thanks,
Christophe

On 18/01/17 18:33, "Jason Bailey" <Ja...@sas.com> wrote:

    As mentioned in the original thread. I think you would just need to create a JIRA and add your patch to that.  As long as it was one of those non-default injectors I would appreciate it.
    
    
    Original thread:
    http://apache-sling.73963.n3.nabble.com/Sling-Model-and-Request-Parameters-tt4065648.html#a4065663
    
    -----Original Message-----
    From: Christophe Jelger [mailto:jelger@adobe.com] 
    Sent: Tuesday, January 17, 2017 5:35 AM
    To: users@sling.apache.org
    Subject: Re: Sling Model and Request Parameters
    
    Hi everyone,
    
    There was a discussion back on Oct 11, 2016 about an extra injector+annotation to inject request parameters into Sling models.
    I couldn’t find any JIRA issue about that, and I haven’t seen anything like that in the code so I don’t think this is currently in progress.
    
    I just joined the mailing list and I started developing with AEM + Sling recently, but I have quite some experience with Spring and think this would be a useful annotation, especially to be able to handle form submits with sling models.
    
    If there is still interest to have that annotation, I would be willing to take care of that: I already wrote the missing code and could already provide a diff or pull request.
    
    Best regards,
    Christophe

RE: Sling Model and Request Parameters

Posted by Jason Bailey <Ja...@sas.com>.
As mentioned in the original thread. I think you would just need to create a JIRA and add your patch to that.  As long as it was one of those non-default injectors I would appreciate it.


Original thread:
http://apache-sling.73963.n3.nabble.com/Sling-Model-and-Request-Parameters-tt4065648.html#a4065663

-----Original Message-----
From: Christophe Jelger [mailto:jelger@adobe.com] 
Sent: Tuesday, January 17, 2017 5:35 AM
To: users@sling.apache.org
Subject: Re: Sling Model and Request Parameters

Hi everyone,

There was a discussion back on Oct 11, 2016 about an extra injector+annotation to inject request parameters into Sling models.
I couldn’t find any JIRA issue about that, and I haven’t seen anything like that in the code so I don’t think this is currently in progress.

I just joined the mailing list and I started developing with AEM + Sling recently, but I have quite some experience with Spring and think this would be a useful annotation, especially to be able to handle form submits with sling models.

If there is still interest to have that annotation, I would be willing to take care of that: I already wrote the missing code and could already provide a diff or pull request.

Best regards,
Christophe