You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/12 18:37:34 UTC
[GitHub] [incubator-superset] kkucharc opened a new pull request #11673: fix: make higher chart box resizable
kkucharc opened a new pull request #11673:
URL: https://github.com/apache/incubator-superset/pull/11673
### SUMMARY
PR with 2 parts requested in #11472 :
1. When chart is higher than other elements it is still possible to resize it.
2. Adjusted size of hovered border and markdown's edit border to match grey border of an external box.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
1. Before:

1. After:

2. Before

2. After

### TEST PLAN
1. Go to dashboard
2. Add Tab
3. Add a Markdown and any of charts inside tab
4. Resize the Markdown smaller than the chart
5. Try resize the chart
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue: #11472
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11673: fix: make higher chart box resizable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11673:
URL: https://github.com/apache/incubator-superset/pull/11673#issuecomment-726297142
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=h1) Report
> Merging [#11673](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=desc) (51ebcff) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4d41cf900d1415ef5f393e9f575c57b020720402?el=desc) (4d41cf9) will **decrease** coverage by `0.37%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11673 +/- ##
==========================================
- Coverage 62.26% 61.89% -0.38%
==========================================
Files 873 423 -450
Lines 42280 26325 -15955
Branches 3964 0 -3964
==========================================
- Hits 26326 16293 -10033
+ Misses 15774 10032 -5742
+ Partials 180 0 -180
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `61.89% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `0.00% <0.00%> (-60.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.58% <0.00%> (-5.05%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.39% <0.00%> (-1.41%)` | :arrow_down: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.14% <0.00%> (-0.35%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.98% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/kylin.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2t5bGluLnB5) | `94.11% <0.00%> (ø)` | |
| ... and [463 more](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=footer). Last update [4d41cf9...51ebcff](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11673: fix: make higher chart box resizable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11673:
URL: https://github.com/apache/incubator-superset/pull/11673#issuecomment-726297142
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=h1) Report
> Merging [#11673](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=desc) (51ebcff) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4d41cf900d1415ef5f393e9f575c57b020720402?el=desc) (4d41cf9) will **decrease** coverage by `2.82%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11673 +/- ##
==========================================
- Coverage 62.26% 59.43% -2.83%
==========================================
Files 873 829 -44
Lines 42280 40668 -1612
Branches 3964 3691 -273
==========================================
- Hits 26326 24173 -2153
- Misses 15774 16324 +550
+ Partials 180 171 -9
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.61% <ø> (?)` | |
| javascript | `?` | |
| python | `62.06% <ø> (+0.14%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/dashboard/components/DashboardBuilder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | `85.29% <ø> (+4.13%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `5.71% <0.00%> (-82.10%)` | :arrow_down: |
| [...et-frontend/src/components/ListView/ActionsBar.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQWN0aW9uc0Jhci50c3g=) | `11.11% <0.00%> (-81.20%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| ... and [372 more](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=footer). Last update [4d41cf9...51ebcff](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11673: fix: make higher chart box resizable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11673:
URL: https://github.com/apache/incubator-superset/pull/11673#issuecomment-726297142
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=h1) Report
> Merging [#11673](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=desc) (51ebcff) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4d41cf900d1415ef5f393e9f575c57b020720402?el=desc) (4d41cf9) will **decrease** coverage by `2.60%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11673 +/- ##
==========================================
- Coverage 62.26% 59.65% -2.61%
==========================================
Files 873 829 -44
Lines 42280 40668 -1612
Branches 3964 3691 -273
==========================================
- Hits 26326 24261 -2065
- Misses 15774 16244 +470
+ Partials 180 163 -17
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.23% <ø> (?)` | |
| javascript | `?` | |
| python | `62.06% <ø> (+0.14%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/dashboard/components/DashboardBuilder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | `85.29% <ø> (+4.13%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `5.71% <0.00%> (-82.10%)` | :arrow_down: |
| [...et-frontend/src/components/ListView/ActionsBar.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQWN0aW9uc0Jhci50c3g=) | `11.11% <0.00%> (-81.20%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| ... and [373 more](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=footer). Last update [4d41cf9...51ebcff](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11673: fix: make higher chart box resizable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11673:
URL: https://github.com/apache/incubator-superset/pull/11673#issuecomment-726297142
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=h1) Report
> Merging [#11673](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=desc) (51ebcff) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4d41cf900d1415ef5f393e9f575c57b020720402?el=desc) (4d41cf9) will **decrease** coverage by `0.19%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11673 +/- ##
==========================================
- Coverage 62.26% 62.06% -0.20%
==========================================
Files 873 423 -450
Lines 42280 26325 -15955
Branches 3964 0 -3964
==========================================
- Hits 26326 16339 -9987
+ Misses 15774 9986 -5788
+ Partials 180 0 -180
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.06% <ø> (+0.14%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `0.00% <0.00%> (-60.72%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.58% <0.00%> (-5.05%)` | :arrow_down: |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.39% <0.00%> (-1.41%)` | :arrow_down: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.14% <0.00%> (-0.35%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/kylin.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2t5bGluLnB5) | `94.11% <0.00%> (ø)` | |
| [...src/dashboard/util/getFilterConfigsFromFormdata.js](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckNvbmZpZ3NGcm9tRm9ybWRhdGEuanM=) | | |
| [...et-frontend/src/components/ConfirmStatusChange.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29uZmlybVN0YXR1c0NoYW5nZS50c3g=) | | |
| [...d/src/dashboard/util/getLeafComponentIdFromPath.js](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExlYWZDb21wb25lbnRJZEZyb21QYXRoLmpz) | | |
| [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | | |
| ... and [459 more](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=footer). Last update [4d41cf9...51ebcff](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11673: fix: make higher chart box resizable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11673:
URL: https://github.com/apache/incubator-superset/pull/11673#issuecomment-726297142
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=h1) Report
> Merging [#11673](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=desc) (51ebcff) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4d41cf900d1415ef5f393e9f575c57b020720402?el=desc) (4d41cf9) will **decrease** coverage by `0.40%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11673 +/- ##
==========================================
- Coverage 62.26% 61.85% -0.41%
==========================================
Files 873 423 -450
Lines 42280 26325 -15955
Branches 3964 0 -3964
==========================================
- Hits 26326 16284 -10042
+ Misses 15774 10041 -5733
+ Partials 180 0 -180
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `61.85% <ø> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `0.00% <0.00%> (-60.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.58% <0.00%> (-5.05%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.39% <0.00%> (-1.41%)` | :arrow_down: |
| ... and [467 more](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=footer). Last update [4d41cf9...51ebcff](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11673: fix: make higher chart box resizable
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11673:
URL: https://github.com/apache/incubator-superset/pull/11673#issuecomment-726297142
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=h1) Report
> Merging [#11673](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=desc) (51ebcff) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4d41cf900d1415ef5f393e9f575c57b020720402?el=desc) (4d41cf9) will **decrease** coverage by `0.40%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11673 +/- ##
==========================================
- Coverage 62.26% 61.85% -0.41%
==========================================
Files 873 423 -450
Lines 42280 26325 -15955
Branches 3964 0 -3964
==========================================
- Hits 26326 16284 -10042
+ Misses 15774 10041 -5733
+ Partials 180 0 -180
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `61.85% <ø> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `0.00% <0.00%> (-60.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.58% <0.00%> (-5.05%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.39% <0.00%> (-1.41%)` | :arrow_down: |
| ... and [467 more](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=footer). Last update [4d41cf9...51ebcff](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kkucharc commented on pull request #11673: fix: make higher chart box resizable
Posted by GitBox <gi...@apache.org>.
kkucharc commented on pull request #11673:
URL: https://github.com/apache/incubator-superset/pull/11673#issuecomment-726265473
Hi @ktmud 👋 Can you take a look at screens if it's what you meant in #11472?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud merged pull request #11673: fix: make higher chart box resizable
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #11673:
URL: https://github.com/apache/incubator-superset/pull/11673
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11673: fix: make higher chart box resizable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11673:
URL: https://github.com/apache/incubator-superset/pull/11673#issuecomment-726297142
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=h1) Report
> Merging [#11673](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=desc) (51ebcff) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4d41cf900d1415ef5f393e9f575c57b020720402?el=desc) (4d41cf9) will **decrease** coverage by `0.37%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11673 +/- ##
==========================================
- Coverage 62.26% 61.88% -0.38%
==========================================
Files 873 423 -450
Lines 42280 26325 -15955
Branches 3964 0 -3964
==========================================
- Hits 26326 16292 -10034
+ Misses 15774 10033 -5741
+ Partials 180 0 -180
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `61.88% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `0.00% <0.00%> (-60.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.58% <0.00%> (-5.05%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.39% <0.00%> (-1.41%)` | :arrow_down: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.14% <0.00%> (-0.35%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.98% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [464 more](https://codecov.io/gh/apache/incubator-superset/pull/11673/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=footer). Last update [4d41cf9...51ebcff](https://codecov.io/gh/apache/incubator-superset/pull/11673?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kkucharc edited a comment on pull request #11673: fix: make higher chart box resizable
Posted by GitBox <gi...@apache.org>.
kkucharc edited a comment on pull request #11673:
URL: https://github.com/apache/incubator-superset/pull/11673#issuecomment-726265473
Hi @ktmud 👋 Can you take a look at screens if it's what you meant in #11472?
cc: @junlincc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org