[GitHub] [ozone] prashantpogde commented on a change in pull request #2692: HDDS-5754. [Multi-Tenant] Implement GetUserInfo

[GitBox <gi...@apache.org>]

prashantpogde commented on a change in pull request #2692:
URL: https://github.com/apache/ozone/pull/2692#discussion_r718977362



##########
File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java
##########
@@ -304,8 +305,7 @@ public static boolean isReadOnly(
     case ModifyTenant:
     case DeleteTenant:
     case AssignUserToTenant:
-    case ModifyTenantUser:
-    case DeleteTenantUser:
+    case RevokeUserAccessToTenant:

Review comment:
       not related to this PR ?

##########
File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/TenantUserInfoValue.java
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+package org.apache.hadoop.ozone.om.helpers;
+
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.TenantAccessIdInfo;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.TenantUserInfo;
+
+import java.util.List;
+import java.util.Objects;
+
+/**
+ * Utility class to handle protobuf message TenantUserInfo conversion.
+ */
+public class TenantUserInfoValue {
+
+  // Usually the Kerberos principal of a user.
+  private final String userPrincipal;
+
+  // A map from accessId to tenant name.
+  private final List<TenantAccessIdInfo> accessIdInfoList;

Review comment:
       we can return a list of tuple <accessID, tenant name>.
   That would be more useful information in order to find out which accessID should one use to access a given tenant-volume. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org