You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "johnnyg (via GitHub)" <gi...@apache.org> on 2023/12/22 04:59:10 UTC
[PR] GH-39335: [C#] Support creating FlightClient with Grpc.Core.Channel [arrow]
johnnyg opened a new pull request, #39348:
URL: https://github.com/apache/arrow/pull/39348
as well as Grpc.Net.Client.GrpcChannel by changing our constructor arg to Grpc.Core.ChannelBase which both classes inherit from.
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
Changing the constructor of C#'s Flight Client to take in a ChannelBase which allows for multiple implementations of gRPC channels to be passed in.
### Are these changes tested?
Existing tests already cover the use but have also manually tested in a separate app (
### Are there any user-facing changes?
No as we're just changing the constructor to take in a parent/base class instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39335: [C#] Support creating FlightClient with Grpc.Core.Channel [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39348:
URL: https://github.com/apache/arrow/pull/39348#issuecomment-1867241439
:warning: GitHub issue #39335 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39335: [C#] Support creating FlightClient with Grpc.Core.Channel [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #39348:
URL: https://github.com/apache/arrow/pull/39348#issuecomment-1868157118
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 87971df049c09671bae8a207fe2b29704fe21e8d.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/19908388096) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39335: [C#] Support creating FlightClient with Grpc.Core.Channel [arrow]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher merged PR #39348:
URL: https://github.com/apache/arrow/pull/39348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org