You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "David Knupp (Code Review)" <ge...@cloudera.org> on 2018/09/19 20:07:59 UTC
[Impala-ASF-CR] IMPALA-7584: set.test: omit pool name in catch string
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11476
Change subject: IMPALA-7584: set.test: omit pool name in catch string
......................................................................
IMPALA-7584: set.test: omit pool name in catch string
Running this test on an actual cluster results in a failure,
since the pool name differs. Removing the name allows this
test to pass on clusters. Also tested that minicluster tests
still pass.
Change-Id: I1529c040520a1d8e7ca47960c76028b2579c8d03
---
M testdata/workloads/functional-query/queries/QueryTest/set.test
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/11476/1
--
To view, visit http://gerrit.cloudera.org:8080/11476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1529c040520a1d8e7ca47960c76028b2579c8d03
Gerrit-Change-Number: 11476
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
[Impala-ASF-CR] IMPALA-7584: set.test: omit pool name in catch string
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11476 )
Change subject: IMPALA-7584: set.test: omit pool name in catch string
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1529c040520a1d8e7ca47960c76028b2579c8d03
Gerrit-Change-Number: 11476
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Sep 2018 21:05:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7584: set.test: omit pool name in catch string
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11476 )
Change subject: IMPALA-7584: set.test: omit pool name in catch string
......................................................................
IMPALA-7584: set.test: omit pool name in catch string
Running this test on an actual cluster results in a failure,
since the pool name differs. Removing the name allows this
test to pass on clusters. Also tested that minicluster tests
still pass.
Change-Id: I1529c040520a1d8e7ca47960c76028b2579c8d03
Reviewed-on: http://gerrit.cloudera.org:8080/11476
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/set.test
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1529c040520a1d8e7ca47960c76028b2579c8d03
Gerrit-Change-Number: 11476
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7584: set.test: omit pool name in catch string
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11476 )
Change subject: IMPALA-7584: set.test: omit pool name in catch string
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/716/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1529c040520a1d8e7ca47960c76028b2579c8d03
Gerrit-Change-Number: 11476
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Sep 2018 20:44:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7584: set.test: omit pool name in catch string
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11476 )
Change subject: IMPALA-7584: set.test: omit pool name in catch string
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1529c040520a1d8e7ca47960c76028b2579c8d03
Gerrit-Change-Number: 11476
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 22:03:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7584: set.test: omit pool name in catch string
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11476 )
Change subject: IMPALA-7584: set.test: omit pool name in catch string
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3186/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1529c040520a1d8e7ca47960c76028b2579c8d03
Gerrit-Change-Number: 11476
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 18:18:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7584: set.test: omit pool name in catch string
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11476 )
Change subject: IMPALA-7584: set.test: omit pool name in catch string
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1529c040520a1d8e7ca47960c76028b2579c8d03
Gerrit-Change-Number: 11476
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 18:18:08 +0000
Gerrit-HasComments: No