You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/27 17:02:19 UTC

[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #1471: RemoveOrphanFiles: consider only path to compare and delete, avoid authority and scheme

RussellSpitzer commented on a change in pull request #1471:
URL: https://github.com/apache/iceberg/pull/1471#discussion_r512867854



##########
File path: spark3/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction3.java
##########
@@ -20,6 +20,16 @@
 package org.apache.iceberg.spark.actions;
 
 import org.apache.iceberg.actions.TestRemoveOrphanFilesAction;
+import org.junit.Ignore;
 
 public class TestRemoveOrphanFilesAction3 extends TestRemoveOrphanFilesAction {
+
+  /**
+  * Todo: Its failing for Spark3, so has to fix it in the parent class.
+  * Ignoring for now, as still Spark3 is not supported.

Review comment:
       Spark3 Is supported in OSS Iceberg, Do you mean this particular function is not supported in Spark3? If so I think we should have a more clear reason why




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org