You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/10/27 09:25:53 UTC
[GitHub] [kafka] showuon opened a new pull request #11439: [WIP] KAFKA-13406: skip assignment validation for built-in cooperativeStickyAssignor
showuon opened a new pull request #11439:
URL: https://github.com/apache/kafka/pull/11439
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11439: KAFKA-13406: skip assignment validation for built-in cooperativeStickyAssignor
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11439:
URL: https://github.com/apache/kafka/pull/11439#issuecomment-969744052
Failure is unrelated, merging to trunk. Will also need to cherrypick back to 3.1 cc @dajac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11439: [WIP] KAFKA-13406: skip assignment validation for built-in cooperativeStickyAssignor
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11439:
URL: https://github.com/apache/kafka/pull/11439#issuecomment-954321511
Well, "soon" -- I just saw the notice about feature freeze coming up, so it's not a rush exactly, but just wanted to give a heads up in case if you're like me and didn't see the 3.1 deadlines coming up because 3.0 seemed like it was only a few weeks ago 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #11439: KAFKA-13406: skip assignment validation for built-in cooperativeStickyAssignor
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11439:
URL: https://github.com/apache/kafka/pull/11439#issuecomment-970044277
@ableegoldman Approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11439: [WIP] KAFKA-13406: skip assignment validation for built-in cooperativeStickyAssignor
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11439:
URL: https://github.com/apache/kafka/pull/11439#issuecomment-954215056
@showuon something like this would be a good fix for 3.1, especially since it's quick and code freeze is coming up. I also feel it is low-risk, for one thing this validation clearly can't be trusted at the moment anyways, for another I think it's fair to trust the CooperativeStickyAssignor since we have many tests for it -- we could just move the validation check from the ConsumerCoordinator into the CooperativeStickyAssignor itself, but we essentially already do exactly that inside the `adjustAssignment` method. So I support merging this (once it's cleaned up) for 3.1 and then doing something like adding the generation to the ConsumerProtocol as you suggested for the long term fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11439: [WIP] KAFKA-13406: skip assignment validation for built-in cooperativeStickyAssignor
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11439:
URL: https://github.com/apache/kafka/pull/11439#issuecomment-954320699
Oh, I didn't notice the v3.1.0 is going to code freeze soon. I thought I can still wait for the Andrei's test. Thanks for reminding, @ableegoldman . I'll clean it up today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #11439: KAFKA-13406: skip assignment validation for built-in cooperativeStickyAssignor
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #11439:
URL: https://github.com/apache/kafka/pull/11439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11439: KAFKA-13406: skip assignment validation for built-in cooperativeStickyAssignor
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11439:
URL: https://github.com/apache/kafka/pull/11439#issuecomment-954708858
@ableegoldman , it's good to review now. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11439: KAFKA-13406: skip assignment validation for built-in cooperativeStickyAssignor
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11439:
URL: https://github.com/apache/kafka/pull/11439#issuecomment-966876485
@ableegoldman , please take a look when available. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11439: KAFKA-13406: skip assignment validation for built-in cooperativeStickyAssignor
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11439:
URL: https://github.com/apache/kafka/pull/11439#issuecomment-969761211
Merged to trunk and ported back to 3.0 and 2.8, just waiting for David's approval before cherrypicking to the 3.1 branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11439: KAFKA-13406: skip assignment validation for built-in cooperativeStickyAssignor
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11439:
URL: https://github.com/apache/kafka/pull/11439#issuecomment-970083959
Thanks! Pushed to 3.1 as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org