[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #6700: GEODE-9378: Implement ZRANGEBYSCORE

[GitBox <gi...@apache.org>]

jdeppe-pivotal commented on a change in pull request #6700:
URL: https://github.com/apache/geode/pull/6700#discussion_r671307115



##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSortedSetCommandsFunctionExecutor.java
##########
@@ -62,6 +62,13 @@ public long zcount(RedisKey key, SortedSetRangeOptions rangeOptions) {
         () -> getRedisSortedSet(key, true).zrange(min, max, withScores));
   }
 
+  @Override
+  public List<byte[]> zrangebyscore(RedisKey key, SortedSetRangeOptions rangeOptions,
+      boolean withScores) {
+    return stripedExecute(key,
+        () -> getRedisSortedSet(key, true).zrangebyscore(rangeOptions, withScores));

Review comment:
       I believe that Redis' approach is to update the stats for commands that don't update data. I would expect that `zrange` _should_ update these stats.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org