[jira] [Updated] (LUCENE-3579) DirectoryTaxonomyWriter should throw a proper exception if it was closed

["Shai Erera (Updated) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shai Erera updated LUCENE-3579:
-------------------------------

    Attachment: LUCENE-3579.patch

Patch fixes rollback() and adds a final ensureOpen() that is called from all the public API methods. In addition it adds two tests to DirTaxoWriterTest.

All tests pass. I intend to commit this shortly.
                
> DirectoryTaxonomyWriter should throw a proper exception if it was closed
> ------------------------------------------------------------------------
>
>                 Key: LUCENE-3579
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3579
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/facet
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.5, 4.0
>
>         Attachments: LUCENE-3579.patch
>
>
> DirTaxoWriter may throw random exceptions (NPE, Already Closed - depend on what API you call) after it has been closed/rollback. We should detect up front that it is already closed, and throw AlreadyClosedException.
> Also, on LUCENE-3573 Doron pointed out a problem with DTW.rollback -- it should call close() rather than refreshReader. I will fix that as well in this issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org