You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sirona.apache.org by ol...@apache.org on 2015/02/05 04:36:26 UTC

svn commit: r1657466 - in /incubator/sirona/trunk/agent/javaagent/src: main/java/org/apache/sirona/javaagent/listener/ test/java/org/apache/sirona/javaagent/listener/

Author: olamy
Date: Thu Feb  5 03:36:26 2015
New Revision: 1657466

URL: http://svn.apache.org/r1657466
Log:
unit test failure

Modified:
    incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingListener.java
    incubator/sirona/trunk/agent/javaagent/src/test/java/org/apache/sirona/javaagent/listener/AgentContextTest.java
    incubator/sirona/trunk/agent/javaagent/src/test/java/org/apache/sirona/javaagent/listener/PathTrackingListenerTest.java

Modified: incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingListener.java
URL: http://svn.apache.org/viewvc/incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingListener.java?rev=1657466&r1=1657465&r2=1657466&view=diff
==============================================================================
--- incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingListener.java (original)
+++ incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingListener.java Thu Feb  5 03:36:26 2015
@@ -118,7 +118,7 @@ import org.apache.sirona.tracking.PathTr
         {
             if ( key.charAt( j ) == '.' )
             {
-                return key.substring( j + 1, firstParenthesis );
+                return key.substring( j + 1, key.length() );
             }
             j--;
         }

Modified: incubator/sirona/trunk/agent/javaagent/src/test/java/org/apache/sirona/javaagent/listener/AgentContextTest.java
URL: http://svn.apache.org/viewvc/incubator/sirona/trunk/agent/javaagent/src/test/java/org/apache/sirona/javaagent/listener/AgentContextTest.java?rev=1657466&r1=1657465&r2=1657466&view=diff
==============================================================================
--- incubator/sirona/trunk/agent/javaagent/src/test/java/org/apache/sirona/javaagent/listener/AgentContextTest.java (original)
+++ incubator/sirona/trunk/agent/javaagent/src/test/java/org/apache/sirona/javaagent/listener/AgentContextTest.java Thu Feb  5 03:36:26 2015
@@ -68,17 +68,17 @@ public class AgentContextTest
                              PathTrackingListener.extractClassName( "org.App.foo()" ) );
 
         //org.apache.test.sirona.javaagent.App.pub(java.lang.String)
-        Assert.assertEquals( "pub", //
+        Assert.assertEquals( "pub(java.lang.String)", //
                              PathTrackingListener.extractMethodName(
                                  "org.apache.test.sirona.javaagent.App.pub(java.lang.String)" ) );
 
-        Assert.assertEquals( "foo", //
+        Assert.assertEquals( "foo()", //
                              PathTrackingListener.extractMethodName( "org.apache.test.sirona.javaagent.App.foo()" ) );
 
-        Assert.assertEquals( "foo", //
+        Assert.assertEquals( "foo()", //
                              PathTrackingListener.extractMethodName( "App.foo()" ) );
 
-        Assert.assertEquals( "foo", //
+        Assert.assertEquals( "foo()", //
                              PathTrackingListener.extractMethodName( "org.App.foo()" ) );
     }
 }

Modified: incubator/sirona/trunk/agent/javaagent/src/test/java/org/apache/sirona/javaagent/listener/PathTrackingListenerTest.java
URL: http://svn.apache.org/viewvc/incubator/sirona/trunk/agent/javaagent/src/test/java/org/apache/sirona/javaagent/listener/PathTrackingListenerTest.java?rev=1657466&r1=1657465&r2=1657466&view=diff
==============================================================================
--- incubator/sirona/trunk/agent/javaagent/src/test/java/org/apache/sirona/javaagent/listener/PathTrackingListenerTest.java (original)
+++ incubator/sirona/trunk/agent/javaagent/src/test/java/org/apache/sirona/javaagent/listener/PathTrackingListenerTest.java Thu Feb  5 03:36:26 2015
@@ -97,7 +97,7 @@ public class PathTrackingListenerTest
 
         entry = entries.get( 2 );
 
-        Assert.assertEquals( "pub()", entry.getMethodName() );
+        Assert.assertEquals( "pub(java.lang.String,java.util.List)", entry.getMethodName() );
 
         Assert.assertEquals( "org.apache.test.sirona.javaagent.App", entry.getClassName() );