[GitHub] [incubator-seatunnel] BenJFan opened a new pull request, #1720: [Improve] [Core] Extract the CommandArgs implement class field

[GitBox <gi...@apache.org>]

BenJFan opened a new pull request, #1720:
URL: https://github.com/apache/incubator-seatunnel/pull/1720

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   Extract the CommandArgs implement class field, common args shouldn't write twice in code.
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #1720: [Improve] [Core] Extract the CommandArgs implement class field

[GitBox <gi...@apache.org>]

ruanwenjun commented on code in PR #1720:
URL: https://github.com/apache/incubator-seatunnel/pull/1720#discussion_r854780540


##########
seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/command/CommandArgs.java:
##########
@@ -20,10 +20,69 @@
 import org.apache.seatunnel.common.config.DeployMode;
 import org.apache.seatunnel.config.EngineType;
 
-public interface CommandArgs {
+import com.beust.jcommander.Parameter;
 
-    EngineType getEngineType();
+import java.util.Collections;
+import java.util.List;
 
-    DeployMode getDeployMode();
+public abstract class CommandArgs {

Review Comment:
   ```suggestion
   public abstract class AbstractCommandArgs {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ruanwenjun merged pull request #1720: [Improve] [Core] Extract the CommandArgs implement class field

[GitBox <gi...@apache.org>]

ruanwenjun merged PR #1720:
URL: https://github.com/apache/incubator-seatunnel/pull/1720


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org