You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/01/02 03:55:45 UTC

[GitHub] [trafficcontrol] zrhoffman opened a new pull request #4250: Support upgrading or removing Traffic Ops when systemd does not work

zrhoffman opened a new pull request #4250: Support upgrading or removing Traffic Ops when systemd does not work
URL: https://github.com/apache/trafficcontrol/pull/4250
 
 
   <!--
   ************ STOP!! ************
   If this Pull Request is intended to fix a security vulnerability, DO NOT submit it! Instead, contact
   the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
   -->
   ## What does this PR (Pull Request) do?
   <!-- Explain the changes you made here. If this fixes an Issue, identify it by
   replacing the text in the checkbox item with the Issue number e.g.
   
   - [x] This PR fixes #9001 OR is not related to any Issue
   
   ^ This will automatically close Issue number 9001 when the Pull Request is
   merged (The '#' is important).
   
   Be sure you check the box properly, see the "The following criteria are ALL
   met by this PR" section for details.
   -->
   
   - [x] This PR fixes #4249 (and unblocks #4247) <!-- You can check for an issue here: https://github.com/apache/trafficcontrol/issues -->
   
   ## Which Traffic Control components are affected by this PR?
   <!-- Please delete all components from this list that are NOT affected by this
   Pull Request. Also, feel free to add the name of a tool or script that is
   affected but not on the list.
   
   Additionally, if this Pull Request does NOT affect documentation, please
   explain why documentation is not required. -->
   
   - CDN in a Box
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   <!-- Please include here ALL the steps necessary to test your Pull Request. If
   it includes tests (and most should), outline here the steps needed to run the
   tests. If not, lay out the manual testing procedure and please explain why
   tests are unnecessary for this Pull Request. -->
   For upgrading Traffic Ops:
   1. Build Traffic Ops
   1. Copy the RPM into a `centos:7` docker container
   1. `yum -y install <the RPM>`
   1. `yum -y remove <the RPM>`
   1. `echo $?` # If this is `0`, then it was upgraded successfully.
   
   For removing Traffic Ops:
   1. Build Traffic Ops
   1. Copy the RPM into a `centos:7` docker container
   1. `yum -y install <the RPM>`
   1. `yum -y remove <the RPM>`
   1. `echo $?` # If this is `0`, then it was removed successfully.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   <!-- If this PR fixes a bug, please list here all of the affected versions - to
   the best of your knowledge. It's also pretty helpful to include a commit hash
   of where 'master' is at the time this PR is opened (if it affects master),
   because what 'master' means will change over time. For example, if this PR
   fixes a bug that's present in master (at commit hash '2697ebac'), in v3.0.0,
   and in the current 3.0.1 Release candidate (e.g. RC1), then this list would
   look like:
   
   - master (2697ebac)
   - 3.0.0
   - 3.0.1 (RC1)
   
   If you don't know what other versions might have this bug, AND don't know how
   to find the commit hash of 'master', then feel free to leave this section
   blank (or, preferably, delete it entirely).
    -->
   - master (95a6280911)
   - 3.1.0
   - 4.0.0 (RC0)
   
   ## The following criteria are ALL met by this PR
   <!-- Check the boxes to signify that the associated statement is true. To
   "check a box", replace the space inside of the square brackets with an 'x'.
   e.g.
   
   - [ x] <- Wrong
   - [x ] <- Wrong
   - [] <- Wrong
   - [*] <- Wrong
   - [x] <- Correct!
   
   -->
   
   - [x] I have explained why tests in this PR are unnecessary
   - [x] I have explained why documentation in this PR is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   ## Additional Information
   Because the documentation does not reference this bug, the fix has no documentation to update.
   
   I am not aware of any RPM tests in the project. If we want to explore this, [`t_functional`](https://github.com/CentOS/sig-core-t_functional/tree/master/tests/p_busybox) provides an example of how CentOS tests its RPMs.
   <!-- If you would like to include any additional information on the PR for
   potential reviewers please put it here.
   
   Some examples of this would be:
   
   - Before and after screenshots/gifs of the Traffic Portal if it is affected
   - Links to other dependent Pull Requests
   - References to relevant context (e.g. new/updates to dependent libraries,
   mailing list records, blueprints)
   
   Feel free to leave this section blank (or, preferably, delete it entirely).
   -->
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4250: Support upgrading or removing Traffic Ops when systemd does not work

Posted by GitBox <gi...@apache.org>.
rob05c commented on a change in pull request #4250: Support upgrading or removing Traffic Ops when systemd does not work
URL: https://github.com/apache/trafficcontrol/pull/4250#discussion_r362370925
 
 

 ##########
 File path: traffic_ops/build/traffic_ops.spec
 ##########
 @@ -131,7 +131,7 @@ Built: %(date) by %{getenv: USER}
 
     # upgrade
     if [ "$1" == "2" ]; then
-	systemctl stop traffic_ops
+        systemctl stop traffic_ops || true # Don't exit with an error if we are in an unprivileged Docker container and can't use systemctl
 
 Review comment:
   >What do you think about skipping that attempt to stop the service if systemd itself does not seem operational?
   
   That sounds like a good idea to me. Would you object to adding a tiny bit more logic, to log a warning if that happens? E.g.
   
   ```sh
   if [ "$1" == "2" ]
     if ! systemctl list-jobs; then
       systemctl stop traffic_ops
     else
       echo 'WARNING: systemctl failed - not stopping Traffic Ops!' > /dev/stderr
     fi
   fi
   ``` 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4250: Support upgrading or removing Traffic Ops when systemd does not work

Posted by GitBox <gi...@apache.org>.
rob05c commented on a change in pull request #4250: Support upgrading or removing Traffic Ops when systemd does not work
URL: https://github.com/apache/trafficcontrol/pull/4250#discussion_r362368860
 
 

 ##########
 File path: traffic_ops/build/traffic_ops.spec
 ##########
 @@ -131,7 +131,7 @@ Built: %(date) by %{getenv: USER}
 
     # upgrade
     if [ "$1" == "2" ]; then
-	systemctl stop traffic_ops
+        systemctl stop traffic_ops || true # Don't exit with an error if we are in an unprivileged Docker container and can't use systemctl
 
 Review comment:
   I have some concerns about this in production systems. What would happen if a production upgrade of Traffic Ops fails to stop from the `systemctl stop traffic_ops`? 
   
   I'm concerned if an upgrade is scripted, and automation tools log or alarm on a nonzero exit code. Even if it isn't a script, humans might reasonably expect a 0 exit code to mean success.
   
   Besides the exit code, that's going to make this script continue to run, even if `systemctl stop` fails. What happens when the script keeps going, while TO is running? Does it succeed and keep running the old TO? Does it fail elsewhere in an easy to debug way? Is whatever happens deterministic?
   
   It might be totally fine, I'd just like to be sure before we do this where it'll be installed in Prod. Especially since Mojo has a bad habit of refusing to die when told to.
   
   If the goal is primarily to fix #4249 I think we can probably just change the CiaB Dockerfiles to `FROM centos/systemd`; IMO we should probably do that anyway. It's valuable to make the CiaB emulate Prod as closely as possible, for testing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4250: Support upgrading or removing Traffic Ops when systemd does not work

Posted by GitBox <gi...@apache.org>.
rob05c commented on a change in pull request #4250: Support upgrading or removing Traffic Ops when systemd does not work
URL: https://github.com/apache/trafficcontrol/pull/4250#discussion_r362370925
 
 

 ##########
 File path: traffic_ops/build/traffic_ops.spec
 ##########
 @@ -131,7 +131,7 @@ Built: %(date) by %{getenv: USER}
 
     # upgrade
     if [ "$1" == "2" ]; then
-	systemctl stop traffic_ops
+        systemctl stop traffic_ops || true # Don't exit with an error if we are in an unprivileged Docker container and can't use systemctl
 
 Review comment:
   >What do you think about skipping that attempt to stop the service if systemd itself does not seem operational?
   
   That sounds like a good idea to me. Would you object to adding a tiny bit more logic, to log a warning if that happens? E.g.
   
   ```sh
   if [ "$1" == "2" ]; then
     if ! systemctl list-jobs; then
       systemctl stop traffic_ops
     else
       echo 'WARNING: systemctl failed - not stopping Traffic Ops!' > /dev/stderr
     fi
   fi
   ``` 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4250: Support upgrading or removing Traffic Ops when systemd does not work

Posted by GitBox <gi...@apache.org>.
rob05c commented on a change in pull request #4250: Support upgrading or removing Traffic Ops when systemd does not work
URL: https://github.com/apache/trafficcontrol/pull/4250#discussion_r362368860
 
 

 ##########
 File path: traffic_ops/build/traffic_ops.spec
 ##########
 @@ -131,7 +131,7 @@ Built: %(date) by %{getenv: USER}
 
     # upgrade
     if [ "$1" == "2" ]; then
-	systemctl stop traffic_ops
+        systemctl stop traffic_ops || true # Don't exit with an error if we are in an unprivileged Docker container and can't use systemctl
 
 Review comment:
   I have some concerns about this in production systems. What would happen if a production upgrade of Traffic Ops fails to stop from the `systemctl stop traffic_ops`? 
   
   I'm concerned if an upgrade is scripted, and automation tools log or alarm on a nonzero exit code. Even if it isn't a script, humans might reasonably expect a 0 exit code to mean success.
   
   Besides the exit code, that's going to make this script continue to run, even if `systemctl stop` fails. What happens when the script keeps going, while TO is running? Does it succeed and keep running the old TO? Does it fail elsewhere in an easy to debug way? Is whatever happens deterministic?
   
   It might be totally fine, I'd just like to be sure before we do this where it'll be installed in Prod. Especially since Mojo has a bad habit of refusing to die when told to.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4250: Support upgrading or removing Traffic Ops when systemd does not work

Posted by GitBox <gi...@apache.org>.
rob05c commented on a change in pull request #4250: Support upgrading or removing Traffic Ops when systemd does not work
URL: https://github.com/apache/trafficcontrol/pull/4250#discussion_r362370925
 
 

 ##########
 File path: traffic_ops/build/traffic_ops.spec
 ##########
 @@ -131,7 +131,7 @@ Built: %(date) by %{getenv: USER}
 
     # upgrade
     if [ "$1" == "2" ]; then
-	systemctl stop traffic_ops
+        systemctl stop traffic_ops || true # Don't exit with an error if we are in an unprivileged Docker container and can't use systemctl
 
 Review comment:
   >What do you think about skipping that attempt to stop the service if systemd itself does not seem operational?
   
   That sounds good to me. Would you object to adding a tiny bit more logic, to log a warning if that happens? E.g.
   
   ```sh
   if [ "$1" == "2" ]; then
     if systemctl list-jobs; then
       systemctl stop traffic_ops
     else
       echo 'WARNING: systemctl failed - not stopping Traffic Ops!' > /dev/stderr
     fi
   fi
   ``` 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4250: Support upgrading or removing Traffic Ops when systemd does not work

Posted by GitBox <gi...@apache.org>.
rob05c commented on a change in pull request #4250: Support upgrading or removing Traffic Ops when systemd does not work
URL: https://github.com/apache/trafficcontrol/pull/4250#discussion_r362370925
 
 

 ##########
 File path: traffic_ops/build/traffic_ops.spec
 ##########
 @@ -131,7 +131,7 @@ Built: %(date) by %{getenv: USER}
 
     # upgrade
     if [ "$1" == "2" ]; then
-	systemctl stop traffic_ops
+        systemctl stop traffic_ops || true # Don't exit with an error if we are in an unprivileged Docker container and can't use systemctl
 
 Review comment:
   >What do you think about skipping that attempt to stop the service if systemd itself does not seem operational?
   
   That sounds like a good idea to me. Would you object to adding a tiny bit more logic, to log a warning if that happens? E.g.
   
   ```sh
   if [ "$1" == "2" ]; then
     if systemctl list-jobs; then
       systemctl stop traffic_ops
     else
       echo 'WARNING: systemctl failed - not stopping Traffic Ops!' > /dev/stderr
     fi
   fi
   ``` 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #4250: Support upgrading or removing Traffic Ops when systemd does not work

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #4250: Support upgrading or removing Traffic Ops when systemd does not work
URL: https://github.com/apache/trafficcontrol/pull/4250#discussion_r362372839
 
 

 ##########
 File path: traffic_ops/build/traffic_ops.spec
 ##########
 @@ -131,7 +131,7 @@ Built: %(date) by %{getenv: USER}
 
     # upgrade
     if [ "$1" == "2" ]; then
-	systemctl stop traffic_ops
+        systemctl stop traffic_ops || true # Don't exit with an error if we are in an unprivileged Docker container and can't use systemctl
 
 Review comment:
   That sounds fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #4250: Support upgrading or removing Traffic Ops when systemd does not work

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #4250: Support upgrading or removing Traffic Ops when systemd does not work
URL: https://github.com/apache/trafficcontrol/pull/4250#discussion_r362370030
 
 

 ##########
 File path: traffic_ops/build/traffic_ops.spec
 ##########
 @@ -131,7 +131,7 @@ Built: %(date) by %{getenv: USER}
 
     # upgrade
     if [ "$1" == "2" ]; then
-	systemctl stop traffic_ops
+        systemctl stop traffic_ops || true # Don't exit with an error if we are in an unprivileged Docker container and can't use systemctl
 
 Review comment:
   I understand concerns about just silently exiting if the service itself fails to stop. What do you think about skipping that attempt to stop the service if systemd itself does not seem operational? E.g.,
   
   ```shell
   if [ "$1" == "2" ] && systemctl list-jobs; then
       systemctl stop traffic_ops
   fi
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #4250: Support upgrading or removing Traffic Ops when systemd does not work

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #4250: Support upgrading or removing Traffic Ops when systemd does not work
URL: https://github.com/apache/trafficcontrol/pull/4250#discussion_r362375989
 
 

 ##########
 File path: traffic_ops/build/traffic_ops.spec
 ##########
 @@ -131,7 +131,7 @@ Built: %(date) by %{getenv: USER}
 
     # upgrade
     if [ "$1" == "2" ]; then
-	systemctl stop traffic_ops
+        systemctl stop traffic_ops || true # Don't exit with an error if we are in an unprivileged Docker container and can't use systemctl
 
 Review comment:
   Addressed in 7a356ace

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services