You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Stuart Freeman (JIRA)" <ji...@apache.org> on 2009/04/21 22:57:47 UTC
[jira] Created: (SLING-934) AbstractSlingRepository.java
unbindLog() sets method scoped log to null
AbstractSlingRepository.java unbindLog() sets method scoped log to null
-----------------------------------------------------------------------
Key: SLING-934
URL: https://issues.apache.org/jira/browse/SLING-934
Project: Sling
Issue Type: Bug
Components: JCR
Reporter: Stuart Freeman
bundles/jcr/base/src/main/java/org/apache/sling/jcr/base/AbstractSlingRepository.java contains the following snippet:
protected void unbindLog(LogService log) {
if (this.log == log) {
log = null;
}
}
That sets the method scoped log to null, not the instance scoped this.log. I beleive it should look like:
protected void unbindLog(LogService log) {
if (this.log == log) {
this.log = null;
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-934) AbstractSlingRepository.java
unbindLog() sets method scoped log to null
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reassigned SLING-934:
---------------------------------------
Assignee: Felix Meschberger
> AbstractSlingRepository.java unbindLog() sets method scoped log to null
> -----------------------------------------------------------------------
>
> Key: SLING-934
> URL: https://issues.apache.org/jira/browse/SLING-934
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Reporter: Stuart Freeman
> Assignee: Felix Meschberger
>
> bundles/jcr/base/src/main/java/org/apache/sling/jcr/base/AbstractSlingRepository.java contains the following snippet:
> protected void unbindLog(LogService log) {
> if (this.log == log) {
> log = null;
> }
> }
> That sets the method scoped log to null, not the instance scoped this.log. I beleive it should look like:
> protected void unbindLog(LogService log) {
> if (this.log == log) {
> this.log = null;
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-934) AbstractSlingRepository.java unbindLog()
sets method scoped log to null
Posted by "Stuart Freeman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stuart Freeman closed SLING-934.
--------------------------------
> AbstractSlingRepository.java unbindLog() sets method scoped log to null
> -----------------------------------------------------------------------
>
> Key: SLING-934
> URL: https://issues.apache.org/jira/browse/SLING-934
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Reporter: Stuart Freeman
> Assignee: Felix Meschberger
> Fix For: JCR Base 2.0.4
>
>
> bundles/jcr/base/src/main/java/org/apache/sling/jcr/base/AbstractSlingRepository.java contains the following snippet:
> protected void unbindLog(LogService log) {
> if (this.log == log) {
> log = null;
> }
> }
> That sets the method scoped log to null, not the instance scoped this.log. I beleive it should look like:
> protected void unbindLog(LogService log) {
> if (this.log == log) {
> this.log = null;
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-934) AbstractSlingRepository.java
unbindLog() sets method scoped log to null
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701385#action_12701385 ]
Felix Meschberger commented on SLING-934:
-----------------------------------------
Correct. Thanks for reporting.
> AbstractSlingRepository.java unbindLog() sets method scoped log to null
> -----------------------------------------------------------------------
>
> Key: SLING-934
> URL: https://issues.apache.org/jira/browse/SLING-934
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Reporter: Stuart Freeman
> Assignee: Felix Meschberger
>
> bundles/jcr/base/src/main/java/org/apache/sling/jcr/base/AbstractSlingRepository.java contains the following snippet:
> protected void unbindLog(LogService log) {
> if (this.log == log) {
> log = null;
> }
> }
> That sets the method scoped log to null, not the instance scoped this.log. I beleive it should look like:
> protected void unbindLog(LogService log) {
> if (this.log == log) {
> this.log = null;
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-934) AbstractSlingRepository.java
unbindLog() sets method scoped log to null
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger resolved SLING-934.
-------------------------------------
Resolution: Fixed
Fixed in Rev. 767390.
Please close this issue, if this is ok for you. Thanks.
> AbstractSlingRepository.java unbindLog() sets method scoped log to null
> -----------------------------------------------------------------------
>
> Key: SLING-934
> URL: https://issues.apache.org/jira/browse/SLING-934
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Reporter: Stuart Freeman
> Assignee: Felix Meschberger
> Fix For: JCR Base 2.0.4
>
>
> bundles/jcr/base/src/main/java/org/apache/sling/jcr/base/AbstractSlingRepository.java contains the following snippet:
> protected void unbindLog(LogService log) {
> if (this.log == log) {
> log = null;
> }
> }
> That sets the method scoped log to null, not the instance scoped this.log. I beleive it should look like:
> protected void unbindLog(LogService log) {
> if (this.log == log) {
> this.log = null;
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-934) AbstractSlingRepository.java
unbindLog() sets method scoped log to null
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-934:
------------------------------------
Fix Version/s: JCR Base 2.0.4
> AbstractSlingRepository.java unbindLog() sets method scoped log to null
> -----------------------------------------------------------------------
>
> Key: SLING-934
> URL: https://issues.apache.org/jira/browse/SLING-934
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Reporter: Stuart Freeman
> Assignee: Felix Meschberger
> Fix For: JCR Base 2.0.4
>
>
> bundles/jcr/base/src/main/java/org/apache/sling/jcr/base/AbstractSlingRepository.java contains the following snippet:
> protected void unbindLog(LogService log) {
> if (this.log == log) {
> log = null;
> }
> }
> That sets the method scoped log to null, not the instance scoped this.log. I beleive it should look like:
> protected void unbindLog(LogService log) {
> if (this.log == log) {
> this.log = null;
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.