You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2015/06/23 10:26:55 UTC

Review Request 35773: Removed libgen.h include.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35773/
-----------------------------------------------------------

Review request for mesos, Adam B and Vinod Kone.


Bugs: MESOS-1303
    https://issues.apache.org/jira/browse/MESOS-1303


Repository: mesos


Description
-------

see summary.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 1e7aed0b48b8889eb8d042cbd9f907303d2510d3 

Diff: https://reviews.apache.org/r/35773/diff/


Testing
-------

make check on trailing RR.


Thanks,

Till Toenshoff


Re: Review Request 35773: Removed libgen.h include.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35773/#review88989
-----------------------------------------------------------

Ship it!


Ship It!

- Kapil Arya


On June 23, 2015, 4:29 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35773/
> -----------------------------------------------------------
> 
> (Updated June 23, 2015, 4:29 a.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-1303
>     https://issues.apache.org/jira/browse/MESOS-1303
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removes scattered includes of 'libgen.h'.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 1e7aed0b48b8889eb8d042cbd9f907303d2510d3 
> 
> Diff: https://reviews.apache.org/r/35773/diff/
> 
> 
> Testing
> -------
> 
> make check on trailing RR.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 35773: Removed libgen.h include.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35773/#review89003
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On June 23, 2015, 8:29 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35773/
> -----------------------------------------------------------
> 
> (Updated June 23, 2015, 8:29 a.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-1303
>     https://issues.apache.org/jira/browse/MESOS-1303
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removes scattered includes of 'libgen.h'.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 1e7aed0b48b8889eb8d042cbd9f907303d2510d3 
> 
> Diff: https://reviews.apache.org/r/35773/diff/
> 
> 
> Testing
> -------
> 
> make check on trailing RR.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 35773: Removed libgen.h include.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35773/
-----------------------------------------------------------

(Updated June 23, 2015, 8:29 a.m.)


Review request for mesos, Adam B and Vinod Kone.


Bugs: MESOS-1303
    https://issues.apache.org/jira/browse/MESOS-1303


Repository: mesos


Description (updated)
-------

Removes scattered includes of 'libgen.h'.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 1e7aed0b48b8889eb8d042cbd9f907303d2510d3 

Diff: https://reviews.apache.org/r/35773/diff/


Testing
-------

make check on trailing RR.


Thanks,

Till Toenshoff