You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martin Grigorov <mg...@apache.org> on 2011/06/21 15:21:38 UTC
Re: svn commit: r1137992 - /wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java
You can use Wicket's EnumeratedType which is extendable.
Provide the current ones by default and later the user app can add
more if it needs.
On Tue, Jun 21, 2011 at 4:15 PM, <da...@apache.org> wrote:
> Author: dashorst
> Date: Tue Jun 21 13:15:22 2011
> New Revision: 1137992
>
> URL: http://svn.apache.org/viewvc?rev=1137992&view=rev
> Log:
> Removed unholy TODO items: media should not be an enum, as the values are not enumerable. Similarly to our strict reliance on HTML 4 values for <input type="text">, media can change in the future. What we can do is create a Media class that lists default values for standard media values like "screen", "print".
>
> Modified:
> wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java
>
> Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java
> URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java?rev=1137992&r1=1137991&r2=1137992&view=diff
> ==============================================================================
> --- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java (original)
> +++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java Tue Jun 21 13:15:22 2011
> @@ -209,7 +209,6 @@ public interface IHeaderResponse extends
> * @param media
> * the media type for this CSS ("print", "screen", etc.)
> */
> - // TODO make media an enum
> public void renderCSSReference(String url, String media);
>
> /**
> @@ -223,7 +222,6 @@ public interface IHeaderResponse extends
> * @param condition
> * the condition to use for Internet Explorer conditional comments. E.g. "IE 7".
> */
> - // TODO make media an enum
> public void renderCSSReference(String url, String media, String condition);
>
>
>
>
>
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com