You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Raul Castro Fernandez <ra...@contxt.in> on 2014/06/07 01:44:20 UTC
Review Request 22335: Patch for samza-192
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22335/
-----------------------------------------------------------
Review request for samza.
Repository: samza
Description
-------
SAMZA-192; container PID is logged in SamzaContainer. A new Util.getContainerPID function returns the PID
Diffs
-----
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala bfff2a6
samza-core/src/main/scala/org/apache/samza/util/Util.scala 1b548fd
Diff: https://reviews.apache.org/r/22335/diff/
Testing
-------
I've tried the function in the debugger and the scala interpreter. Could not try it in a different environemnt than Linux
Thanks,
Raul Castro Fernandez
Re: Review Request 22335: Patch for samza-192
Posted by Raul Castro Fernandez <ra...@contxt.in>.
> On June 11, 2014, 8:05 p.m., Chris Riccomini wrote:
> > samza-core/src/main/scala/org/apache/samza/util/Util.scala, line 183
> > <https://reviews.apache.org/r/22335/diff/1/?file=605050#file605050line183>
> >
> > Yea, let's keep the Util function. It's still handy, rather than having to remember all of the ManagementFactory junk.
Cool. I just added the new version.
- Raul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22335/#review45420
-----------------------------------------------------------
On June 6, 2014, 11:44 p.m., Raul Castro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22335/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 11:44 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-192; container PID is logged in SamzaContainer. A new Util.getContainerPID function returns the PID
>
>
> Diffs
> -----
>
> samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala bfff2a6
> samza-core/src/main/scala/org/apache/samza/util/Util.scala 1b548fd
>
> Diff: https://reviews.apache.org/r/22335/diff/
>
>
> Testing
> -------
>
> I've tried the function in the debugger and the scala interpreter. Could not try it in a different environemnt than Linux
>
>
> Thanks,
>
> Raul Castro Fernandez
>
>
Re: Review Request 22335: Patch for samza-192
Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22335/#review45420
-----------------------------------------------------------
samza-core/src/main/scala/org/apache/samza/util/Util.scala
<https://reviews.apache.org/r/22335/#comment80280>
Yea, let's keep the Util function. It's still handy, rather than having to remember all of the ManagementFactory junk.
- Chris Riccomini
On June 6, 2014, 11:44 p.m., Raul Castro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22335/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 11:44 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-192; container PID is logged in SamzaContainer. A new Util.getContainerPID function returns the PID
>
>
> Diffs
> -----
>
> samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala bfff2a6
> samza-core/src/main/scala/org/apache/samza/util/Util.scala 1b548fd
>
> Diff: https://reviews.apache.org/r/22335/diff/
>
>
> Testing
> -------
>
> I've tried the function in the debugger and the scala interpreter. Could not try it in a different environemnt than Linux
>
>
> Thanks,
>
> Raul Castro Fernandez
>
>
Re: Review Request 22335: Patch for samza-192
Posted by Raul Castro Fernandez <ra...@contxt.in>.
> On June 9, 2014, 10:37 p.m., Chris Riccomini wrote:
> > samza-core/src/main/scala/org/apache/samza/util/Util.scala, line 183
> > <https://reviews.apache.org/r/22335/diff/1/?file=605050#file605050line183>
> >
> > Does this logic work for windows/linux/mac? Not sure this gives us any advantage over just returning the raw getName results. True it's not a PID, but I think this might be OK, and maybe a bit safer than doing the @ split, and potentially breaking platform support for other random OS's that might format things differently.
Ok. I will then log the string. In this case, should we maintain the Util function, or just read the property in SamzaContainer?
- Raul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22335/#review45162
-----------------------------------------------------------
On June 6, 2014, 11:44 p.m., Raul Castro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22335/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 11:44 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-192; container PID is logged in SamzaContainer. A new Util.getContainerPID function returns the PID
>
>
> Diffs
> -----
>
> samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala bfff2a6
> samza-core/src/main/scala/org/apache/samza/util/Util.scala 1b548fd
>
> Diff: https://reviews.apache.org/r/22335/diff/
>
>
> Testing
> -------
>
> I've tried the function in the debugger and the scala interpreter. Could not try it in a different environemnt than Linux
>
>
> Thanks,
>
> Raul Castro Fernandez
>
>
Re: Review Request 22335: Patch for samza-192
Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22335/#review45162
-----------------------------------------------------------
samza-core/src/main/scala/org/apache/samza/util/Util.scala
<https://reviews.apache.org/r/22335/#comment79854>
Does this logic work for windows/linux/mac? Not sure this gives us any advantage over just returning the raw getName results. True it's not a PID, but I think this might be OK, and maybe a bit safer than doing the @ split, and potentially breaking platform support for other random OS's that might format things differently.
- Chris Riccomini
On June 6, 2014, 11:44 p.m., Raul Castro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22335/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 11:44 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-192; container PID is logged in SamzaContainer. A new Util.getContainerPID function returns the PID
>
>
> Diffs
> -----
>
> samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala bfff2a6
> samza-core/src/main/scala/org/apache/samza/util/Util.scala 1b548fd
>
> Diff: https://reviews.apache.org/r/22335/diff/
>
>
> Testing
> -------
>
> I've tried the function in the debugger and the scala interpreter. Could not try it in a different environemnt than Linux
>
>
> Thanks,
>
> Raul Castro Fernandez
>
>