You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Thomas Andraschko (Jira)" <de...@myfaces.apache.org> on 2023/01/16 12:17:00 UTC
[jira] [Resolved] (MYFACES-4543) Flash does not Work with ClientWindow mode URL Mode
[ https://issues.apache.org/jira/browse/MYFACES-4543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Andraschko resolved MYFACES-4543.
----------------------------------------
Resolution: Fixed
> Flash does not Work with ClientWindow mode URL Mode
> ---------------------------------------------------
>
> Key: MYFACES-4543
> URL: https://issues.apache.org/jira/browse/MYFACES-4543
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.2.10, 2.3.10, 2.3-next-M7, 3.0.2, 4.0.0-RC3
> Reporter: Volodymyr Siedlecki
> Assignee: Volodymyr Siedlecki
> Priority: Major
> Fix For: 4.0.0-RC4
>
>
> This bug was discovered in the faces23/TCK
> ee.jakarta.tck.faces.test.javaee8.cdi.Spec1385IT - testInjectFlash.
> In a nutshell, setting an attribute on the flash map and then reloading the page does not work. This is due to to the fact that the application also contains flows.
> Flows, by default, requires a active ClientWindow mode and per default its set to URL.
> Flash defaults to use the ClientWIndow id to track the flash tokens, which is then set to URL as default. The URL mode looses the ClientWindow id on the initial request. Therefore we have a url-redirect, or DS and PrimeFaces ClientWindow.
> [https://github.com/apache/myfaces/blob/18f1f90cd2bdb22330444f77ff5e98097ed84634/impl/src/main/java/org/apache/myfaces/context/flash/FlashImpl.java#L752-L753]
> [https://github.com/apache/myfaces/blob/18f1f90cd2bdb22330444f77ff5e98097ed84634/impl/src/main/java/org/apache/myfaces/context/flash/FlashImpl.java#L797-L798]
> We could just remove the clientwindow checks (and use flash cookies as in MyFaces 2.0) , but I think it might be better to check if the current configuration requires client window url mode. If so, just use flash cookies instead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)