[jira] [Commented] (SOLR-13331) Atomic Update Multivalue remove does not work

["Jason Gerlowski (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16808006#comment-16808006 ] 

Jason Gerlowski commented on SOLR-13331:
----------------------------------------

Hi Thomas. Thanks for putting in some real legwork on this.  Particularly for testing with all the different field types.

Adding the {{ByteArrayUtf8CharSequence}}->{{String}} conversion to the base {{FieldType}} class as you suggest will fix a lot of these errors.  I'm a little leery that it might have side effects we don't want, but I'm still investigating and hopefully I can rule that out.

[~noble.paul] Any thoughts on using {{FieldType.toNativeType}} to correct this issue?  You've got more context on how some of the other ByteArrayUtf8CharSequence issues were handled, figured I'd see if this fix looked OK to you...

If nothing else turns up, I'll put together a test for this and merge in a day or two.

> Atomic Update Multivalue remove does not work
> ---------------------------------------------
>
>                 Key: SOLR-13331
>                 URL: https://issues.apache.org/jira/browse/SOLR-13331
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: UpdateRequestProcessors
>    Affects Versions: 7.7, 7.7.1, 8.0
>         Environment: Standalone Solr Server
>            Reporter: Thomas Wöckinger
>            Assignee: Jason Gerlowski
>            Priority: Critical
>              Labels: patch
>             Fix For: 8.0
>
>         Attachments: Fix-SOLR13331-Add-toNativeType-implementations.patch
>
>
> When using JavaBinCodec the values of collections are of type ByteArrayUtf8CharSequence, existing field values are Strings so the remove Operation does not have any effect.
> The relevant code is located in class AtomicUpdateDocumentMerger method doRemove.
> The method parameter fieldVal contains the collection values of type ByteArrayUtf8CharSequence, the variable original contains the collection of Strings



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org