You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Jacques Le Roux (JIRA)" <ji...@apache.org> on 2008/07/05 13:41:31 UTC
[jira] Commented: (OFBIZ-1698) Locale labels in language different
from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610689#action_12610689 ]
Jacques Le Roux commented on OFBIZ-1698:
----------------------------------------
Hi Bruno,
Please let me know if you are still interested by this issue (I already asked on dev ML). I gave it a try today. After a 1st review, here are some remarks
There are some annoyances :
========================================================================================
Trivial (but maybe not in you Python script)
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-
+<?xml version="1.0" encoding="UTF-8" ?><!--
--->
-<resource xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+--><resource xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
========================================================================================
." and at large all special characters are replaced by HTML entities (not easy to learn and maintain)
- <value xml:lang="nl">Berekenings eigenschappen voor de boekhouddiensten zijn niet geconfigureerd, processen is gestopt."</value>
+ <value xml:lang="nl">Berekenings eigenschappen voor de boekhouddiensten zijn niet geconfigureerd, processen is gestopt."</value>
========================================================================================
Because your algorithm was written before we decided to not have overriden labels in different files, we have some in this patch. If you are still interested you could change your script to only keep CommonDescription in Common file in the case below. At large, the rule should be discussed before. But in case of duplicated lables, we may automatically keep only labels within their own file (like CommonDescription). Your script may in other cases write a list of possible changes to check by hand, ie 2 patches : 1 for changes to apply, one for changes to check before applying.
ContentUiLabels.xml
+ <property key="CommonDescription">
+ <value xml:lang="ar">وصف</value>
+ <value xml:lang="en">Description</value>
+ <value xml:lang="it">Descrizione</value>
+ <value xml:lang="ro">Descriere</value>
+ <value xml:lang="th">รายละเอียด</value>
+ <value xml:lang="zh">描述</value>
+ </property>
- <property key="CommonDescription">
- <value xml:lang="ar">وصف</value>
- <value xml:lang="en">Description</value>
- <value xml:lang="it">Descrizione</value>
- <value xml:lang="ro">Descriere</value>
- <value xml:lang="th">รายละเอียด</value>
- <value xml:lang="zh">描述</value>
- </property>
ProductUiLabels.xml
+ <property key="CommonDescription">
+ <value xml:lang="en">Description</value>
+ <value xml:lang="fr">Description</value>
+ <value xml:lang="it">Descrizione</value>
+ <value xml:lang="ro">Descriere</value>
+ <value xml:lang="ru">Описание</value>
+ <value xml:lang="th">อธิบาย</value>
+ <value xml:lang="zh">描述</value>
+ </property>
- <property key="CommonDescription">
- <value xml:lang="en">Description</value>
- <value xml:lang="fr">Description</value>
- <value xml:lang="it">Descrizione</value>
- <value xml:lang="ro">Descriere</value>
- <value xml:lang="ru">Описание</value>
- <value xml:lang="th">อธิบาย</value>
- <value xml:lang="zh">描述</value>
- </property>
CommonUiLabels.xml
<property key="CommonDescription">
<value xml:lang="ar">وصف</value>
<value xml:lang="cs">Popis</value>
<value xml:lang="de">Beschreibung</value>
<value xml:lang="en">Description</value>
<value xml:lang="es">Descripción</value>
<value xml:lang="fr">Description</value>
<value xml:lang="it">Descrizione</value>
<value xml:lang="nl">Omschrijving</value>
<value xml:lang="pt">Descrição</value>
<value xml:lang="ro">Descriere</value>
<value xml:lang="ru">Описание</value>
<value xml:lang="th">คำอธิบาย</value>
<value xml:lang="zh">描述</value>
<value xml:lang="zh_CN">描述</value>
</property>
Please, let me know what you think.
> Locale labels in language different from the fallback sometime are not displayed
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-1698
> URL: https://issues.apache.org/jira/browse/OFBIZ-1698
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Jacques Le Roux
> Attachments: cleanlabels.patch.zip
>
>
> A label is not displayed in the selected language but in the fallback one when ALL the following are true:
> - A language different from the one specified as "locale.properties.fallback" in framework/common/config/general.properties is selected
> - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml)
> - The screen includes first File1UiLabels.xml and then File2UiLabels.xml
> - In File1UiLabels.xml there is NO translation for the selected language
> - In File2UiLabels.xml there is the translation for the selected language
> This bug was not present in Release 4.0 and i think could have been introduced with the new locale system.
> You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. -> Labels "Cart Summary" and "Special Offers" are not translated.
> In the R4.0 demo it is all OK
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.