You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/10 02:57:47 UTC
[GitHub] [incubator-superset] john-bodley opened a new pull request #10279: chore: Releasing SQL Lab Celery results
john-bodley opened a new pull request #10279:
URL: https://github.com/apache/incubator-superset/pull/10279
### SUMMARY
Per the Celery [documentation](https://docs.celeryproject.org/en/stable/reference/celery.result.html#celery-result) in relation to Celery results,
> **Warning:**
Backends use resources to store and transmit results. To ensure that resources are released, you must eventually call `get()` or `forget()` on EVERY AsyncResult instance returned after calling a task.
which we aren't doing. Given we actually don't store the SQL Lab payloads in the Celery results backend holding onto these task result metadata for [24 hours](https://docs.celeryproject.org/en/latest/userguide/configuration.html#result-expires) seems unnecessary and can result in having thousands of redundant records (at Airbnb we have in excess of 10,000 keys which could be retired). It seems fairly trivial to clean as we go.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10279: chore: Releasing SQL Lab Celery results
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10279:
URL: https://github.com/apache/incubator-superset/pull/10279#issuecomment-656454321
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=h1) Report
> Merging [#10279](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/af864e9fff74022c6b2c0007fb6f5028e720cd40&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10279 +/- ##
==========================================
- Coverage 65.47% 65.42% -0.06%
==========================================
Files 598 598
Lines 31992 32002 +10
Branches 3234 3234
==========================================
- Hits 20946 20936 -10
- Misses 10865 10885 +20
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.39% <ø> (-0.01%)` | :arrow_down: |
| #python | `69.61% <100.00%> (-0.09%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.39% <100.00%> (-0.23%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.72% <0.00%> (-12.77%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.83% <0.00%> (-0.84%)` | :arrow_down: |
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `68.25% <0.00%> (-0.80%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.80% <0.00%> (-0.15%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.31% <0.00%> (+<0.01%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `100.00% <0.00%> (+2.63%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=footer). Last update [af864e9...5f94beb](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10279: chore: Releasing SQL Lab Celery results
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10279:
URL: https://github.com/apache/incubator-superset/pull/10279#issuecomment-656454321
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=h1) Report
> Merging [#10279](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/af864e9fff74022c6b2c0007fb6f5028e720cd40&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10279 +/- ##
==========================================
- Coverage 65.47% 65.43% -0.04%
==========================================
Files 598 598
Lines 31992 31993 +1
Branches 3234 3234
==========================================
- Hits 20946 20934 -12
- Misses 10865 10878 +13
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.39% <ø> (-0.01%)` | :arrow_down: |
| #python | `69.64% <100.00%> (-0.07%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.39% <100.00%> (-0.23%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.72% <0.00%> (-12.77%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.83% <0.00%> (-0.84%)` | :arrow_down: |
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `68.25% <0.00%> (-0.80%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.80% <0.00%> (-0.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `100.00% <0.00%> (+2.63%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=footer). Last update [af864e9...5f94beb](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10279: chore: Releasing SQL Lab Celery results
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10279:
URL: https://github.com/apache/incubator-superset/pull/10279#issuecomment-656454321
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=h1) Report
> Merging [#10279](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/af864e9fff74022c6b2c0007fb6f5028e720cd40&el=desc) will **decrease** coverage by `6.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10279 +/- ##
==========================================
- Coverage 65.47% 59.39% -6.09%
==========================================
Files 598 404 -194
Lines 31992 13138 -18854
Branches 3234 3234
==========================================
- Hits 20946 7803 -13143
+ Misses 10865 5154 -5711
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.39% <ø> (-0.01%)` | :arrow_down: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `68.25% <0.00%> (-0.80%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | | |
| [superset/utils/urls.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvdXJscy5weQ==) | | |
| [superset/extensions.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | | |
| [superset/utils/logging\_configurator.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nZ2luZ19jb25maWd1cmF0b3IucHk=) | | |
| [superset/db\_engine\_specs/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL19faW5pdF9fLnB5) | | |
| [superset/queries/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zY2hlbWFzLnB5) | | |
| [superset/db\_engine\_specs/vertica.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ZlcnRpY2EucHk=) | | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | | |
| ... and [184 more](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=footer). Last update [af864e9...5f94beb](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10279: chore: Releasing SQL Lab Celery results
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10279:
URL: https://github.com/apache/incubator-superset/pull/10279#issuecomment-656454321
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=h1) Report
> Merging [#10279](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/af864e9fff74022c6b2c0007fb6f5028e720cd40&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10279 +/- ##
==========================================
- Coverage 65.47% 65.33% -0.14%
==========================================
Files 598 598
Lines 31992 31993 +1
Branches 3234 3234
==========================================
- Hits 20946 20902 -44
- Misses 10865 10910 +45
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.39% <ø> (-0.01%)` | :arrow_down: |
| #python | `69.47% <100.00%> (-0.24%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.39% <100.00%> (-0.23%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.72% <0.00%> (-12.77%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <0.00%> (-3.41%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.44% <0.00%> (-2.23%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `61.32% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.00% <0.00%> (-0.96%)` | :arrow_down: |
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `68.25% <0.00%> (-0.80%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/10279/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=footer). Last update [af864e9...5f94beb](https://codecov.io/gh/apache/incubator-superset/pull/10279?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley merged pull request #10279: chore: Releasing SQL Lab Celery results
Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #10279:
URL: https://github.com/apache/incubator-superset/pull/10279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org