You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2022/02/01 19:56:55 UTC
svn commit: r1897668 - in /poi/trunk/poi/src: main/java/org/apache/poi/ss/util/CellAddress.java test/java/org/apache/poi/ss/usermodel/BaseTestCellComment.java test/java/org/apache/poi/ss/util/TestCellAddress.java
Author: fanningpj
Date: Tue Feb 1 19:56:54 2022
New Revision: 1897668
URL: http://svn.apache.org/viewvc?rev=1897668&view=rev
Log:
add R1C1 test
Modified:
poi/trunk/poi/src/main/java/org/apache/poi/ss/util/CellAddress.java
poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestCellComment.java
poi/trunk/poi/src/test/java/org/apache/poi/ss/util/TestCellAddress.java
Modified: poi/trunk/poi/src/main/java/org/apache/poi/ss/util/CellAddress.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/util/CellAddress.java?rev=1897668&r1=1897667&r2=1897668&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/ss/util/CellAddress.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/ss/util/CellAddress.java Tue Feb 1 19:56:54 2022
@@ -171,4 +171,13 @@ public class CellAddress implements Comp
public String formatAsString() {
return CellReference.convertNumToColString(this._col)+(this._row+1);
}
+
+ /**
+ * @return R1C1-style cell address string representation
+ * @see #formatAsString()
+ * @since POI 5.2.1
+ */
+ public String formatAsR1C1String() {
+ return new CellReference(_row, _col).formatAsR1C1String();
+ }
}
Modified: poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestCellComment.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestCellComment.java?rev=1897668&r1=1897667&r2=1897668&view=diff
==============================================================================
--- poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestCellComment.java (original)
+++ poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestCellComment.java Tue Feb 1 19:56:54 2022
@@ -410,11 +410,13 @@ public abstract class BaseTestCellCommen
assertEquals(CellAddress.A1, comment.getAddress());
CellAddress C2 = new CellAddress("C2");
assertEquals("C2", C2.formatAsString());
+ assertEquals("R2C3", C2.formatAsR1C1String());
comment.setAddress(C2);
assertEquals(C2, comment.getAddress());
CellAddress E10 = new CellAddress(9, 4);
assertEquals("E10", E10.formatAsString());
+ assertEquals("R10C5", E10.formatAsR1C1String());
comment.setAddress(9, 4);
assertEquals(E10, comment.getAddress());
}
Modified: poi/trunk/poi/src/test/java/org/apache/poi/ss/util/TestCellAddress.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/ss/util/TestCellAddress.java?rev=1897668&r1=1897667&r2=1897668&view=diff
==============================================================================
--- poi/trunk/poi/src/test/java/org/apache/poi/ss/util/TestCellAddress.java (original)
+++ poi/trunk/poi/src/test/java/org/apache/poi/ss/util/TestCellAddress.java Tue Feb 1 19:56:54 2022
@@ -51,6 +51,7 @@ final class TestCellAddress {
@Test
void testFormatAsString() {
assertEquals("A1", CellAddress.A1.formatAsString());
+ assertEquals("R1C1", CellAddress.A1.formatAsR1C1String());
}
@Test
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org