You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/01/04 09:04:59 UTC

[GitHub] [kafka] chia7712 commented on a change in pull request #9805: MINOR: Remove outdated comment in Connect's WorkerCoordinator

chia7712 commented on a change in pull request #9805:
URL: https://github.com/apache/kafka/pull/9805#discussion_r551189138



##########
File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java
##########
@@ -50,7 +50,6 @@
  * to workers.
  */
 public class WorkerCoordinator extends AbstractCoordinator implements Closeable {
-    // Currently doesn't support multiple task assignment strategies, so we just fill in a default value
     public static final String DEFAULT_SUBPROTOCOL = "default";

Review comment:
       It seems ```DEFAULT_SUBPROTOCOL``` is used by testing only. Should we move it to test code?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org