You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/27 03:38:56 UTC
[GitHub] [incubator-nuttx] no1wudi opened a new pull request #4615: sched/signal: Correct kill with cancellation
no1wudi opened a new pull request #4615:
URL: https://github.com/apache/incubator-nuttx/pull/4615
## Summary
I find that the `kill` doesn't works with pthread cancellation for some workload (without any cancelable syscall) like
```
for(;;)
{
}
```
This patch execute exit routine directly if no nested cancellation point called.
## Impact
Should be none
## Testing
Tested with custom apps and ostest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4615: sched/signal: Correct kill with cancellation
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4615:
URL: https://github.com/apache/incubator-nuttx/pull/4615#discussion_r716377689
##########
File path: sched/signal/sig_default.c
##########
@@ -194,11 +194,20 @@ static void nxsig_abnormal_termination(int signo)
{
FAR struct tcb_s *rtcb = (FAR struct tcb_s *)this_task();
- /* Notify the target if the non-cancelable or deferred cancellation set */
+#ifdef CONFIG_CANCELLATION_POINTS
Review comment:
Should we skip the cancellation point check here? It doesn't make sense that the default handle do the check, but user installed handler doesn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4615: sched/signal: Correct kill with cancellation
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4615:
URL: https://github.com/apache/incubator-nuttx/pull/4615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4615: sched/signal: Correct kill with cancellation
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4615:
URL: https://github.com/apache/incubator-nuttx/pull/4615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #4615: sched/signal: Correct kill with cancellation
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #4615:
URL: https://github.com/apache/incubator-nuttx/pull/4615#discussion_r716411821
##########
File path: sched/signal/sig_default.c
##########
@@ -194,11 +194,20 @@ static void nxsig_abnormal_termination(int signo)
{
FAR struct tcb_s *rtcb = (FAR struct tcb_s *)this_task();
- /* Notify the target if the non-cancelable or deferred cancellation set */
+#ifdef CONFIG_CANCELLATION_POINTS
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org