You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ra...@apache.org on 2019/06/18 01:20:28 UTC

[cordova-common] 03/04: Remove usage of jasmine's done in sync specs

This is an automated email from the ASF dual-hosted git repository.

raphinesse pushed a commit to branch clean-spec-promises
in repository https://gitbox.apache.org/repos/asf/cordova-common.git

commit a5c411b9369aa8bd772148796fc9ae341bea41ec
Author: Raphael von der GrĂ¼n <ra...@gmail.com>
AuthorDate: Tue Jun 18 02:18:27 2019 +0200

    Remove usage of jasmine's done in sync specs
---
 spec/plist-helpers.spec.js | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/spec/plist-helpers.spec.js b/spec/plist-helpers.spec.js
index fc4c923..031216f 100644
--- a/spec/plist-helpers.spec.js
+++ b/spec/plist-helpers.spec.js
@@ -43,7 +43,7 @@ describe('prunePLIST', function () {
 
     var selector = 'FirstConfigKey';
 
-    it('Test 01: should remove property from plist file using provided selector', function (done) {
+    it('Test 01: should remove property from plist file using provided selector', () => {
         var pruneStatus = plistHelpers.prunePLIST(doc, xml, selector);
 
         expect(pruneStatus).toBeTruthy();
@@ -54,8 +54,6 @@ describe('prunePLIST', function () {
                 }
             }
         );
-
-        done();
     });
 });
 
@@ -74,7 +72,7 @@ describe('plistGraft', function () {
 
     let selector = 'keychain-access-groups';
 
-    it('Test 01: should not mangle existing plist entries', function (done) {
+    it('Test 01: should not mangle existing plist entries', () => {
         var graftStatus = plistHelpers.graftPLIST(doc, xml, selector);
 
         expect(graftStatus).toBeTruthy();
@@ -86,7 +84,5 @@ describe('plistGraft', function () {
                 ]
             }
         );
-
-        done();
     });
 });


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org