You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org> on 2023/12/15 07:36:55 UTC

[PR] [fix](session variables) Make default value of max_execution_time same to query_timeout [doris]

zhiqiang-hhhh opened a new pull request, #28474:
URL: https://github.com/apache/doris/pull/28474

   Current problem, `UNSET global VARIABLE ALL` will write an oplog, which makes query_timeout = 0 when we replay it in a future time-stamp. So we change default value of max_execution_time to 90000 which is consistent to query_timeout default value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](session variables) Make default value of max_execution_time same to query_timeout [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28474:
URL: https://github.com/apache/doris/pull/28474#issuecomment-1857760093

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit e21bad1675b2d1ae5204cbc3d5b83331ac21c856, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4753	4487	4478	4478
   q2	372	182	159	159
   q3	1453	1245	1227	1227
   q4	1111	913	930	913
   q5	3188	3197	3196	3196
   q6	246	126	130	126
   q7	998	494	486	486
   q8	2210	2199	2175	2175
   q9	6667	6681	6654	6654
   q10	3233	3280	3302	3280
   q11	321	196	196	196
   q12	355	204	207	204
   q13	4590	3818	3790	3790
   q14	248	218	220	218
   q15	571	524	523	523
   q16	446	397	397	397
   q17	1008	646	574	574
   q18	7133	6774	6764	6764
   q19	1541	1469	1308	1308
   q20	517	336	301	301
   q21	3080	2655	2671	2655
   q22	351	274	281	274
   Total cold run time: 44392 ms
   Total hot run time: 39898 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4423	4435	4407	4407
   q2	267	164	170	164
   q3	3512	3513	3507	3507
   q4	2405	2388	2391	2388
   q5	5732	5717	5766	5717
   q6	238	124	122	122
   q7	2378	1855	1891	1855
   q8	3511	3518	3549	3518
   q9	9003	8997	9023	8997
   q10	3941	4019	4008	4008
   q11	501	390	386	386
   q12	768	610	606	606
   q13	4324	3562	3539	3539
   q14	301	244	248	244
   q15	577	518	526	518
   q16	517	479	458	458
   q17	1896	1875	1867	1867
   q18	8486	8053	8091	8053
   q19	1708	1747	1770	1747
   q20	2227	1940	1920	1920
   q21	6541	6208	6110	6110
   q22	496	407	418	407
   Total cold run time: 63752 ms
   Total hot run time: 60538 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](session variables) Make default value of max_execution_time same to query_timeout [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28474:
URL: https://github.com/apache/doris/pull/28474#issuecomment-1857570639

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](session variables) Make default value of max_execution_time same to query_timeout [doris]

Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on PR #28474:
URL: https://github.com/apache/doris/pull/28474#issuecomment-1857696940

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](session variables) Make default value of max_execution_time same to query_timeout [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28474:
URL: https://github.com/apache/doris/pull/28474#issuecomment-1857570709

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](session variables) Make default value of max_execution_time same to query_timeout [doris]

Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on PR #28474:
URL: https://github.com/apache/doris/pull/28474#issuecomment-1857416229

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](session variables) Make default value of max_execution_time same to query_timeout [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #28474:
URL: https://github.com/apache/doris/pull/28474


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](session variables) Make default value of max_execution_time same to query_timeout [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28474:
URL: https://github.com/apache/doris/pull/28474#issuecomment-1857457024

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 44.59 seconds
    stream load tsv:          585 seconds loaded 74807831229 Bytes, about 121 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          66 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.8 seconds inserted 10000000 Rows, about 347K ops/s
    storage size: 17217872964 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](session variables) Make default value of max_execution_time same to query_timeout [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #28474:
URL: https://github.com/apache/doris/pull/28474#issuecomment-1857696303

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](session variables) Make default value of max_execution_time same to query_timeout [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28474:
URL: https://github.com/apache/doris/pull/28474#issuecomment-1857741595

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 44.72 seconds
    stream load tsv:          587 seconds loaded 74807831229 Bytes, about 121 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          66 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.9 seconds inserted 10000000 Rows, about 346K ops/s
    storage size: 17220172888 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org