You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by andrewor14 <gi...@git.apache.org> on 2016/05/02 19:42:59 UTC
[GitHub] spark pull request: [SPARK-15068][SQL] Use proper metastore wareho...
GitHub user andrewor14 opened a pull request:
https://github.com/apache/spark/pull/12847
[SPARK-15068][SQL] Use proper metastore warehouse dir
## What changes were proposed in this pull request?
Today, we use `""` for the metastore warehouse dir without Hive, and `/user/hive/warehouse` with Hive. These are somewhat arbitrary and unlikely to exist on the box running Spark. A better default is something under `user.dir`.
This patch also allows the user to configure the warehouse dir using `spark.sql.warehouse.dir`. Alternatively, the user can also set `hive.metastore.warehouse.dir`. If both are set, the Spark one takes precedence.
## How was this patch tested?
`HiveClientSuite`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrewor14/spark default-db-path
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12847.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12847
----
commit 9e32e239e90aa3d665aa3dfb33ac5d7f8932d326
Author: Andrew Or <an...@databricks.com>
Date: 2016-04-30T00:28:16Z
Use configured warehouse path instead of empty string
commit a576861b66103b094ab67e524c6d3484eff466ea
Author: Andrew Or <an...@databricks.com>
Date: 2016-05-02T19:34:17Z
Resolve warehouse path from Spark and Hive confs
commit 9a4f0da2185d01d9e36e4faa7f03b4cfc5e617b6
Author: Andrew Or <an...@databricks.com>
Date: 2016-05-02T19:35:10Z
Merge branch 'master' of github.com:apache/spark into default-db-path
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15068][SQL] Use proper metastore wareho...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 closed the pull request at:
https://github.com/apache/spark/pull/12847
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15068][SQL] Use proper metastore wareho...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12847#issuecomment-216341856
**[Test build #57551 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57551/consoleFull)** for PR 12847 at commit [`b3af9ba`](https://github.com/apache/spark/commit/b3af9ba7ed33ce39af798bde07a1d1d943e69708).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15068][SQL] Use proper metastore wareho...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12847#issuecomment-216380013
**[Test build #57564 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57564/consoleFull)** for PR 12847 at commit [`b3af9ba`](https://github.com/apache/spark/commit/b3af9ba7ed33ce39af798bde07a1d1d943e69708).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15068][SQL] Use proper metastore wareho...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12847#issuecomment-216360274
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15068][SQL] Use proper metastore wareho...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12847#issuecomment-216392235
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15068][SQL] Use proper metastore wareho...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12847#issuecomment-216392236
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57564/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15068][SQL] Use proper metastore wareho...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12847#issuecomment-216360100
**[Test build #57551 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57551/consoleFull)** for PR 12847 at commit [`b3af9ba`](https://github.com/apache/spark/commit/b3af9ba7ed33ce39af798bde07a1d1d943e69708).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15068][SQL] Use proper metastore wareho...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12847#issuecomment-216360277
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57551/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15068][SQL] Use proper metastore wareho...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12847#issuecomment-216379875
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15068][SQL] Use proper metastore wareho...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12847#issuecomment-216392102
**[Test build #57564 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57564/consoleFull)** for PR 12847 at commit [`b3af9ba`](https://github.com/apache/spark/commit/b3af9ba7ed33ce39af798bde07a1d1d943e69708).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org