You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/12/30 09:12:01 UTC
[GitHub] [nuttx] Gary-Hobson opened a new pull request, #8008: syslog: fix extra line breaks in syslog when SYSLOG_COLOR_OUTPUT is e…
Gary-Hobson opened a new pull request, #8008:
URL: https://github.com/apache/nuttx/pull/8008
## Summary
fix extra line breaks in syslog when SYSLOG_COLOR_OUTPUT is enabled
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #8008: syslog: fix extra line breaks in syslog when SYSLOG_COLOR_OUTPUT is e…
Posted by GitBox <gi...@apache.org>.
Gary-Hobson commented on code in PR #8008:
URL: https://github.com/apache/nuttx/pull/8008#discussion_r1059966193
##########
libs/libc/stream/lib_syslogstream.c:
##########
@@ -218,11 +218,6 @@ void lib_syslogstream_close(FAR struct lib_syslogstream_s *stream)
{
DEBUGASSERT(stream != NULL);
- if (stream->last_ch != '\n')
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8008: syslog: fix extra line breaks in syslog when SYSLOG_COLOR_OUTPUT is e…
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8008:
URL: https://github.com/apache/nuttx/pull/8008#discussion_r1059480779
##########
libs/libc/stream/lib_syslogstream.c:
##########
@@ -218,11 +218,6 @@ void lib_syslogstream_close(FAR struct lib_syslogstream_s *stream)
{
DEBUGASSERT(stream != NULL);
- if (stream->last_ch != '\n')
Review Comment:
let's restore lib_syslogstream_close to macro like before: https://github.com/apache/nuttx/pull/8004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8008: syslog: fix extra line breaks in syslog when SYSLOG_COLOR_OUTPUT is e…
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #8008:
URL: https://github.com/apache/nuttx/pull/8008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org