You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by ad...@apache.org on 2026/06/08 10:08:25 UTC
(wicket) branch master updated: Make HTML spec compliant (#1458)
This is an automated email from the ASF dual-hosted git repository.
bitstorm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/wicket.git
The following commit(s) were added to refs/heads/master by this push:
new 139bc13baf Make <wicket:header-items/> HTML spec compliant (#1458)
139bc13baf is described below
commit 139bc13baf3ebf802e7f9badffb833ea36242700
Author: Andreas Svanberg <an...@mensa.se>
AuthorDate: Mon Jun 8 12:08:20 2026 +0200
Make <wicket:header-items/> HTML spec compliant (#1458)
According to the [HTML specification for `<meta>` element](https://html.spec.whatwg.org/multipage/semantics.html#the-meta-element), a `<meta>` tag with the `name` attribute specified must also specify `content`.
> If either name, http-equiv, or itemprop is specified, then the content attribute must also be specified. Otherwise, it must be omitted.
Since `<wicket:header-items/>` is often placed in a base class for pages it means that no pages in the application will pass HTML validation.
---
.../apache/wicket/markup/html/internal/HtmlHeaderItemsContainer.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/HtmlHeaderItemsContainer.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/HtmlHeaderItemsContainer.java
index 4249c6a2b1..d6758cd712 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/HtmlHeaderItemsContainer.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/HtmlHeaderItemsContainer.java
@@ -44,7 +44,7 @@ public class HtmlHeaderItemsContainer extends HtmlHeaderContainer
protected void onAfterRender() {
super.onAfterRender();
final Response webResponse = getResponse();
- webResponse.write("<meta name=\"wicket.header.items\"/>");
+ webResponse.write("<meta name=\"wicket.header.items\" content=\"\"/>");
}
@Override