[GitHub] [airflow] ashb commented on pull request #13440: Additional properties should be allowed in provider schema

[GitBox <gi...@apache.org>]

ashb commented on pull request #13440:
URL: https://github.com/apache/airflow/pull/13440#issuecomment-753962424


   >Seems that providers that next wave of providers we are going to release will not be compatible with 2.0.0 because they already have 'logo' added as additional property in yaml and providers will not be able to register themselves (schema will fail validation)
   
   `logo` property is not relevant to runtime code at all -- that is only used for building our docs/website. This change (which i have no problem with in principle) is caused by using one file for two purposes.
   
   I'm not fan of setting additionalProperties to true in general -- it means you can make silly mistakes like typoing a field name and not get any protection.
   
   I'd like to discus reverting this change (or at least the schema deprecation part), as my understanding of this is we are changing the provider yaml schema to support something "outside" of Airflow code.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org