You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2007/04/17 14:04:39 UTC
DO NOT REPLY [Bug 42144] New: - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
Summary: [PATCH] Safely set postscript page device dictionary,
additional processing states for OffDocumentItems
Product: Fop
Version: all
Platform: Other
URL: http://wiki.apache.org/xmlgraphics-
fop/ExtensionsForPostScript
OS/Version: other
Status: NEW
Severity: normal
Priority: P2
Component: ps
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: fop-dev@cumiskey.com
See http://wiki.apache.org/xmlgraphics-fop/ExtensionsForPostScript for details
of the new extensions I have added.
This patch should also includes :-
* Some performance improvements in page rendition so postscript page setup is
cached and reused for pages that use the same simple-page-master.
* Changes to org.apache.fop.area.OffDocumentItem,
org.apache.fop.area.RenderPagesModel with the addition of some new off document
item "when to process" states: BEFORE_PAGE, BEFORE_PAGE_SEQ, AFTER_PAGE_SEQ for
org.apache.fop.area.OffDocumentItem.
* Changes to org.apache.fop.area.AreaTreeHander so extension attachments
declared as children of simple page master are handled BEFORE_PAGE_SEQ on renderer.
* Changes to org.apache.fop.area.OffDocumentExtension so whenToProcess can be set.
* A new protected accessor method called getPSGenerator on
org.apache.fop.ps.PSRenderer that should make it a little easier to customize
resolving.
* Added extension attachments to base org.apache.fop.area.AreaTreeObject class
Please try the patch out, as always feedback is welcome :-).
Adrian Cumiskey.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
Bug 42144 depends on bug 43069, which changed state.
Bug 43069 Summary: [PATCH] Safely set postscript page device dictionary
http://issues.apache.org/bugzilla/show_bug.cgi?id=43069
What |Old Value |New Value
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
fop-dev@cumiskey.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19978|0 |1
is obsolete| |
------- Additional Comments From fop-dev@cumiskey.com 2007-04-27 01:57 -------
Created an attachment (id=20059)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20059&action=view)
list of files
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
------- Additional Comments From fop-dev@cumiskey.com 2007-04-17 05:08 -------
Created an attachment (id=19979)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=19979&action=view)
patch file
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
------- Additional Comments From jeremias@apache.org 2007-04-18 05:50 -------
Thanks for the patch. It will take a little time until I can look into it in detail.
One thing caught my eye: Why do you define an extension element to set the
document title? There's a "title" value in the FOUserAgent you can use. I'd
prefer if we reused existing functionality if possible, especially in cases
where different output formats support the same things. Of course, you obviously
want to set the title through the FO document. IMO, this should be done through
XMP metadata. The PDFRenderer already listens to the XMP metadata object and
populates its Info object accordingly. The PSRenderer could easily do the same.
The FO would look like this:
[..]
<fo:declarations>
<x:xmpmeta xmlns:x="adobe:ns:meta/">
<rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#">
<rdf:Description rdf:about="" xmlns:dc="http://purl.org/dc/elements/1.1/">
<dc:title>My document title</dc:title>
</rdf:Description>
</rdf:RDF>
</x:xmpmeta>
</fo:declarations>
[..]
Granted, this is a little more complicated than your approach but it's based on
a standard and there would be no special facility just for PostScript.
More later when I've had time to look into the details.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
dev@cumiskey.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[PATCH] Safely set |[PATCH] Safely set
|postscript page device |postscript page device
|dictionary, additional |dictionary
|processing states for |
|OffDocumentItems |
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
dev@cumiskey.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20273|0 |1
is obsolete| |
------- Additional Comments From dev@cumiskey.com 2007-06-13 07:24 -------
Created an attachment (id=20340)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20340&action=view)
patch file
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
fop-dev@cumiskey.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19979|0 |1
is obsolete| |
------- Additional Comments From fop-dev@cumiskey.com 2007-04-27 01:53 -------
Created an attachment (id=20058)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20058&action=view)
patch file
Revised patch, see
http://wiki.apache.org/xmlgraphics-fop/ExtensionsForPostScript
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
dev@cumiskey.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20274|0 |1
is obsolete| |
------- Additional Comments From dev@cumiskey.com 2007-06-13 07:25 -------
Created an attachment (id=20341)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20341&action=view)
list of files
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
------- Additional Comments From jeremias@apache.org 2007-05-30 12:52 -------
Created an attachment (id=20292)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20292&action=view)
Test FO showing the problems described earlier
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
jeremias@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
------- Additional Comments From jeremias@apache.org 2007-05-30 12:49 -------
Adrian, I've looked into this patch today. I've found several issues I'd like
adressed:
- getPSGenerator() should probably be renamed to createPSGenerator(). A "get" is
a little misleading. After all, the method creates a new PSGenerator instance.
- In several places you create an anonymous inner class just to fill some values
in a PSArray, for example. Please note that while the source code might look
elegant, each of these constructs is creating an additional .class file with at
least 1KB in size while a normal variable access would only generate a few byte
code instructions.
- super.init() is missing in PSPageDeviceDictionary. This resulted in a
NullPointerException in my tests since those makers weren't initialized.
- The PostScript output caused errors in GhostScript/GhostView when I used the
setpagedevice functionality. Haven't investigated further. I'll attach the file
I tested with. Part of the content is copied from the example in the
documentation you wrote.
- I'd like the setpagedevice code to be an optional feature not normally
generated, since setpagedevice is usually device-specific. I usually
post-process PostScript to add media management so I wouldn't want to have to
remove it. It would be great if it were only activated if any ps-setpage-device
extension is used.
- You wrote that the patch contains a performance improvement concerning the
page setup. Is that a performance improvement in terms of processing speed
inside a PostScript engine? I'm asking because I don't see how the Renderer code
would be any/considerably faster like you propose. In the existing code there
are no time-consuming operations involved around the page setup that I can see
(although I didn't do any measurements). At any rate, I found out that the name
of the simple page master is not correctly generated for each page if you have
different page masters in your page-sequence-master. See my test file.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
dev@cumiskey.com changed:
What |Removed |Added
----------------------------------------------------------------------------
BugsThisDependsOn| |43069
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
dev@cumiskey.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20340|0 |1
is obsolete| |
------- Additional Comments From dev@cumiskey.com 2007-06-27 02:08 -------
Created an attachment (id=20399)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20399&action=view)
patch file
Updated patch with missing files (in my haste I forgot to add them to
subversion before creating the diff).
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
------- Additional Comments From dev@cumiskey.com 2007-06-27 02:11 -------
Greatly reduced the dictionary object, hence the objects package now removed.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
------- Additional Comments From dev@cumiskey.com 2007-06-13 07:23 -------
(In reply to comment #9)
> Adrian, I've looked into this patch today. I've found several issues I'd like
> adressed:
> - getPSGenerator() should probably be renamed to createPSGenerator(). A "get" is
> a little misleading. After all, the method creates a new PSGenerator instance.
I have renamed this method as you suggested.
> - In several places you create an anonymous inner class just to fill some values
> in a PSArray, for example. Please note that while the source code might look
> elegant, each of these constructs is creating an additional .class file with at
> least 1KB in size while a normal variable access would only generate a few byte
> code instructions.
I have refactored/simplified the code so there are a lot less classes to encapsulate
postscript dictionaries and their related components.
> - super.init() is missing in PSPageDeviceDictionary. This resulted in a
> NullPointerException in my tests since those makers weren't initialized.
This is fixed as a result of the simplification work.
> - The PostScript output caused errors in GhostScript/GhostView when I used the
> setpagedevice functionality. Haven't investigated further. I'll attach the file
> I tested with. Part of the content is copied from the example in the
> documentation you wrote.
I'm not sure what happened here, I wasn't able to reproduce this. This new code
produces no such errors in my unix ghost script interpreter.
> - I'd like the setpagedevice code to be an optional feature not normally
> generated, since setpagedevice is usually device-specific. I usually
> post-process PostScript to add media management so I wouldn't want to have to
> remove it. It would be great if it were only activated if any ps-setpage-device
> extension is used.
It is only activated when the extension is used. But it makes sense for the
postscript renderer to make SPD postscript function calls instead of direct
setpagedevice calls. It is more "safe" this way (i.e. an init-graphics call as
a result of a setpagedevice will not be made if the contents of the page device
dictionary has not changed). See section ps:ps-setpagedevice in
http://wiki.apache.org/xmlgraphics-fop/ExtensionsForPostScript
> - You wrote that the patch contains a performance improvement concerning the
> page setup. Is that a performance improvement in terms of processing speed
> inside a PostScript engine? I'm asking because I don't see how the Renderer code
> would be any/considerably faster like you propose. In the existing code there
> are no time-consuming operations involved around the page setup that I can see
> (although I didn't do any measurements). At any rate, I found out that the name
> of the simple page master is not correctly generated for each page if you have
> different page masters in your page-sequence-master. See my test file.
The idea was to improve the performance of the postscript renderer so it would
reuse the page master layout information for pages using the same page master.
I'm not sure it was worth the trouble so I have just removed this code. I have
now included the test file you provided as a unit test.
Adrian.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
------- Additional Comments From fop-dev@cumiskey.com 2007-04-17 05:07 -------
Created an attachment (id=19978)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=19978&action=view)
list of files
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
------- Additional Comments From jeremias@apache.org 2007-06-27 01:29 -------
Adrian, thanks for the updated patch. Unfortunately, it seems to be incomplete.
The class PSDictionary is missing and it doesn't seem to be expected in the
objects package like with the previous patch.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
dev@cumiskey.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20058|0 |1
is obsolete| |
------- Additional Comments From dev@cumiskey.com 2007-05-25 09:15 -------
Created an attachment (id=20273)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20273&action=view)
patch file
Checkstyled, improved javadocs, refactored in parts.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
dev@cumiskey.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20399|0 |1
is obsolete| |
------- Additional Comments From dev@cumiskey.com 2007-08-09 04:09 -------
Created an attachment (id=20621)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20621&action=view)
patch file
This patch depends upon the new safe set page device postscript macro being
applied to XmlGraphicsCommons (see
http://issues.apache.org/bugzilla/show_bug.cgi?id=43069).
* Adds new <ps:ps-setpagedevice/> extension to the postscript renderer
(see http://wiki.apache.org/xmlgraphics-fop/ExtensionsForPostScript for
details).
* Adds safe-set-page-device and dsc-compliant configurations options.
The default value for the "safe-set-page-device" setting is "false". Setting it
to "true" will cause the renderer to invoke a postscript macro which guards
against the possibility of invalid/unsupported postscript key/values being
issued to the implementing postscript page device.
The default value for the "dsc-compliant" setting is "true". Setting it
to "false" will break DSC compliance by minimizing the number of setpagedevice
calls in the postscript document output. This feature may be useful when
unwanted blank pages are experienced in your postscript output. This problem
is caused by the particular postscript implementation issuing unwanted
postscript subsystem initgraphics/erasepage calls on each setpagedevice call.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
bowditch_chris@hotmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
------- Additional Comments From bowditch_chris@hotmail.com 2007-10-04 06:53 -------
I've done some testing with your patch Adrian and it appears to work very
well. None of the previous problems reported by Jeremias showed up. I was able
to print Postscript and view in GhostView with all 4 combinations of the new
options that you've added. So I have committed the patch. Thanks!
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
dev@cumiskey.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20341|0 |1
is obsolete| |
------- Additional Comments From dev@cumiskey.com 2007-06-27 02:09 -------
Created an attachment (id=20400)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20400&action=view)
list of files
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
dev@cumiskey.com changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |43070
nThis| |
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
dev@cumiskey.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20059|0 |1
is obsolete| |
------- Additional Comments From dev@cumiskey.com 2007-05-25 09:16 -------
Created an attachment (id=20274)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20274&action=view)
list of files
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 42144] - [PATCH] Safely set postscript page device dictionary, additional processing states for OffDocumentItems
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42144>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144
------- Additional Comments From fop-dev@cumiskey.com 2007-04-18 09:16 -------
I think I may have misunderstood the requirement for the title implementation.
Jeremias, Don't waste too much time looking at this patch right now. I will try
and resubmit an amended patch sometime tomorrow.
Adrian.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.