You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/12/09 01:27:25 UTC

Review Request 41112: Add Service Wizard: Ranger requirements popup is displayed twice when adding Ranger Service

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41112/
-----------------------------------------------------------

Review request for Ambari, Srimanth Gunturi and Yusaku Sako.


Bugs: AMBARI-14279
    https://issues.apache.org/jira/browse/AMBARI-14279


Repository: ambari


Description
-------

*STR:*
# Launch "Add Service Wizard" to add Ranger
# On "Choose Services" page, check Ranger service checkbox
# After checking Ranger service, click on Next button (NOTE: This action needs to be done without delay once Ranger service checkbox is clicked in the above step)
# Ranger requirement popup will be shown. Wait over here for 15 seconds
# Then check "I have met all the requirements above." checkbox and click on proceed button

*Expected Result:* Wizard should move to "Assign Masters page"
*Actual Result:* User is presented with "Ranger Requirements" popup again for second time

The stated STR will reproduce the issue more often if not consistently every-time.


Diffs
-----

  ambari-web/app/controllers/wizard/step4_controller.js 4eefbcf 
  ambari-web/test/controllers/wizard/step4_test.js 1327a44 

Diff: https://reviews.apache.org/r/41112/diff/


Testing
-------

Tested the patch manually on a cluster.
Verified that all existing unit tests passes.


  10255 tests complete (11 seconds)
  106 tests pending


Thanks,

Jaimin Jetly


Re: Review Request 41112: Add Service Wizard: Ranger requirements popup is displayed twice when adding Ranger Service

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41112/#review109433
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Dec. 9, 2015, 12:27 a.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41112/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 12:27 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14279
>     https://issues.apache.org/jira/browse/AMBARI-14279
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> *STR:*
> # Launch "Add Service Wizard" to add Ranger
> # On "Choose Services" page, check Ranger service checkbox
> # After checking Ranger service, click on Next button (NOTE: This action needs to be done without delay once Ranger service checkbox is clicked in the above step)
> # Ranger requirement popup will be shown. Wait over here for 15 seconds
> # Then check "I have met all the requirements above." checkbox and click on proceed button
> 
> *Expected Result:* Wizard should move to "Assign Masters page"
> *Actual Result:* User is presented with "Ranger Requirements" popup again for second time
> 
> The stated STR will reproduce the issue more often if not consistently every-time.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step4_controller.js 4eefbcf 
>   ambari-web/test/controllers/wizard/step4_test.js 1327a44 
> 
> Diff: https://reviews.apache.org/r/41112/diff/
> 
> 
> Testing
> -------
> 
> Tested the patch manually on a cluster.
> Verified that all existing unit tests passes.
> 
> 
>   10255 tests complete (11 seconds)
>   106 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>