[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #1994: refactor(jira): extract common tools

[GitBox <gi...@apache.org>]

warren830 commented on code in PR #1994:
URL: https://github.com/apache/incubator-devlake/pull/1994#discussion_r886290412


##########
plugins/jira/api/connection.go:
##########
@@ -52,11 +49,12 @@ func TestConnection(input *core.ApiResourceInput) (*core.ApiResourceOutput, erro
 	if err != nil {
 		return nil, err
 	}
+
 	// test connection
 	apiClient, err := helper.NewApiClient(
 		connection.Endpoint,
 		map[string]string{
-			"Authorization": fmt.Sprintf("Basic %v", connection.Auth),
+			"Authorization": "",

Review Comment:
   I remember jira does not require this to do the test. Will check again



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org