You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/01/22 02:43:51 UTC

[GitHub] [skywalking-rust] kezhenxu94 commented on a change in pull request #10: harden e2e test by adding healthCheck

kezhenxu94 commented on a change in pull request #10:
URL: https://github.com/apache/skywalking-rust/pull/10#discussion_r790093449



##########
File path: .github/workflows/e2e.yml
##########
@@ -22,4 +22,7 @@ jobs:
           pip3 install --upgrade pip
           pip3 install setuptools
           pip3 install -r requirements.txt
+          until curl http://127.0.0.1:8081/healthCheck; do
+            sleep 1
+          done

Review comment:
       > @kezhenxu94 Is this a good practice?
   
   Ideally I’d put this check in the `run_e2e.py` so when running locally the healthiness is also checked. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org