You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by "Fang Zheng (JIRA)" <ji...@apache.org> on 2018/10/31 22:37:00 UTC

[jira] [Updated] (ORC-429) Refactor code in TypeImpl.cc

     [ https://issues.apache.org/jira/browse/ORC-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fang Zheng updated ORC-429:
---------------------------
    Component/s: C++

> Refactor code in TypeImpl.cc
> ----------------------------
>
>                 Key: ORC-429
>                 URL: https://issues.apache.org/jira/browse/ORC-429
>             Project: ORC
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Fang Zheng
>            Priority: Minor
>
> Propose to make two changes to the code in TypeImpl.cc
>  
> 1. In convertType() function: in the case of proto::Type_Kind_STRUCT, two vectors are created but never used. They shall be removed.
> 2. In TypeImpl::parseType() function: the function calls input.substr() to copy the substring before parsing it. This string copy can be avoided by directly parsing on the input string. Please see pull request for details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)