You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Peter N. Lundblad" <pe...@famlundblad.se> on 2004/07/07 23:09:11 UTC

make svncheck broken?

Hi,

I get a test failure while testing against svnserve. Here is a snippet of
the log:

CMD: svnadmin "create" "repositories/prop_tests-11" "--bdb-txn-nosync" "--fs-type=bdb" <TIME = 0.244695>
CMD: svnadmin dump "local_tmp/repos" | svnadmin load "repositories/prop_tests-11" <TIME = 0.002443>
CMD: svn "co" "--username" "jrandom" "--password" "rayjandom" "svn://localhost/repositories/prop_tests-11" "working_copies/prop_tests-11" "--config-dir" "/home/pn/src/svn/svn/subversion/tests/clients/cmdline/local_tmp/config" <TIME = 1.225431>
CMD: svn "propset" "--revprop" "-r" "0" "cash-sound" "cha-ching!" "working_copies/prop_tests-11" "--config-dir" "/home/pn/src/svn/svn/subversion/tests/clients/cmdline/local_tmp/config" <TIME = 0.100192>
CMD: svn "propget" "--revprop" "-r" "0" "cash-sound" "working_copies/prop_tests-11" "--config-dir" "/home/pn/src/svn/svn/subversion/tests/clients/cmdline/local_tmp/config" <TIME = 0.089724>
CMD: svn "propdel" "--revprop" "-r" "0" "cash-sound" "working_copies/prop_tests-11" "--config-dir" "/home/pn/src/svn/svn/subversion/tests/clients/cmdline/local_tmp/config" <TIME = 0.140544>
EXPECTED STDERR:
ACTUAL STDERR:
lt-svn: subversion/libsvn_ra_svn/marshal.c:427: vwrite_tuple: Assertion `opt || str' failed.
EXCEPTION: SVNLineUnequal
FAIL:  prop_tests.py 11: set, get, and delete a revprop change

This is when deleting a revprop. This code gets a NULL for the string
value of the deleted property, but that string isn't optional according to
the protocol spec. So I don't know how a revprop is supposed to be deleted
in this protocol. And I don't know when it broke.

//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: make svncheck broken?

Posted by Josh Pieper <jj...@pobox.com>.
Peter N. Lundblad wrote:
> Hi,
> 
> I get a test failure while testing against svnserve. Here is a snippet of
> the log:
> 
> CMD: svnadmin "create" "repositories/prop_tests-11" "--bdb-txn-nosync" "--fs-type=bdb" <TIME = 0.244695>
> CMD: svnadmin dump "local_tmp/repos" | svnadmin load "repositories/prop_tests-11" <TIME = 0.002443>
> CMD: svn "co" "--username" "jrandom" "--password" "rayjandom" "svn://localhost/repositories/prop_tests-11" "working_copies/prop_tests-11" "--config-dir" "/home/pn/src/svn/svn/subversion/tests/clients/cmdline/local_tmp/config" <TIME = 1.225431>
> CMD: svn "propset" "--revprop" "-r" "0" "cash-sound" "cha-ching!" "working_copies/prop_tests-11" "--config-dir" "/home/pn/src/svn/svn/subversion/tests/clients/cmdline/local_tmp/config" <TIME = 0.100192>
> CMD: svn "propget" "--revprop" "-r" "0" "cash-sound" "working_copies/prop_tests-11" "--config-dir" "/home/pn/src/svn/svn/subversion/tests/clients/cmdline/local_tmp/config" <TIME = 0.089724>
> CMD: svn "propdel" "--revprop" "-r" "0" "cash-sound" "working_copies/prop_tests-11" "--config-dir" "/home/pn/src/svn/svn/subversion/tests/clients/cmdline/local_tmp/config" <TIME = 0.140544>
> EXPECTED STDERR:
> ACTUAL STDERR:
> lt-svn: subversion/libsvn_ra_svn/marshal.c:427: vwrite_tuple: Assertion `opt || str' failed.
> EXCEPTION: SVNLineUnequal
> FAIL:  prop_tests.py 11: set, get, and delete a revprop change
> 
> This is when deleting a revprop. This code gets a NULL for the string
> value of the deleted property, but that string isn't optional according to
> the protocol spec. So I don't know how a revprop is supposed to be deleted
> in this protocol. And I don't know when it broke.

It's probably always been broken, I just added that test recently, but
only ran it over file:/// and http:// not svn://.  Someone with a
better knowledge of ra_svn want to take a look at fixing it?

-Josh

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org