You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "liwei (Jira)" <ji...@apache.org> on 2020/10/03 15:41:00 UTC
[jira] [Commented] (HUDI-1084) modify the getFileExtension in some
tests to use HoodieTable.getBaseFileExtension
[ https://issues.apache.org/jira/browse/HUDI-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206736#comment-17206736 ]
liwei commented on HUDI-1084:
-----------------------------
check and do not have some file need to change now
> modify the getFileExtension in some tests to use HoodieTable.getBaseFileExtension
> ---------------------------------------------------------------------------------
>
> Key: HUDI-1084
> URL: https://issues.apache.org/jira/browse/HUDI-1084
> Project: Apache Hudi
> Issue Type: New Feature
> Components: Utilities
> Reporter: liwei
> Assignee: liwei
> Priority: Major
>
> https://issues.apache.org/jira/browse/HUDI-684 when this issue "Introduce abstraction for writing and reading and compacting from FileGroups " has finished. we can replace
> HoodieFileFormat.PARQUET.getFileExtension to HoodieTable.getBaseFileExtension. But some tests and utils also use HoodieFileFormat.PARQUET.getFileExtension. such as:
> class FSUtils
> public static String makeDataFileName(String instantTime, String writeToken, String fileId) {
> return String.format("%s_%s_%s%s", fileId, writeToken, instantTime, HoodieFileFormat.PARQUET.getFileExtension());
> }
>
> class HoodieClientTestUtils
> if (paths[0].endsWith(HoodieFileFormat.PARQUET.getFileExtension())) {
> rows = sqlContext.read().parquet(paths);
> }
> ...
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)