You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/04 07:59:21 UTC
[GitHub] [airflow] LarsAlmgren opened a new issue, #24820: Dag disappears when DAG tag is longer than 100 char limit
LarsAlmgren opened a new issue, #24820:
URL: https://github.com/apache/airflow/issues/24820
### Apache Airflow version
2.2.5
### What happened
We added new DAG tags to a couple of our DAGs. In the case when the tag was longer than the 100 character limit the DAG was not showing in the UI and wasn't scheduled. It was however possible to reach it by typing in the URL to the DAG.
Usually when DAGs are broken there will be an error message in the UI, but this problem did not render any error message.
This problem occurred to one of our templated DAGs. Only one DAG broke and it was the one with a DAG tag which was too long. When we fixed the length, the DAG was scheduled and was visible in the UI again.
### What you think should happen instead
Exclude the dag if it is over the 250 character limit or show an error message in the UI.
### How to reproduce
Add a DAG tag which is longer than 100 characters.
### Operating System
Ubuntu
### Versions of Apache Airflow Providers
_No response_
### Deployment
Other 3rd-party Helm chart
### Deployment details
Running Airflow in Kubernetes.
Syncing DAGs from S3 with https://tech.scribd.com/blog/2020/breaking-up-the-dag-repo.html
### Anything else
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #24820: Dag disappears when DAG tag is longer than 100 char limit
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #24820: Dag disappears when DAG tag is longer than 100 char limit
URL: https://github.com/apache/airflow/issues/24820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] TommyDew42 commented on issue #24820: Dag disappears when DAG tag is longer than 100 char limit
Posted by GitBox <gi...@apache.org>.
TommyDew42 commented on issue #24820:
URL: https://github.com/apache/airflow/issues/24820#issuecomment-1187747103
@potiuk
I think we'll just add a length check to [tags](https://github.com/apache/airflow/blob/main/airflow/models/dag.py#L345).
If we have a tag with length >= 100, we raise an exception.
But I'm not sure how we pip install the dependencies. I [read](https://github.com/apache/airflow/blob/main/LOCAL_VIRTUALENV.rst#creating-a-local-virtualenv) that only `pip` installation is officially supported.
I wonder if [dev/requirements.txt](https://github.com/apache/airflow/blob/main/dev/requirements.txt) & [docker_test/requirements.txt](https://github.com/apache/airflow/blob/main/docker_tests/requirements.txt) are all the requirements.txt that can get us to run unit tests? Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #24820: Dag disappears when DAG tag is longer than 100 char limit
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #24820:
URL: https://github.com/apache/airflow/issues/24820#issuecomment-1173674811
Assigned you :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #24820: Dag disappears when DAG tag is longer than 100 char limit
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #24820:
URL: https://github.com/apache/airflow/issues/24820#issuecomment-1187759211
@TommyDew42 -> https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst has all the instruction on starting contribution and links to how to setup development environments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #24820: Dag disappears when DAG tag is longer than 100 char limit
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #24820:
URL: https://github.com/apache/airflow/issues/24820#issuecomment-1173484170
Interesting :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] TommyDew42 commented on issue #24820: Dag disappears when DAG tag is longer than 100 char limit
Posted by GitBox <gi...@apache.org>.
TommyDew42 commented on issue #24820:
URL: https://github.com/apache/airflow/issues/24820#issuecomment-1173610516
Hi! I'll pick up this good-first-issue!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org