You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/12 21:14:25 UTC
[GitHub] [superset] AAfghahi opened a new pull request #14089: feat: invalid hostname and password error messages (MySQL)
AAfghahi opened a new pull request #14089:
URL: https://github.com/apache/superset/pull/14089
### SUMMARY
Capture the most common error messages in MySQL, and return them to the user. This is used when first making a DB.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
### TEST PLAN
Created unit tests
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14089:
URL: https://github.com/apache/superset/pull/14089#issuecomment-818318573
# [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14089](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (125e6a5) into [master](https://codecov.io/gh/apache/superset/commit/7980b767c0ee5bbbd23b13a9434bd182e20f9613?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7980b76) will **increase** coverage by `0.00%`.
> The diff coverage is `86.73%`.
> :exclamation: Current head 125e6a5 differs from pull request most recent head b769fa4. Consider uploading reports for the commit b769fa4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14089 +/- ##
========================================
Coverage 79.48% 79.49%
========================================
Files 939 942 +3
Lines 47587 47689 +102
Branches 5949 6009 +60
========================================
+ Hits 37823 37908 +85
- Misses 9642 9660 +18
+ Partials 122 121 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.35% <89.07%> (+0.30%)` | :arrow_up: |
| hive | `?` | |
| mysql | `80.74% <90.19%> (-0.03%)` | :arrow_down: |
| postgres | `?` | |
| python | `80.74% <90.19%> (-0.47%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `60.00% <ø> (ø)` | |
| [...rontend/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEdyaWQuanN4) | `89.47% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.59% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `80.00% <ø> (+46.00%)` | :arrow_up: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `95.65% <ø> (+52.17%)` | :arrow_up: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `91.42% <ø> (+59.99%)` | :arrow_up: |
| [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `95.23% <ø> (+47.61%)` | :arrow_up: |
| [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `46.46% <ø> (ø)` | |
| ... and [83 more](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [786dadc...b769fa4](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a change in pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #14089:
URL: https://github.com/apache/superset/pull/14089#discussion_r611988979
##########
File path: docs/src/pages/docs/Miscellaneous/issue_codes.mdx
##########
@@ -144,8 +144,16 @@ that the username is typed correctly and exists in the database.
## Issue 1013
```
+<<<<<<< HEAD
Review comment:
thank you for pointing these out, I went through and checked and didn't see them on my local, pushed up and seems like they are gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14089:
URL: https://github.com/apache/superset/pull/14089#issuecomment-818318573
# [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14089](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50f3dc3) into [master](https://codecov.io/gh/apache/superset/commit/7980b767c0ee5bbbd23b13a9434bd182e20f9613?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7980b76) will **decrease** coverage by `0.29%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 50f3dc3 differs from pull request most recent head 5f42af2. Consider uploading reports for the commit 5f42af2 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14089 +/- ##
==========================================
- Coverage 79.48% 79.18% -0.30%
==========================================
Files 939 944 +5
Lines 47587 47984 +397
Branches 5949 6055 +106
==========================================
+ Hits 37823 37996 +173
- Misses 9642 9856 +214
- Partials 122 132 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.28% <ø> (+0.23%)` | :arrow_up: |
| javascript | `69.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.68% <ø> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `93.33% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.77% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <0.00%> (-84.27%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | `73.21% <0.00%> (-25.79%)` | :arrow_down: |
| [...rontend/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRGaWx0ZXJzLmpz) | `81.57% <0.00%> (-16.43%)` | :arrow_down: |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `62.00% <0.00%> (-15.42%)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [786dadc...5f42af2](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14089:
URL: https://github.com/apache/superset/pull/14089#issuecomment-818318573
# [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14089](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50f3dc3) into [master](https://codecov.io/gh/apache/superset/commit/7980b767c0ee5bbbd23b13a9434bd182e20f9613?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7980b76) will **decrease** coverage by `0.29%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 50f3dc3 differs from pull request most recent head 3d70a8b. Consider uploading reports for the commit 3d70a8b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14089 +/- ##
==========================================
- Coverage 79.48% 79.18% -0.30%
==========================================
Files 939 944 +5
Lines 47587 47984 +397
Branches 5949 6055 +106
==========================================
+ Hits 37823 37996 +173
- Misses 9642 9856 +214
- Partials 122 132 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.28% <ø> (+0.23%)` | :arrow_up: |
| javascript | `69.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.68% <ø> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `93.33% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.77% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <0.00%> (-84.27%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | `73.21% <0.00%> (-25.79%)` | :arrow_down: |
| [...rontend/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRGaWx0ZXJzLmpz) | `81.57% <0.00%> (-16.43%)` | :arrow_down: |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `62.00% <0.00%> (-15.42%)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [786dadc...3d70a8b](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14089:
URL: https://github.com/apache/superset/pull/14089#issuecomment-818318573
# [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14089](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50f3dc3) into [master](https://codecov.io/gh/apache/superset/commit/7980b767c0ee5bbbd23b13a9434bd182e20f9613?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7980b76) will **decrease** coverage by `0.29%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 50f3dc3 differs from pull request most recent head 7fcb78b. Consider uploading reports for the commit 7fcb78b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14089 +/- ##
==========================================
- Coverage 79.48% 79.18% -0.30%
==========================================
Files 939 944 +5
Lines 47587 47984 +397
Branches 5949 6055 +106
==========================================
+ Hits 37823 37996 +173
- Misses 9642 9856 +214
- Partials 122 132 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.28% <ø> (+0.23%)` | :arrow_up: |
| javascript | `69.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.68% <ø> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `93.33% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.77% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <0.00%> (-84.27%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | `73.21% <0.00%> (-25.79%)` | :arrow_down: |
| [...rontend/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRGaWx0ZXJzLmpz) | `81.57% <0.00%> (-16.43%)` | :arrow_down: |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `62.00% <0.00%> (-15.42%)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [786dadc...7fcb78b](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14089:
URL: https://github.com/apache/superset/pull/14089#issuecomment-818318573
# [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14089](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b769fa4) into [master](https://codecov.io/gh/apache/superset/commit/7980b767c0ee5bbbd23b13a9434bd182e20f9613?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7980b76) will **decrease** coverage by `0.46%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14089 +/- ##
==========================================
- Coverage 79.48% 79.01% -0.47%
==========================================
Files 939 949 +10
Lines 47587 48425 +838
Branches 5949 6200 +251
==========================================
+ Hits 37823 38264 +441
- Misses 9642 10026 +384
- Partials 122 135 +13
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `69.68% <ø> (+0.34%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `93.33% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.77% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `64.28% <0.00%> (-35.72%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | `71.42% <0.00%> (-27.58%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/reducers/dashboardInfo.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRJbmZvLmpz) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `58.82% <0.00%> (-18.60%)` | :arrow_down: |
| ... and [39 more](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [786dadc...b769fa4](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #14089:
URL: https://github.com/apache/superset/pull/14089#issuecomment-818318573
# [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14089](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50f3dc3) into [master](https://codecov.io/gh/apache/superset/commit/7980b767c0ee5bbbd23b13a9434bd182e20f9613?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7980b76) will **decrease** coverage by `0.29%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 50f3dc3 differs from pull request most recent head 7fcb78b. Consider uploading reports for the commit 7fcb78b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14089 +/- ##
==========================================
- Coverage 79.48% 79.18% -0.30%
==========================================
Files 939 944 +5
Lines 47587 47984 +397
Branches 5949 6058 +109
==========================================
+ Hits 37823 37996 +173
- Misses 9642 9856 +214
- Partials 122 132 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.28% <ø> (+0.23%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.68% <ø> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `93.33% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.77% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <0.00%> (-84.27%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | `73.21% <0.00%> (-25.79%)` | :arrow_down: |
| [...rontend/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRGaWx0ZXJzLmpz) | `81.57% <0.00%> (-16.43%)` | :arrow_down: |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `62.00% <0.00%> (-15.42%)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [786dadc...7fcb78b](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14089:
URL: https://github.com/apache/superset/pull/14089#issuecomment-818318573
# [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14089](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (125e6a5) into [master](https://codecov.io/gh/apache/superset/commit/7980b767c0ee5bbbd23b13a9434bd182e20f9613?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7980b76) will **increase** coverage by `0.24%`.
> The diff coverage is `86.73%`.
> :exclamation: Current head 125e6a5 differs from pull request most recent head b769fa4. Consider uploading reports for the commit b769fa4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14089 +/- ##
==========================================
+ Coverage 79.48% 79.72% +0.24%
==========================================
Files 939 942 +3
Lines 47587 47716 +129
Branches 5949 6009 +60
==========================================
+ Hits 37823 38042 +219
+ Misses 9642 9553 -89
+ Partials 122 121 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.35% <89.07%> (+0.30%)` | :arrow_up: |
| hive | `80.47% <90.19%> (-0.03%)` | :arrow_down: |
| mysql | `80.74% <90.19%> (-0.03%)` | :arrow_down: |
| postgres | `80.77% <90.19%> (-0.01%)` | :arrow_down: |
| python | `81.18% <90.19%> (-0.03%)` | :arrow_down: |
| sqlite | `80.37% <90.19%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `60.00% <ø> (ø)` | |
| [...rontend/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEdyaWQuanN4) | `89.47% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.59% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `80.00% <ø> (+46.00%)` | :arrow_up: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `95.65% <ø> (+52.17%)` | :arrow_up: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `91.42% <ø> (+59.99%)` | :arrow_up: |
| [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `95.23% <ø> (+47.61%)` | :arrow_up: |
| [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `46.46% <ø> (ø)` | |
| ... and [66 more](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [786dadc...b769fa4](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14089:
URL: https://github.com/apache/superset/pull/14089#issuecomment-818318573
# [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14089](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50f3dc3) into [master](https://codecov.io/gh/apache/superset/commit/7980b767c0ee5bbbd23b13a9434bd182e20f9613?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7980b76) will **decrease** coverage by `0.29%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 50f3dc3 differs from pull request most recent head b1cebda. Consider uploading reports for the commit b1cebda to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14089 +/- ##
==========================================
- Coverage 79.48% 79.18% -0.30%
==========================================
Files 939 944 +5
Lines 47587 47984 +397
Branches 5949 6055 +106
==========================================
+ Hits 37823 37996 +173
- Misses 9642 9856 +214
- Partials 122 132 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.28% <ø> (+0.23%)` | :arrow_up: |
| javascript | `69.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.68% <ø> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `93.33% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.77% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <0.00%> (-84.27%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | `73.21% <0.00%> (-25.79%)` | :arrow_down: |
| [...rontend/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRGaWx0ZXJzLmpz) | `81.57% <0.00%> (-16.43%)` | :arrow_down: |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `62.00% <0.00%> (-15.42%)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [786dadc...b1cebda](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14089:
URL: https://github.com/apache/superset/pull/14089#issuecomment-818318573
# [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14089](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50f3dc3) into [master](https://codecov.io/gh/apache/superset/commit/7980b767c0ee5bbbd23b13a9434bd182e20f9613?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7980b76) will **decrease** coverage by `0.29%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 50f3dc3 differs from pull request most recent head 9f922cb. Consider uploading reports for the commit 9f922cb to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14089 +/- ##
==========================================
- Coverage 79.48% 79.18% -0.30%
==========================================
Files 939 944 +5
Lines 47587 47984 +397
Branches 5949 6055 +106
==========================================
+ Hits 37823 37996 +173
- Misses 9642 9856 +214
- Partials 122 132 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.28% <ø> (+0.23%)` | :arrow_up: |
| javascript | `69.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.68% <ø> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `93.33% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.77% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <0.00%> (-84.27%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | `73.21% <0.00%> (-25.79%)` | :arrow_down: |
| [...rontend/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRGaWx0ZXJzLmpz) | `81.57% <0.00%> (-16.43%)` | :arrow_down: |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `62.00% <0.00%> (-15.42%)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [786dadc...9f922cb](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #14089:
URL: https://github.com/apache/superset/pull/14089#discussion_r612629840
##########
File path: docs/src/pages/docs/Miscellaneous/issue_codes.mdx
##########
@@ -141,11 +141,11 @@ The username provided when connecting to a database is not valid.
The user provided a username that doesn't exist in the database. Please check
that the username is typed correctly and exists in the database.
-## Issue 1013
+## Issue 1014
```
-The password provided when connecting to a database is not valid.
+Either the username or the password used are incorrect.
```
-The user provided a password that is incorrect. Please check that the
-password is typed correctly.
+Either the username provided does not exist or the password was written incorrectly. Please
+check that the username and password were typed correctly.
Review comment:
This is still overwriting an existing issue.
##########
File path: superset/db_engine_specs/mysql.py
##########
@@ -93,6 +106,21 @@ class MySQLEngineSpec(BaseEngineSpec):
type_code_map: Dict[int, str] = {} # loaded from get_datatype only if needed
+ custom_errors = {
+ TEST_CONNECTION_ACCESS_DENIED_REGEX: (
+ __('Either the username "%(username)s" or the password is incorrect.'),
+ SupersetErrorType.TEST_CONNECTION_ACCESS_DENIED_ERROR,
+ ),
+ TEST_CONNECTION_INVALID_HOSTNAME_REGEX: (
+ __('Unknown MySQL server host "%(hostname)s".'),
+ SupersetErrorType.TEST_CONNECTION_INVALID_HOSTNAME_ERROR,
+ ),
+ TEST_CONNECTION_HOST_DOWN_REGEX: (
+ __("The host %(hostname)s might be down and can't be reached."),
Review comment:
Let's be consistent and always quote the hostname (I need to do the same on my PR for MSSQL).
##########
File path: superset/errors.py
##########
@@ -164,14 +165,13 @@ class SupersetErrorType(str, Enum):
),
},
],
- SupersetErrorType.TEST_CONNECTION_INVALID_PASSWORD_ERROR: [
+ SupersetErrorType.TEST_CONNECTION_ACCESS_DENIED_ERROR: [
Review comment:
This still needs to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14089:
URL: https://github.com/apache/superset/pull/14089#issuecomment-818318573
# [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14089](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (125e6a5) into [master](https://codecov.io/gh/apache/superset/commit/7980b767c0ee5bbbd23b13a9434bd182e20f9613?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7980b76) will **increase** coverage by `0.33%`.
> The diff coverage is `86.73%`.
> :exclamation: Current head 125e6a5 differs from pull request most recent head b769fa4. Consider uploading reports for the commit b769fa4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14089 +/- ##
==========================================
+ Coverage 79.48% 79.81% +0.33%
==========================================
Files 939 942 +3
Lines 47587 47716 +129
Branches 5949 6009 +60
==========================================
+ Hits 37823 38083 +260
+ Misses 9642 9512 -130
+ Partials 122 121 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.35% <89.07%> (+0.30%)` | :arrow_up: |
| hive | `80.47% <90.19%> (-0.03%)` | :arrow_down: |
| mysql | `80.74% <90.19%> (-0.03%)` | :arrow_down: |
| postgres | `80.77% <90.19%> (-0.01%)` | :arrow_down: |
| presto | `80.50% <90.19%> (?)` | |
| python | `81.34% <90.19%> (+0.13%)` | :arrow_up: |
| sqlite | `80.37% <90.19%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `60.00% <ø> (ø)` | |
| [...rontend/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEdyaWQuanN4) | `89.47% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.59% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `80.00% <ø> (+46.00%)` | :arrow_up: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `95.65% <ø> (+52.17%)` | :arrow_up: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `91.42% <ø> (+59.99%)` | :arrow_up: |
| [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `95.23% <ø> (+47.61%)` | :arrow_up: |
| [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `46.46% <ø> (ø)` | |
| ... and [68 more](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [786dadc...b769fa4](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a change in pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #14089:
URL: https://github.com/apache/superset/pull/14089#discussion_r611989726
##########
File path: tests/db_engine_specs/mysql_tests.py
##########
@@ -104,3 +105,64 @@ def test_extract_error_message(self):
exception = OperationalError(123, message)
extracted_message = MySQLEngineSpec._extract_error_message(exception)
assert extracted_message == message
+
+ def test_extract_errors(self):
+ """
+ Test that custom error messages are extracted correctly.
+ """
+ msg = "mysql: Access denied for user 'test'@'testuser.com' "
+ result = MySQLEngineSpec.extract_errors(Exception(msg))
+ assert result == [
+ SupersetError(
+ error_type=SupersetErrorType.TEST_CONNECTION_ACCESS_DENIED_ERROR,
+ message='Either the username "test" or password is incorrect',
+ level=ErrorLevel.ERROR,
+ extra={
+ "engine_name": "MySQL",
+ "issue_codes": [
+ {
+ "code": 1013,
+ "message": "Issue 1013 - Either the username or the password is wrong.",
+ }
+ ],
+ },
+ )
+ ]
+
+ msg = "mysql: Unknown MySQL server host 'badhostname.com' "
+ result = MySQLEngineSpec.extract_errors(Exception(msg))
+ assert result == [
+ SupersetError(
+ error_type=SupersetErrorType.TEST_CONNECTION_INVALID_HOSTNAME_ERROR,
+ message='Unknown MySQL server host "badhostname.com"',
+ level=ErrorLevel.ERROR,
+ extra={
+ "engine_name": "MySQL",
+ "issue_codes": [
+ {
+ "code": 1007,
+ "message": "Issue 1007 - The hostname provided can't be resolved.",
+ }
+ ],
+ },
+ )
+ ]
+
+ msg = "mysql: Can't connect to MySQL server on 'badconnection.com'"
Review comment:
`psql: error: could not connect to server: Operation timed out
Is the server running on host "93.184.216.34" and accepting
TCP/IP connections on port 12345?
"""
)
result = PostgresEngineSpec.extract_errors(Exception(msg))
assert result == [
SupersetError(
error_type=SupersetErrorType.TEST_CONNECTION_HOST_DOWN_ERROR,
message=(
"The host 93.184.216.34 might be down, "
"and can't be reached on port 12345"
),
level=ErrorLevel.ERROR,
extra={"engine_name": "PostgreSQL"},
)
]`
Like this one? From your PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14089:
URL: https://github.com/apache/superset/pull/14089#issuecomment-818318573
# [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14089](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (125e6a5) into [master](https://codecov.io/gh/apache/superset/commit/7980b767c0ee5bbbd23b13a9434bd182e20f9613?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7980b76) will **decrease** coverage by `0.11%`.
> The diff coverage is `87.31%`.
> :exclamation: Current head 125e6a5 differs from pull request most recent head b769fa4. Consider uploading reports for the commit b769fa4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14089 +/- ##
==========================================
- Coverage 79.48% 79.37% -0.12%
==========================================
Files 939 942 +3
Lines 47587 47709 +122
Branches 5949 6009 +60
==========================================
+ Hits 37823 37867 +44
- Misses 9642 9710 +68
- Partials 122 132 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.39% <89.07%> (+1.34%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `60.00% <ø> (ø)` | |
| [...rontend/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEdyaWQuanN4) | `85.96% <ø> (-3.51%)` | :arrow_down: |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.59% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `80.00% <ø> (+46.00%)` | :arrow_up: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `95.65% <ø> (+52.17%)` | :arrow_up: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `91.42% <ø> (+59.99%)` | :arrow_up: |
| [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `95.23% <ø> (+47.61%)` | :arrow_up: |
| [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `46.46% <ø> (ø)` | |
| ... and [101 more](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [786dadc...b769fa4](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #14089:
URL: https://github.com/apache/superset/pull/14089#discussion_r611984606
##########
File path: superset-frontend/package-lock.json
##########
@@ -1,8 +1,9 @@
{
"name": "superset",
"version": "0.999.0dev",
- "lockfileVersion": 2,
+ "lockfileVersion": 1,
"requires": true,
+<<<<<<< HEAD
Review comment:
We don't want to update this file in a PR involving just the backend. You can rever this with:
```bash
$ git checkout master -- superset-frontend/package-lock.json
```
##########
File path: superset/db_engine_specs/mysql.py
##########
@@ -93,6 +104,21 @@ class MySQLEngineSpec(BaseEngineSpec):
type_code_map: Dict[int, str] = {} # loaded from get_datatype only if needed
+ custom_errors = {
+ INVALID_ACCESS_REGEX: (
+ __('Either the username "%(username)s" or password is incorrect'),
Review comment:
"... or **the** password is incorrect." would be better?
Also, all messages should end in a period.
##########
File path: superset/errors.py
##########
@@ -164,6 +165,7 @@ class SupersetErrorType(str, Enum):
),
},
],
+<<<<<<< HEAD
Review comment:
Fix fix
##########
File path: docs/src/pages/docs/Miscellaneous/issue_codes.mdx
##########
@@ -144,8 +144,16 @@ that the username is typed correctly and exists in the database.
## Issue 1013
```
+<<<<<<< HEAD
Review comment:
Fix this merge conflict?
##########
File path: tests/db_engine_specs/mysql_tests.py
##########
@@ -104,3 +105,64 @@ def test_extract_error_message(self):
exception = OperationalError(123, message)
extracted_message = MySQLEngineSpec._extract_error_message(exception)
assert extracted_message == message
+
+ def test_extract_errors(self):
+ """
+ Test that custom error messages are extracted correctly.
+ """
+ msg = "mysql: Access denied for user 'test'@'testuser.com' "
+ result = MySQLEngineSpec.extract_errors(Exception(msg))
+ assert result == [
+ SupersetError(
+ error_type=SupersetErrorType.TEST_CONNECTION_ACCESS_DENIED_ERROR,
+ message='Either the username "test" or password is incorrect',
+ level=ErrorLevel.ERROR,
+ extra={
+ "engine_name": "MySQL",
+ "issue_codes": [
+ {
+ "code": 1013,
+ "message": "Issue 1013 - Either the username or the password is wrong.",
+ }
+ ],
+ },
+ )
+ ]
+
+ msg = "mysql: Unknown MySQL server host 'badhostname.com' "
+ result = MySQLEngineSpec.extract_errors(Exception(msg))
+ assert result == [
+ SupersetError(
+ error_type=SupersetErrorType.TEST_CONNECTION_INVALID_HOSTNAME_ERROR,
+ message='Unknown MySQL server host "badhostname.com"',
+ level=ErrorLevel.ERROR,
+ extra={
+ "engine_name": "MySQL",
+ "issue_codes": [
+ {
+ "code": 1007,
+ "message": "Issue 1007 - The hostname provided can't be resolved.",
+ }
+ ],
+ },
+ )
+ ]
+
+ msg = "mysql: Can't connect to MySQL server on 'badconnection.com'"
Review comment:
Can you try also with an IP address instead of a name? To see if the message is similar and still gets captured?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #14089:
URL: https://github.com/apache/superset/pull/14089#discussion_r611984606
##########
File path: superset-frontend/package-lock.json
##########
@@ -1,8 +1,9 @@
{
"name": "superset",
"version": "0.999.0dev",
- "lockfileVersion": 2,
+ "lockfileVersion": 1,
"requires": true,
+<<<<<<< HEAD
Review comment:
We don't want to update this file in a PR involving just the backend. You can revert this with:
```bash
$ git checkout master -- superset-frontend/package-lock.json
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14089:
URL: https://github.com/apache/superset/pull/14089#issuecomment-818318573
# [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14089](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (125e6a5) into [master](https://codecov.io/gh/apache/superset/commit/7980b767c0ee5bbbd23b13a9434bd182e20f9613?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7980b76) will **increase** coverage by `0.05%`.
> The diff coverage is `86.73%`.
> :exclamation: Current head 125e6a5 differs from pull request most recent head b769fa4. Consider uploading reports for the commit b769fa4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14089 +/- ##
==========================================
+ Coverage 79.48% 79.53% +0.05%
==========================================
Files 939 942 +3
Lines 47587 47716 +129
Branches 5949 6009 +60
==========================================
+ Hits 37823 37950 +127
- Misses 9642 9645 +3
+ Partials 122 121 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.35% <89.07%> (+0.30%)` | :arrow_up: |
| hive | `?` | |
| mysql | `80.74% <90.19%> (-0.03%)` | :arrow_down: |
| postgres | `80.77% <90.19%> (-0.01%)` | :arrow_down: |
| python | `80.82% <90.19%> (-0.39%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `60.00% <ø> (ø)` | |
| [...rontend/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEdyaWQuanN4) | `89.47% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.59% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `80.00% <ø> (+46.00%)` | :arrow_up: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `95.65% <ø> (+52.17%)` | :arrow_up: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `91.42% <ø> (+59.99%)` | :arrow_up: |
| [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `95.23% <ø> (+47.61%)` | :arrow_up: |
| [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `46.46% <ø> (ø)` | |
| ... and [74 more](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [786dadc...b769fa4](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #14089:
URL: https://github.com/apache/superset/pull/14089#discussion_r612026760
##########
File path: superset/db_engine_specs/mysql.py
##########
@@ -93,6 +104,21 @@ class MySQLEngineSpec(BaseEngineSpec):
type_code_map: Dict[int, str] = {} # loaded from get_datatype only if needed
+ custom_errors = {
+ INVALID_ACCESS_REGEX: (
+ __('Either the username "%(username)s" or the password is incorrect.'),
+ SupersetErrorType.TEST_CONNECTION_ACCESS_DENIED_ERROR,
+ ),
+ INVALID_HOSTNAME_REGEX: (
+ __('Unknown MySQL server host "%(hostname)s"'),
+ SupersetErrorType.TEST_CONNECTION_INVALID_HOSTNAME_ERROR,
+ ),
+ CONNECTION_HOST_DOWN_REGEX: (
Review comment:
Ah, I just saw that this already existed, sorry.
But I think we should call this `TEST_CONNECTION_HOST_DOWN_REGEX`, to match the error type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14089:
URL: https://github.com/apache/superset/pull/14089#issuecomment-818318573
# [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14089](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (125e6a5) into [master](https://codecov.io/gh/apache/superset/commit/7980b767c0ee5bbbd23b13a9434bd182e20f9613?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7980b76) will **increase** coverage by `0.24%`.
> The diff coverage is `87.31%`.
> :exclamation: Current head 125e6a5 differs from pull request most recent head b769fa4. Consider uploading reports for the commit b769fa4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14089 +/- ##
==========================================
+ Coverage 79.48% 79.72% +0.24%
==========================================
Files 939 942 +3
Lines 47587 47709 +122
Branches 5949 6009 +60
==========================================
+ Hits 37823 38035 +212
+ Misses 9642 9553 -89
+ Partials 122 121 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.35% <89.07%> (+0.30%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `60.00% <ø> (ø)` | |
| [...rontend/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEdyaWQuanN4) | `89.47% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.59% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `80.00% <ø> (+46.00%)` | :arrow_up: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `95.65% <ø> (+52.17%)` | :arrow_up: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `91.42% <ø> (+59.99%)` | :arrow_up: |
| [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `95.23% <ø> (+47.61%)` | :arrow_up: |
| [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `46.46% <ø> (ø)` | |
| ... and [68 more](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [786dadc...b769fa4](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14089:
URL: https://github.com/apache/superset/pull/14089#issuecomment-818318573
# [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14089](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (125e6a5) into [master](https://codecov.io/gh/apache/superset/commit/7980b767c0ee5bbbd23b13a9434bd182e20f9613?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7980b76) will **increase** coverage by `0.33%`.
> The diff coverage is `86.73%`.
> :exclamation: Current head 125e6a5 differs from pull request most recent head b769fa4. Consider uploading reports for the commit b769fa4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14089 +/- ##
==========================================
+ Coverage 79.48% 79.81% +0.33%
==========================================
Files 939 942 +3
Lines 47587 47716 +129
Branches 5949 6009 +60
==========================================
+ Hits 37823 38083 +260
+ Misses 9642 9512 -130
+ Partials 122 121 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.35% <89.07%> (+0.30%)` | :arrow_up: |
| hive | `80.47% <90.19%> (-0.03%)` | :arrow_down: |
| mysql | `80.74% <90.19%> (-0.03%)` | :arrow_down: |
| postgres | `80.77% <90.19%> (-0.01%)` | :arrow_down: |
| presto | `80.50% <90.19%> (?)` | |
| python | `81.34% <90.19%> (+0.13%)` | :arrow_up: |
| sqlite | `80.37% <90.19%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `60.00% <ø> (ø)` | |
| [...rontend/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEdyaWQuanN4) | `89.47% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.59% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `80.00% <ø> (+46.00%)` | :arrow_up: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `95.65% <ø> (+52.17%)` | :arrow_up: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `91.42% <ø> (+59.99%)` | :arrow_up: |
| [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `95.23% <ø> (+47.61%)` | :arrow_up: |
| [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `46.46% <ø> (ø)` | |
| ... and [68 more](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [786dadc...b769fa4](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14089:
URL: https://github.com/apache/superset/pull/14089#issuecomment-818318573
# [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14089](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50f3dc3) into [master](https://codecov.io/gh/apache/superset/commit/7980b767c0ee5bbbd23b13a9434bd182e20f9613?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7980b76) will **decrease** coverage by `0.29%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 50f3dc3 differs from pull request most recent head 39236ef. Consider uploading reports for the commit 39236ef to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14089 +/- ##
==========================================
- Coverage 79.48% 79.18% -0.30%
==========================================
Files 939 944 +5
Lines 47587 47984 +397
Branches 5949 6055 +106
==========================================
+ Hits 37823 37996 +173
- Misses 9642 9856 +214
- Partials 122 132 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.28% <ø> (+0.23%)` | :arrow_up: |
| javascript | `69.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.68% <ø> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `93.33% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.77% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <0.00%> (-84.27%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | `73.21% <0.00%> (-25.79%)` | :arrow_down: |
| [...rontend/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRGaWx0ZXJzLmpz) | `81.57% <0.00%> (-16.43%)` | :arrow_down: |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `62.00% <0.00%> (-15.42%)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [786dadc...39236ef](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #14089:
URL: https://github.com/apache/superset/pull/14089#discussion_r611997737
##########
File path: superset/db_engine_specs/mysql.py
##########
@@ -93,6 +104,21 @@ class MySQLEngineSpec(BaseEngineSpec):
type_code_map: Dict[int, str] = {} # loaded from get_datatype only if needed
+ custom_errors = {
+ INVALID_ACCESS_REGEX: (
+ __('Either the username "%(username)s" or the password is incorrect.'),
+ SupersetErrorType.TEST_CONNECTION_ACCESS_DENIED_ERROR,
+ ),
+ INVALID_HOSTNAME_REGEX: (
+ __('Unknown MySQL server host "%(hostname)s"'),
+ SupersetErrorType.TEST_CONNECTION_INVALID_HOSTNAME_ERROR,
+ ),
+ CONNECTION_HOST_DOWN_REGEX: (
Review comment:
Same here, let's call this just `HOST_DOWN_REGEX`.
##########
File path: superset/db_engine_specs/mysql.py
##########
@@ -93,6 +104,21 @@ class MySQLEngineSpec(BaseEngineSpec):
type_code_map: Dict[int, str] = {} # loaded from get_datatype only if needed
+ custom_errors = {
+ INVALID_ACCESS_REGEX: (
+ __('Either the username "%(username)s" or the password is incorrect.'),
+ SupersetErrorType.TEST_CONNECTION_ACCESS_DENIED_ERROR,
+ ),
+ INVALID_HOSTNAME_REGEX: (
+ __('Unknown MySQL server host "%(hostname)s"'),
Review comment:
Period here as well.
##########
File path: superset/db_engine_specs/mysql.py
##########
@@ -93,6 +104,21 @@ class MySQLEngineSpec(BaseEngineSpec):
type_code_map: Dict[int, str] = {} # loaded from get_datatype only if needed
+ custom_errors = {
+ INVALID_ACCESS_REGEX: (
+ __('Either the username "%(username)s" or the password is incorrect.'),
+ SupersetErrorType.TEST_CONNECTION_ACCESS_DENIED_ERROR,
Review comment:
Let's rename the regex to `ACCESS_DENIED_REGEX`, to be consistent with the other errors.
##########
File path: docs/src/pages/docs/Miscellaneous/issue_codes.mdx
##########
@@ -144,8 +144,8 @@ that the username is typed correctly and exists in the database.
## Issue 1013
```
-The password provided when connecting to a database is not valid.
+Either the username or the password used are incorrect.
```
-The user provided a password that is incorrect. Please check that the
-password is typed correctly.
+Either the username provided does not exist or the password was written incorrectly. Please
+check that the username and were typed correctly.
Review comment:
I merged issue 1013 already, so your PR is trying to replace it. You need to use 1014 now.
##########
File path: tests/db_engine_specs/mysql_tests.py
##########
@@ -104,3 +105,64 @@ def test_extract_error_message(self):
exception = OperationalError(123, message)
extracted_message = MySQLEngineSpec._extract_error_message(exception)
assert extracted_message == message
+
+ def test_extract_errors(self):
+ """
+ Test that custom error messages are extracted correctly.
+ """
+ msg = "mysql: Access denied for user 'test'@'testuser.com' "
+ result = MySQLEngineSpec.extract_errors(Exception(msg))
+ assert result == [
+ SupersetError(
+ error_type=SupersetErrorType.TEST_CONNECTION_ACCESS_DENIED_ERROR,
+ message='Either the username "test" or password is incorrect',
+ level=ErrorLevel.ERROR,
+ extra={
+ "engine_name": "MySQL",
+ "issue_codes": [
+ {
+ "code": 1013,
+ "message": "Issue 1013 - Either the username or the password is wrong.",
+ }
+ ],
+ },
+ )
+ ]
+
+ msg = "mysql: Unknown MySQL server host 'badhostname.com' "
+ result = MySQLEngineSpec.extract_errors(Exception(msg))
+ assert result == [
+ SupersetError(
+ error_type=SupersetErrorType.TEST_CONNECTION_INVALID_HOSTNAME_ERROR,
+ message='Unknown MySQL server host "badhostname.com"',
+ level=ErrorLevel.ERROR,
+ extra={
+ "engine_name": "MySQL",
+ "issue_codes": [
+ {
+ "code": 1007,
+ "message": "Issue 1007 - The hostname provided can't be resolved.",
+ }
+ ],
+ },
+ )
+ ]
+
+ msg = "mysql: Can't connect to MySQL server on 'badconnection.com'"
Review comment:
For Postgres I tested with both a hostname and an IP, and made sure the regex captured both.
##########
File path: superset/errors.py
##########
@@ -164,14 +165,13 @@ class SupersetErrorType(str, Enum):
),
},
],
- SupersetErrorType.TEST_CONNECTION_INVALID_PASSWORD_ERROR: [
+ SupersetErrorType.TEST_CONNECTION_ACCESS_DENIED_ERROR: [
Review comment:
Same thing, your PR is trying to override an existing error. You need to change this to 1014 and add it below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida merged pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #14089:
URL: https://github.com/apache/superset/pull/14089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a change in pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #14089:
URL: https://github.com/apache/superset/pull/14089#discussion_r612509405
##########
File path: superset/db_engine_specs/mysql.py
##########
@@ -93,6 +104,21 @@ class MySQLEngineSpec(BaseEngineSpec):
type_code_map: Dict[int, str] = {} # loaded from get_datatype only if needed
+ custom_errors = {
+ INVALID_ACCESS_REGEX: (
+ __('Either the username "%(username)s" or the password is incorrect.'),
+ SupersetErrorType.TEST_CONNECTION_ACCESS_DENIED_ERROR,
+ ),
+ INVALID_HOSTNAME_REGEX: (
+ __('Unknown MySQL server host "%(hostname)s"'),
+ SupersetErrorType.TEST_CONNECTION_INVALID_HOSTNAME_ERROR,
+ ),
+ CONNECTION_HOST_DOWN_REGEX: (
Review comment:
this makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #14089:
URL: https://github.com/apache/superset/pull/14089#discussion_r612026864
##########
File path: superset/db_engine_specs/mysql.py
##########
@@ -93,6 +104,21 @@ class MySQLEngineSpec(BaseEngineSpec):
type_code_map: Dict[int, str] = {} # loaded from get_datatype only if needed
+ custom_errors = {
+ INVALID_ACCESS_REGEX: (
+ __('Either the username "%(username)s" or the password is incorrect.'),
+ SupersetErrorType.TEST_CONNECTION_ACCESS_DENIED_ERROR,
+ ),
+ INVALID_HOSTNAME_REGEX: (
+ __('Unknown MySQL server host "%(hostname)s"'),
+ SupersetErrorType.TEST_CONNECTION_INVALID_HOSTNAME_ERROR,
+ ),
+ CONNECTION_HOST_DOWN_REGEX: (
Review comment:
Let's use that pattern as we add regexes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14089:
URL: https://github.com/apache/superset/pull/14089#issuecomment-818318573
# [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14089](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (125e6a5) into [master](https://codecov.io/gh/apache/superset/commit/7980b767c0ee5bbbd23b13a9434bd182e20f9613?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7980b76) will **increase** coverage by `0.07%`.
> The diff coverage is `86.73%`.
> :exclamation: Current head 125e6a5 differs from pull request most recent head b769fa4. Consider uploading reports for the commit b769fa4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14089 +/- ##
==========================================
+ Coverage 79.48% 79.55% +0.07%
==========================================
Files 939 942 +3
Lines 47587 47716 +129
Branches 5949 6009 +60
==========================================
+ Hits 37823 37959 +136
+ Misses 9642 9636 -6
+ Partials 122 121 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.35% <89.07%> (+0.30%)` | :arrow_up: |
| hive | `?` | |
| mysql | `80.74% <90.19%> (-0.03%)` | :arrow_down: |
| postgres | `80.77% <90.19%> (-0.01%)` | :arrow_down: |
| python | `80.85% <90.19%> (-0.36%)` | :arrow_down: |
| sqlite | `80.37% <90.19%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `60.00% <ø> (ø)` | |
| [...rontend/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEdyaWQuanN4) | `89.47% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.59% <ø> (ø)` | |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `80.00% <ø> (+46.00%)` | :arrow_up: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `95.65% <ø> (+52.17%)` | :arrow_up: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `91.42% <ø> (+59.99%)` | :arrow_up: |
| [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `95.23% <ø> (+47.61%)` | :arrow_up: |
| [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `46.46% <ø> (ø)` | |
| ... and [71 more](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [786dadc...b769fa4](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14089: feat: invalid hostname and password error messages (MySQL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14089:
URL: https://github.com/apache/superset/pull/14089#issuecomment-818318573
# [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14089](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50f3dc3) into [master](https://codecov.io/gh/apache/superset/commit/7980b767c0ee5bbbd23b13a9434bd182e20f9613?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7980b76) will **decrease** coverage by `0.29%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 50f3dc3 differs from pull request most recent head b769fa4. Consider uploading reports for the commit b769fa4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14089 +/- ##
==========================================
- Coverage 79.48% 79.18% -0.30%
==========================================
Files 939 944 +5
Lines 47587 47984 +397
Branches 5949 6055 +106
==========================================
+ Hits 37823 37996 +173
- Misses 9642 9856 +214
- Partials 122 132 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.28% <ø> (+0.23%)` | :arrow_up: |
| javascript | `69.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.68% <ø> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `93.33% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.77% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <0.00%> (-84.27%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | `73.21% <0.00%> (-25.79%)` | :arrow_down: |
| [...rontend/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRGaWx0ZXJzLmpz) | `81.57% <0.00%> (-16.43%)` | :arrow_down: |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `62.00% <0.00%> (-15.42%)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/superset/pull/14089/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [786dadc...b769fa4](https://codecov.io/gh/apache/superset/pull/14089?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org