You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2017/12/12 06:58:41 UTC
[GitHub] guacamole-client pull request #218: GUACAMOLE-363: Correct DOS-style newline...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/guacamole-client/pull/218
GUACAMOLE-363: Correct DOS-style newlines within SQL Server schema before it's too late.
While working on updating the SQL Server schema with respect to the user history changes, I ran into trouble due to the line endings of the SQL Server schema files using DOS-style newlines rather than UNIX-style like the rest of the codebase.
This change does nothing more than `dos2unix` the SQL Server schema files, before things get too baked into history and such a change becomes impractical.
Adding a `w=1` query parameter to the GitHub URL for the comparison/diff should to ignore whitespace should show zero other changes (see https://github.com/blog/967-github-secrets).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/guacamole-client fix-dos-newlines
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/guacamole-client/pull/218.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #218
----
commit 303bc49d7a39cd6b1dec1048e51afb9aa055b8fc
Author: Michael Jumper <mj...@apache.org>
Date: 2017-12-12T06:53:19Z
GUACAMOLE-363: Correct DOS-style newlines within SQL Server schema before it's too late.
----
---
[GitHub] guacamole-client pull request #218: GUACAMOLE-363: Correct DOS-style newline...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/guacamole-client/pull/218
---